Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 851588 - sci-chemistry/pymol: fix distutils-r1 usage
Summary: sci-chemistry/pymol: fix distutils-r1 usage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Chemistry-Related Packages
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks: 803152
  Show dependency tree
 
Reported: 2022-06-12 16:08 UTC by Sam James
Modified: 2023-07-19 08:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-12 16:08:15 UTC
Need to swap out "python_foreach_impl ..." -> a call to e.g. distutils-r1_src_install and then define the python_compile() phase.

https://github.com/gentoo/gentoo/pull/25822 has some discussion for it, but it's to fit better with eclass assumptions.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-10 06:14:35 UTC
Ping.
Comment 2 Soren Harward 2023-02-07 13:46:27 UTC
I can't even get >pymol-2.5.0 to build because of improper use of mydistutilsargs:

 * ERROR: sci-chemistry/pymol-2.5.0-r2::gentoo failed (compile phase):
 *   mydistutilsargs is banned in EAPI 8 (use DISTUTILS_ARGS)
 * 
 * Call stack:
 *     ebuild.sh, line  136:  Called src_compile
 *   environment, line 4279:  Called distutils-r1_src_compile
 *   environment, line 1964:  Called _distutils-r1_run_foreach_impl 'distutils-r1_python_compile'
 *   environment, line  743:  Called python_foreach_impl 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 3871:  Called multibuild_foreach_variant '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 3404:  Called _multibuild_run '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 3402:  Called _python_multibuild_wrapper 'distutils-r1_run_phase' 'distutils-r1_python_compile'
 *   environment, line 1177:  Called distutils-r1_run_phase 'distutils-r1_python_compile'
 *   environment, line 1946:  Called distutils-r1_python_compile
 *   environment, line 1752:  Called esetup.py 'build' '-j' '9'
 *   environment, line 2570:  Called die
 * The specific snippet of code:
 *           die "mydistutilsargs is banned in EAPI ${EAPI} (use DISTUTILS_ARGS)";
Comment 3 Pacho Ramos gentoo-dev 2023-06-20 12:57:05 UTC
I don't know what are we meant to change and the equivalent
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-18 19:11:54 UTC
(In reply to Pacho Ramos from comment #3)
> I don't know what are we meant to change and the equivalent

* wrt mydistutils args: It tells you:
> *   mydistutilsargs is banned in EAPI 8 (use DISTUTILS_ARGS)

* wrt phase changes: don't call python_foreach_impl src_install etc, but instead define python_install(), repeat for each phase you call python_foreach_impl for.
Comment 5 Larry the Git Cow gentoo-dev 2023-07-19 08:28:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e4cabe39a1ad71a44b89b696142bab6226291a4

commit 5e4cabe39a1ad71a44b89b696142bab6226291a4
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2023-07-19 08:26:10 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2023-07-19 08:28:05 +0000

    sci-chemistry/pymol: Fix distutils-r1 usage
    
    Thanks-to: Sam James
    Closes: https://bugs.gentoo.org/851588
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 sci-chemistry/pymol/pymol-2.5.0-r3.ebuild | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
Comment 6 Pacho Ramos gentoo-dev 2023-07-19 08:29:22 UTC
(In reply to Sam James from comment #4)
> (In reply to Pacho Ramos from comment #3)
> > I don't know what are we meant to change and the equivalent
> 
> * wrt mydistutils args: It tells you:
> > *   mydistutilsargs is banned in EAPI 8 (use DISTUTILS_ARGS)
> 
> * wrt phase changes: don't call python_foreach_impl src_install etc, but
> instead define python_install(), repeat for each phase you call
> python_foreach_impl for.

Thanks

I will follow in bug 910021 for the other migration... but last time I tried (some months ago) it was a disaster :S