After upgrade to dev-libs/libfmt-10.0.0, dev-libs/spdlog-1.11.0 fails to rebuild. /var/tmp/portage/dev-libs/spdlog-1.11.0/work/spdlog-1.11.0/include/spdlog/common.h:168:111: error: ‘basic_runtime’ is not a member of ‘fmt’ /var/tmp/portage/dev-libs/spdlog-1.11.0/work/spdlog-1.11.0/include/spdlog/common.h:168:125: error: template argument 2 is invalid /var/tmp/portage/dev-libs/spdlog-1.11.0/work/spdlog-1.11.0/include/spdlog/common.h:168:138: error: expected ‘{’ before ‘>’ token This issue already fixed on upstream, please add this patch: https://github.com/gabime/spdlog/pull/2694
Created attachment 861432 [details] info.txt emerge --info
Created attachment 861433 [details] build.log
Can you do a PR to add it in? thanks
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=03d7b984817fbf07c4d830f30e34ae20a79af7b4 commit 03d7b984817fbf07c4d830f30e34ae20a79af7b4 Author: jinqiang zhang <peeweep@0x0.ee> AuthorDate: 2023-05-10 15:15:00 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-10 15:21:04 +0000 dev-libs/spdlog: fix fails compile with libfmt-10.0.0 Closes: https://bugs.gentoo.org/906069 Signed-off-by: jinqiang zhang <peeweep@0x0.ee> Closes: https://github.com/gentoo/gentoo/pull/30974 Signed-off-by: Sam James <sam@gentoo.org> dev-libs/spdlog/files/spdlog-libfmt-10.0.0.patch | 30 ++++++++++++++++++++++++ dev-libs/spdlog/spdlog-1.11.0.ebuild | 1 + 2 files changed, 31 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c75626a840b049c50a500b3d29a54986ea2372da commit c75626a840b049c50a500b3d29a54986ea2372da Author: Sam James <sam@gentoo.org> AuthorDate: 2023-05-10 16:09:19 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-10 16:09:48 +0000 Revert "dev-libs/spdlog: fix fails compile with libfmt-10.0.0" This reverts commit 03d7b984817fbf07c4d830f30e34ae20a79af7b4. Bug: https://bugs.gentoo.org/906069 Bug: https://bugs.gentoo.org/906071 Signed-off-by: Sam James <sam@gentoo.org> dev-libs/spdlog/files/spdlog-libfmt-10.0.0.patch | 30 ------------------------ dev-libs/spdlog/spdlog-1.11.0.ebuild | 1 - 2 files changed, 31 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71f385b11af6bcbf09f59a970c531771650d9c2f commit 71f385b11af6bcbf09f59a970c531771650d9c2f Author: Sam James <sam@gentoo.org> AuthorDate: 2023-05-10 16:09:17 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-10 16:09:26 +0000 Revert "dev-libs/spdlog: add patch metadata" This reverts commit f6ca1358c59588198f05aa99b61fdac26dfad42b. Bug: https://bugs.gentoo.org/906069 Bug: https://bugs.gentoo.org/906071 Signed-off-by: Sam James <sam@gentoo.org> dev-libs/spdlog/files/spdlog-libfmt-10.0.0.patch | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a7f6e70a391191a79c64e0eb95b5c806d7dbb26 commit 5a7f6e70a391191a79c64e0eb95b5c806d7dbb26 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-05-10 16:08:49 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-10 16:08:49 +0000 profiles: mask =dev-libs/libfmt-10.0.0 Bug: https://bugs.gentoo.org/906077 Bug: https://bugs.gentoo.org/906068 Bug: https://bugs.gentoo.org/906071 Bug: https://bugs.gentoo.org/906074 Bug: https://bugs.gentoo.org/906075 Bug: https://bugs.gentoo.org/906076 Bug: https://bugs.gentoo.org/906069 Signed-off-by: Sam James <sam@gentoo.org> profiles/package.mask | 5 +++++ 1 file changed, 5 insertions(+)
Reopening b/c reverted fix due to bug 906071.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9cebb80848d9b7f2b3cb78f6f2d97fe15bd40d67 commit 9cebb80848d9b7f2b3cb78f6f2d97fe15bd40d67 Author: David Roman <davidroman96@gmail.com> AuthorDate: 2023-05-22 14:02:53 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-05-27 07:49:20 +0000 dev-libs/spdlog: fix libfmt compatibility issue Closes: https://bugs.gentoo.org/906069 Closes: https://bugs.gentoo.org/906083 Signed-off-by: David Roman <davidroman96@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/31127 Signed-off-by: Joonas Niilola <juippis@gentoo.org> dev-libs/spdlog/spdlog-1.11.0-r1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reopening as it's not fixed, just version-capped.
(In reply to Sam James from comment #8) > Reopening as it's not fixed, just version-capped. Not sure if https://github.com/gabime/spdlog/commit/62a4b8ce4ee985e7c7f3c2bbce2195634c5d7ae3 and https://github.com/gabime/spdlog/commit/31cf79a70dfa61a4b2b7509eecca6a3b269bfc4a will be enough or..?
Seems that https://github.com/gabime/spdlog/commit/0ca574ae168820da0268b3ec7607ca7b33024d05 is also needed
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=682906906c17c3127b5f9dfd984bbd4ea91902bc commit 682906906c17c3127b5f9dfd984bbd4ea91902bc Author: David Roman <droman@ifae.es> AuthorDate: 2023-06-26 22:25:38 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-07-15 06:02:57 +0000 dev-libs/spdlog: fix fmt-10.x compatibility Closes: https://bugs.gentoo.org/906069 Signed-off-by: David Roman <davidroman96@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-libs/spdlog/files/spdlog-fmt-10.patch | 121 +++++++++++++++++++++ ...og-1.11.0-r2.ebuild => spdlog-1.11.0-r3.ebuild} | 5 +- 2 files changed, 125 insertions(+), 1 deletion(-)
