Errors in src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_types.h, dark_mode_image_classifier.h, dark_mode_image_classifier.cc Reproducible: Always Steps to Reproduce: emerge qtwebengine Actual Results: In file included from ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.h:12, from ./../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.cc:5, from gen/third_party/blink/renderer/platform/platform_jumbo_37.cc:5: ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_types.h:10:6: warning: elaborated-type-specifier for a scoped enum must not use the 'class' keyword 10 | enum class DarkModeResult : uint8_t { | ~~~~ ^~~~~ | ----- ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_types.h:10:27: error: found ':' in nested-name-specifier, expected '::' 10 | enum class DarkModeResult : uint8_t { | ^ | :: ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_types.h:10:12: error: 'DarkModeResult' has not been declared 10 | enum class DarkModeResult : uint8_t { | ^~~~~~~~~~~~~~ ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_types.h:10:37: error: expected unqualified-id before '{' token 10 | enum class DarkModeResult : uint8_t { | ^ ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.h:44:3: error: 'DarkModeResult' does not name a type 44 | DarkModeResult Classify(const SkPixmap& pixmap, const SkIRect& src); | ^~~~~~~~~~~~~~ ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.h:47:3: error: 'DarkModeResult' does not name a type 47 | DarkModeResult ClassifyWithFeatures(const Features& features); | ^~~~~~~~~~~~~~ ../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.h:48:3: error: 'DarkModeResult' does not name a type 48 | DarkModeResult ClassifyUsingDecisionTree(const Features& features); | ^~~~~~~~~~~~~~ ./../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.cc:43:1: error: 'DarkModeResult' does not name a type 43 | DarkModeResult DarkModeImageClassifier::Classify(const SkPixmap& pixmap, | ^~~~~~~~~~~~~~ ./../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.cc:230:1: error: 'DarkModeResult' does not name a type 230 | DarkModeResult DarkModeImageClassifier::ClassifyWithFeatures( | ^~~~~~~~~~~~~~ ./../../../../qtwebengine-5.15.9_p20230404/src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.cc:255:1: error: 'DarkModeResult' does not name a type 255 | DarkModeResult DarkModeImageClassifier::ClassifyUsingDecisionTree( | ^~~~~~~~~~~~~~ Portage 3.0.46 (python 3.10.11-final-0, default/linux/amd64/17.1/no-multilib, gcc-13, glibc-2.37-r2, 6.2.10-gentoo-dist x86_64) ================================================================= System uname: Linux-6.2.10-gentoo-dist-x86_64-AMD_Ryzen_9_7950X_16-Core_Processor-with-glibc2.37 KiB Mem: 65554164 total, 26893996 free KiB Swap: 268435452 total, 263628796 free Timestamp of repository gentoo: Fri, 14 Apr 2023 15:00:02 +0000 Head commit of repository gentoo: 262dc0e69c3b679ac088231d4b150641624a61c2 sh bash 5.2_p15-r2 ld GNU ld (Gentoo 2.40 p4) 2.40.0 app-misc/pax-utils: 1.3.7::gentoo app-shells/bash: 5.2_p15-r2::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.36.0-r2::gentoo dev-lang/python: 3.10.11::gentoo, 3.11.3::gentoo dev-lang/rust: 1.68.2::gentoo dev-util/cmake: 3.26.3::gentoo dev-util/meson: 1.0.1::gentoo sys-apps/baselayout: 2.13-r1::gentoo sys-apps/openrc: 0.46::gentoo sys-apps/sandbox: 2.30-r1::gentoo sys-devel/autoconf: 2.13-r8::gentoo, 2.71-r6::gentoo sys-devel/automake: 1.16.5-r1::gentoo sys-devel/binutils: 2.40-r4::gentoo sys-devel/binutils-config: 5.5::gentoo sys-devel/clang: 15.0.7-r1::gentoo, 16.0.1::gentoo sys-devel/gcc: 12.2.1_p20230304::gentoo, 13.0.1_pre20230409-r4::gentoo sys-devel/gcc-config: 2.10::gentoo sys-devel/libtool: 2.4.7-r1::gentoo sys-devel/lld: 15.0.7::gentoo, 16.0.1::gentoo sys-devel/llvm: 15.0.7::gentoo, 16.0.1::gentoo sys-devel/make: 4.4.1::gentoo sys-kernel/linux-headers: 6.2::gentoo (virtual/os-headers) sys-libs/glibc: 2.37-r2::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 volatile: False sync-rsync-extra-opts: sync-rsync-verify-max-age: 24 sync-rsync-verify-jobs: 16 sync-rsync-verify-metamanifest: yes ACCEPT_KEYWORDS="~*" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=znver4 -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=znver4 -O2 -pipe" DISTDIR="/var/cache/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://ftp.vectranet.pl/gentoo/ http://mirror.leaseweb.com/gentoo/ http://mirror.eu.oneandone.net/linux/distributions/gentoo/gentoo/ http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ http://mirror.netcologne.de/gentoo/ http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/ http://ftp.belnet.be/pub/rsync.gentoo.org/gentoo/ http://mirror.init7.net/gentoo/ http://tux.rainside.sk/gentoo/ http://gentoo.mirror.web4u.cz/" LANG="en_US" LC_ALL="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LEX="flex" MAKEOPTS="-j32" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" SHELL="/bin/bash" USE="X a52 aac acl alsa amd64 bzip2 cli connection-sharing context contrib contribdnn crypt cups dbus dcaenc dhcpcd dri dts emboss exif fam fbcon fdk ffmpeg fortran frei0r ftp gdbm geoclue geolocation gimp gps gui iconv icu iptables jpeg kde lame latex libass libglvnd libtirpc llvm lm-sensors lto mac minizip ncurses no-multilib nptl nvenc ogg opencl opengl openmp opus pam parallel-compiler pcre plasma pthread pulseaudio qml qt5 readline resolvconf sdl seccomp split-usr ssl syslog tbb test-rust text theora threads unicode v4l vaapi vector-icons vorbis vulkan x264 x265 xattr xml zlib" ABI_X86="64" ADA_TARGET="gnat_2021" AMDGPU_TARGETS="gfx1031" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="stage" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer nlpsolver" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby32" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev amd radeon radeonsi vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Please attach the full build.log - compressed if necessary.
Created attachment 860111 [details] first part of build log
Created attachment 860112 [details] second part of build log
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0d451f42732bc1c8685e56d64f13d73d2596d77 commit f0d451f42732bc1c8685e56d64f13d73d2596d77 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-04-15 01:05:53 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-04-15 02:10:44 +0000 dev-qt/qtwebengine: fix build w/ GCC 13 Closes: https://bugs.gentoo.org/904342 Signed-off-by: Sam James <sam@gentoo.org> .../files/qtwebengine-5.15.9_p20230404-gcc-13.patch | 14 ++++++++++++++ dev-qt/qtwebengine/qtwebengine-5.15.9_p20230404.ebuild | 5 ++++- 2 files changed, 18 insertions(+), 1 deletion(-)
cstdint must also be included in src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/dark_mode_image_classifier.h Only then the entire package compiles OK.
(In reply to he.ousia from comment #5) > cstdint must also be included in > src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/ > dark_mode_image_classifier.h > Only then the entire package compiles OK. That header doesn't use anything from <cstdint> AFAICT but dark_mode_image_classifier.cc does.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f46bba05316d58aa6071adfa714c976aa8405e3 commit 8f46bba05316d58aa6071adfa714c976aa8405e3 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-04-15 09:31:55 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-04-15 09:32:30 +0000 dev-qt/qtwebengine: fix build w/ gcc 13 Closes: https://bugs.gentoo.org/904342 Signed-off-by: Sam James <sam@gentoo.org> .../files/qtwebengine-5.15.9_p20230404-gcc-13.patch | 10 ++++++++++ 1 file changed, 10 insertions(+)
(In reply to Sam James from comment #6) > (In reply to he.ousia from comment #5) > > cstdint must also be included in > > src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/ > > dark_mode_image_classifier.h > > Only then the entire package compiles OK. > > That header doesn't use anything from <cstdint> AFAICT but > dark_mode_image_classifier.cc does. dark_mode_image_classifier.cc includes dark_mode_image_classifier.h
(In reply to he.ousia from comment #8) > (In reply to Sam James from comment #6) > > (In reply to he.ousia from comment #5) > > > cstdint must also be included in > > > src/3rdparty/chromium/third_party/blink/renderer/platform/graphics/ > > > dark_mode_image_classifier.h > > > Only then the entire package compiles OK. > > > > That header doesn't use anything from <cstdint> AFAICT but > > dark_mode_image_classifier.cc does. > > dark_mode_image_classifier.cc includes dark_mode_image_classifier.h yes, my point is that the thing which uses it is the thing which should include it. so I've put it in .cc instead.
With the new patch compiles and works very well (tested within Falkon, with several online benchmarking/stress testing tools).
