Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 904054 - xfce-base/xfdesktop-4.19.0[-wayland]: Cannot change background
Summary: xfce-base/xfdesktop-4.19.0[-wayland]: Cannot change background
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: XFCE Team
URL: https://gitlab.xfce.org/xfce/xfdeskto...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-04-08 22:38 UTC by Marcin Deranek
Modified: 2024-02-26 14:44 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Upstream patch (non-wayland.patch,1.12 KB, patch)
2023-04-08 22:40 UTC, Marcin Deranek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Deranek 2023-04-08 22:38:53 UTC
I am not able to change background using xfdesktop-settings in XFCE environment (xfdesktop-4.19.0)

Reproducible: Always

Steps to Reproduce:
1. Run xfdesktop-settings
2. Select Style to None
3. Select color Solid color
4. Click on the color, change color and click Select
Actual Results:  
Nothing changes

Expected Results:  
Background should change

See attached patch which resolves the problem (provided by upstream - see URL)
Comment 1 Marcin Deranek 2023-04-08 22:40:38 UTC
Created attachment 859700 [details, diff]
Upstream patch
Comment 2 Sebastian Pipping gentoo-dev 2023-04-17 13:09:18 UTC
Could you check if it's working with 4.19.1?
Comment 3 Marcin Deranek 2023-04-17 13:52:51 UTC
It's likely it is fixing the problem (patch is included in that release), but I will test it to be sure.
Comment 4 Marcin Deranek 2023-04-17 21:56:17 UTC
Problem was fixed yet icons disappeared as reported in BUG 904468
Comment 5 Marcin Deranek 2023-12-10 08:39:05 UTC
Considering that xfdesktop-4.19.1 has been masked due to missing icons issue and upstream does not look like it will fix it soon (the bug is 6 months old), can we have the upstream patch applied to 4.19.0 version then?
Comment 6 Ulrich Müller gentoo-dev 2024-02-26 11:06:41 UTC
I see the same problem with xfdesktop-4.19.0 while 4.18.1 and 4.19.1 work fine for me.

The patch attached to this bug fixes it too, so could this be applied please? If that's not an option, I suggest either package.masking 4.19.0 or unmasking 4.19.1.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-02-26 14:44:11 UTC
I'm sorry for the delay, I really hoped upstream would do something about 4.19.1.  I've just reproduced the issue, and confirmed that the backport fixes it.
Comment 8 Larry the Git Cow gentoo-dev 2024-02-26 14:44:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d50cc3158d17be8ef74e071313ee5e70b61fac06

commit d50cc3158d17be8ef74e071313ee5e70b61fac06
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-02-26 14:42:18 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-02-26 14:44:15 +0000

    xfce-base/xfdesktop: Backport a refresh patch for USE=-wayland
    
    Closes: https://bugs.gentoo.org/904054
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../files/xfdesktop-4.19.0-no-wayland.patch        | 37 ++++++++++++++++++++++
 ...op-4.19.0.ebuild => xfdesktop-4.19.0-r1.ebuild} |  8 ++++-
 2 files changed, 44 insertions(+), 1 deletion(-)