Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 898918 - x11-wm/fvwm-2.7.0: mouse-buttons patch does not apply and can be removed
Summary: x11-wm/fvwm-2.7.0: mouse-buttons patch does not apply and can be removed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
: 934492 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-02 14:04 UTC by Gianni Ceccarelli
Modified: 2024-08-15 19:09 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gianni Ceccarelli 2023-03-02 14:04:22 UTC
when building x11-wm/fvwm-2.7.0 with `-vanilla`, the "mouse-buttons" patch doesn't apply

the "mouse-buttons" patch is no longer necessary, as it has been applied upstream

while I was there, I've re-generated the "translucent menus" patch so it applies cleanly without offsets or fuzz.

you can see the new patches in my overlay https://www.thenautilus.net/cgit/gentoo-overlay/tree/x11-wm/fvwm
Comment 1 Anthony Brown 2024-08-11 16:43:20 UTC
=x11-wm/fvwm-2.7.0-r4 
=x11-wm/2.7.0-r1 Enter these into /etc/portage/package.mask/unstable
and try installing x11-wm/fvwm and it should install fine
Comment 2 Gianni Ceccarelli 2024-08-13 14:36:25 UTC
(In reply to Anthony Brown from comment #1)
> =x11-wm/fvwm-2.7.0-r4 
> =x11-wm/2.7.0-r1 Enter these into /etc/portage/package.mask/unstable
> and try installing x11-wm/fvwm and it should install fine

if I mask -r1 and -r4, portage tries to install `x11-wm/fvwm-2.7.0`, and fails immediately because that ebuild only supports python 3.10 and 3.11, not 3.12

there is no ebuild newer than -r4, so I'm not sure what you expected to happen…

what am I missing?
Comment 3 Anthony Brown 2024-08-14 00:03:26 UTC
i'll just nail on home with that ok have you ever heard of crux ? what i appended there that little note k says itll default and switch back to the latter version so it's skipping the 2 builds that don't build and the window manager actually works:)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-08-14 00:06:05 UTC
Anyway, I'll pull in the new patches.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-08-15 19:05:11 UTC
*** Bug 934492 has been marked as a duplicate of this bug. ***
Comment 6 Larry the Git Cow gentoo-dev 2024-08-15 19:07:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7ff4695abec63c8ef91b29d533ec89c80636190

commit a7ff4695abec63c8ef91b29d533ec89c80636190
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-08-15 19:04:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-15 19:07:03 +0000

    x11-wm/fvwm: fix patches
    
    * Use rebased ar, translucent-menus patches from bug #898918, thanks
      to Gianni Ceccarelli <dakkar@thenautilus.net>
    
    * Filter LTO for bug #864957 (fvwm 2.x is EOL) so unlikely to be fixed
      upstream. If 3.x gets fixed (bug #864959), we can always look at
      backporting it.
    
    Bug: https://bugs.gentoo.org/864959
    Closes: https://bugs.gentoo.org/864957
    Closes: https://bugs.gentoo.org/898918
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-wm/fvwm/files/fvwm-2.7.0-ar.patch              |  41 ++
 .../fvwm/files/fvwm-2.7.0-translucent-menus.diff   | 507 +++++++++++++++++++++
 x11-wm/fvwm/fvwm-2.7.0-r5.ebuild                   | 172 +++++++
 3 files changed, 720 insertions(+)
Comment 7 Larry the Git Cow gentoo-dev 2024-08-15 19:09:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3f2faab76f9991d0b7ea3c1aecb2a4a4d884484

commit e3f2faab76f9991d0b7ea3c1aecb2a4a4d884484
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-08-15 19:08:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-15 19:08:42 +0000

    x11-wm/fvwm: stabilize 2.7.0-r5 for amd64, ppc, x86
    
    Bug: https://bugs.gentoo.org/898918
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-wm/fvwm/fvwm-2.7.0-r5.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)