https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: x11-wm/fvwm-2.6.9-r1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 799355 [details] build.log build log and emerge --info
lto_tinderbox has reproduced this issue with version 2.7.0-r3 - Updating summary.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7ff4695abec63c8ef91b29d533ec89c80636190 commit a7ff4695abec63c8ef91b29d533ec89c80636190 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-08-15 19:04:41 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-08-15 19:07:03 +0000 x11-wm/fvwm: fix patches * Use rebased ar, translucent-menus patches from bug #898918, thanks to Gianni Ceccarelli <dakkar@thenautilus.net> * Filter LTO for bug #864957 (fvwm 2.x is EOL) so unlikely to be fixed upstream. If 3.x gets fixed (bug #864959), we can always look at backporting it. Bug: https://bugs.gentoo.org/864959 Closes: https://bugs.gentoo.org/864957 Closes: https://bugs.gentoo.org/898918 Signed-off-by: Sam James <sam@gentoo.org> x11-wm/fvwm/files/fvwm-2.7.0-ar.patch | 41 ++ .../fvwm/files/fvwm-2.7.0-translucent-menus.diff | 507 +++++++++++++++++++++ x11-wm/fvwm/fvwm-2.7.0-r5.ebuild | 172 +++++++ 3 files changed, 720 insertions(+)