Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 892341 - net-fs/samba-4.16.7-r3 installs into paths that should be created at runtime and installs files into unexpected paths (/run)
Summary: net-fs/samba-4.16.7-r3 installs into paths that should be created at runtime ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
: 892343 (view as bug list)
Depends on:
Blocks: runtime-paths
  Show dependency tree
 
Reported: 2023-01-28 07:11 UTC by Agostino Sarubbo
Modified: 2023-01-28 19:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,135.41 KB, application/x-xz)
2023-01-28 07:11 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-01-28 07:11:06 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-fs/samba-4.16.7-r3 installs into paths that should be created at runtime.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-01-28 07:11:09 UTC
Created attachment 849321 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-28 07:14:21 UTC
*** Bug 892343 has been marked as a duplicate of this bug. ***
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-28 07:15:14 UTC
>>> Completed installing net-fs/samba-4.16.7-r3 into /var/tmp/portage/net-fs/samba-4.16.7-r3/image

 * Final size of build directory: 564500 KiB (551.2 MiB)
 * Final size of installed tree:   37228 KiB ( 36.3 MiB)

 * QA Notice: The ebuild is installing to one or more unexpected paths:
 * 
 *   /run
 * 
 * Please fix the ebuild to use correct FHS/Gentoo policy paths.
 * QA Notice: This ebuild installs into paths that should be created at runtime.
 *  To fix, simply do not install into these directories.  Instead, your package
 *  should create dirs on the fly at runtime as needed via init scripts/etc...
 * 
 *   var/cache
 *   var/cache/samba  var/lock
 *   var/lock/samba  var/run
 *   var/run/samba  run
 *   run/samba
 * One or more empty directories installed to /var:
 * 
 *   /var/cache
 *   /var/cache/samba
 *   /var/lib
 *   /var/lib/samba
 *   /var/lib/samba/bind-dns
 *   /var/lib/samba/private
 *   /var/lock
 *   /var/lock/samba
 *   /var/log
 *   /var/log/samba
 *   /var/run
 *   /var/run/samba
 * 
 * If those directories need to be preserved, please make sure to create
 * or mark them for keeping using 'keepdir'. Portage for >= EAPI 8 ebuilds
 * will strip empty directories from installation image.

But the keepdirs aren't in the ebuild, so is the build system doing this?
Comment 4 Mike Gilbert gentoo-dev 2023-01-28 17:46:13 UTC
Yuck. Looking into it.
Comment 5 Larry the Git Cow gentoo-dev 2023-01-28 19:19:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4851df917d9c42839a315760f35a79dbd000e185

commit 4851df917d9c42839a315760f35a79dbd000e185
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-01-28 19:15:23 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-01-28 19:19:45 +0000

    net-fs/samba: remove empty dirs in /run and /var
    
    Closes: https://bugs.gentoo.org/892341
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-fs/samba/{samba-4.15.12-r3.ebuild => samba-4.15.12-r4.ebuild} | 3 +++
 net-fs/samba/{samba-4.16.7-r3.ebuild => samba-4.16.7-r4.ebuild}   | 3 +++
 2 files changed, 6 insertions(+)