Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878899 - media-video/handbrake-1.6.1 fails to compile (lto): error: type of 'combo_search_key_press_cb' does not match original declaration [-Werror=lto-type-mismatch]
Summary: media-video/handbrake-1.6.1 fails to compile (lto): error: type of 'combo_sea...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 917591
Blocks: lto
  Show dependency tree
 
Reported: 2022-10-31 17:21 UTC by Kostadin Shishmanov
Modified: 2024-12-22 06:21 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
emerge --info (emerge-info.txt,7.44 KB, text/plain)
2022-10-31 17:21 UTC, Kostadin Shishmanov 		Details
build.log (build.log,117.21 KB, text/x-log)
2022-10-31 17:21 UTC, Kostadin Shishmanov 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kostadin Shishmanov 2022-10-31 17:21:03 UTC 
Created attachment 826245 [details]
emerge --info

media-video/handbrake-1.5.1 fails to compile with CFLAGS=-flto=auto -Werror=lto-type-mismatch -Werror=odr -Werror=strict-aliasing



/var/tmp/portage/media-video/handbrake-1.5.1/work/HandBrake-1.5.1/build/../gtk/src/main.c:326:29: error: type of 'presets_list_selection_changed_cb' does not match original declaration [-Werror=lto-type-mismatch]
  326 | extern G_MODULE_EXPORT void presets_list_selection_changed_cb(void);
      |                             ^
/var/tmp/portage/media-video/handbrake-1.5.1/work/HandBrake-1.5.1/build/../gtk/src/presets.c:2953:1: note: type mismatch in parameter 1
 2953 | presets_list_selection_changed_cb(GtkTreeSelection *selection, signal_user_data_t *ud)
      | ^
/var/tmp/portage/media-video/handbrake-1.5.1/work/HandBrake-1.5.1/build/../gtk/src/presets.c:2953:1: note: 'presets_list_selection_changed_cb' was previously declared here
/var/tmp/portage/media-video/handbrake-1.5.1/work/HandBrake-1.5.1/build/../gtk/src/main.c:330:13: error: type of 'presets_row_expanded_cb' does not match original declaration [-Werror=lto-type-mismatch]
  330 | extern void presets_row_expanded_cb(void);
      |             ^
Comment 1 Kostadin Shishmanov 2022-10-31 17:21:22 UTC 
Created attachment 826247 [details]
build.log
Comment 2 Agostino Sarubbo gentoo-dev 2024-03-16 07:54:07 UTC 
lto_tinderbox has reproduced this issue with version 1.6.1 - Updating summary.
Comment 3 Eli Schwartz gentoo-dev 2024-03-31 17:48:10 UTC 
https://github.com/HandBrake/HandBrake/commit/ba2bf47c2862accbd1f005404626b16b5773c615

May or may not fix all the issues. Needs a version bump to check, see bug 917591
Comment 4 Larry the Git Cow gentoo-dev 2024-12-22 06:21:41 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77da9af0ca5db4278b6185be5adee99d016e5bec

commit 77da9af0ca5db4278b6185be5adee99d016e5bec
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2024-12-16 06:11:16 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-22 06:20:27 +0000

    media-video/handbrake: filter lto and disable build system hardening
    
    * Filter lto due to rampant lto-type-mismatches and ODR violations.
    * Disable hardening in build system fixing bug #890279.
    
    Closes: https://bugs.gentoo.org/878899
    Closes: https://bugs.gentoo.org/890279
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-video/handbrake/handbrake-1.6.1.ebuild | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)