Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890279 - media-video/handbrake-1.6.1 redefines _FORTIFY_SOURCE (HARDENED-SYSTEM)
Summary: media-video/handbrake-1.6.1 redefines _FORTIFY_SOURCE (HARDENED-SYSTEM)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 847148
  Show dependency tree
 
Reported: 2023-01-09 08:58 UTC by genBTC
Modified: 2024-12-22 06:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
handbrake build.log (handbrake,37.24 KB, application/octet-stream)
2023-01-09 09:00 UTC, genBTC
Details

Note You need to log in before you can comment on or make changes to this bug.
Description genBTC 2023-01-09 08:58:58 UTC
When using gentoo-hardened with the new  fortify-source-3.patch  built into Gcc-12.2.1_p20221231 ,
handbrake package results in a warning about a definition redefined collision.

<command-line>: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition

Meaning the package has _F_S=2 hardcoded in its build script:
  @ {S}/make/include/gcc.defs
and that flag should be stripped so _F_S=3 can take effect without conflict.

Reproducible: Always
Comment 1 genBTC 2023-01-09 09:00:53 UTC
Created attachment 848009 [details]
handbrake build.log

warning: "_FORTIFY_SOURCE" redefined
Comment 2 Agostino Sarubbo gentoo-dev 2023-02-20 07:59:05 UTC
hardened_tinderbox has reproduced this issue with version 1.5.1 - Updating summary.
Comment 3 Agostino Sarubbo gentoo-dev 2023-06-02 08:59:46 UTC
tinderbox_musl has reproduced this issue with version 1.5.1-r1 - Updating summary.
Comment 4 Agostino Sarubbo gentoo-dev 2024-02-12 08:24:02 UTC
tinderbox_musl has reproduced this issue with version 1.6.1 - Updating summary.
Comment 5 Larry the Git Cow gentoo-dev 2024-12-22 06:21:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77da9af0ca5db4278b6185be5adee99d016e5bec

commit 77da9af0ca5db4278b6185be5adee99d016e5bec
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2024-12-16 06:11:16 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-22 06:20:27 +0000

    media-video/handbrake: filter lto and disable build system hardening
    
    * Filter lto due to rampant lto-type-mismatches and ODR violations.
    * Disable hardening in build system fixing bug #890279.
    
    Closes: https://bugs.gentoo.org/878899
    Closes: https://bugs.gentoo.org/890279
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-video/handbrake/handbrake-1.6.1.ebuild | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)