https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: app-cdr/cdrdao-1.2.4-r1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Created attachment 787562 [details] build.log build log and emerge --info
Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eaf21fde96b4a358f23e443dfe7eb05c88314873 commit eaf21fde96b4a358f23e443dfe7eb05c88314873 Author: Martin Dummer <martin.dummer@gmx.net> AuthorDate: 2022-12-10 23:02:01 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-01-12 13:05:46 +0000 app-cdr/cdrdao: does not build with CFLAGS=-lto - change ebuild to filter -lto - according to https://sourceforge.net/p/cdrdao/news/ upstream has changed from Sourceforge to Github - remove dependency on gnome-base/gconf (is not necessary for cmdline binaries) Closes: https://bugs.gentoo.org/854219 Closes: https://bugs.gentoo.org/867235 Signed-off-by: Martin Dummer <martin.dummer@gmx.net> Closes: https://github.com/gentoo/gentoo/pull/28633 Signed-off-by: Joonas Niilola <juippis@gentoo.org> app-cdr/cdrdao/Manifest | 1 + app-cdr/cdrdao/cdrdao-1.2.4-r2.ebuild | 57 +++ .../cdrdao/files/cdrdao-1.2.4-ax_pthread2.patch | 389 +++++++++++++++++++++ app-cdr/cdrdao/metadata.xml | 1 - 4 files changed, 447 insertions(+), 1 deletion(-)
