Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 867235 - app-cdr/cdrdao: Remove dependency on gnome-base/gconf
Summary: app-cdr/cdrdao: Remove dependency on gnome-base/gconf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Martin Dummer
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: gconf-removal
  Show dependency tree
 
Reported: 2022-08-29 00:05 UTC by Stefan Ott
Modified: 2023-01-12 13:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Ott 2022-08-29 00:05:17 UTC
cdrdao has a non-optional dependency on gconf but works just fine if gconf is not installed.

Please consider dropping the dependency or adding a USE flag for it.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-29 20:44:45 UTC
commit 87a6ffded9cb5644aeb3703c3bcbfb2456322c0a
Author: Martin Dummer <martin.dummer@gmx.net>
Date:   Wed Jan 12 21:48:31 2022 +0100

    app-cdr/cdrdao: new EAPI, new maintainer

    add dependency gnome-base/gconf
    drop keyword hppa due to gnome-base/gconf
    drop support for _rc ebuild

    Closes: https://bugs.gentoo.org/745351
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
    Closes: https://github.com/gentoo/gentoo/pull/23763
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Comment 2 Stefan Ott 2022-08-29 21:47:10 UTC
Sorry but that was the wrong way around - the package does *not* need gconf, it works fine if there is no gconf on the system. It would be great if the dependency on gconf could be made optional through a USE flag.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-29 21:47:55 UTC
(In reply to Stefan Ott from comment #2)
> Sorry but that was the wrong way around - the package does *not* need gconf,
> it works fine if there is no gconf on the system. It would be great if the
> dependency on gconf could be made optional through a USE flag.

No, I know. I'm quoting the commit which added it.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-29 21:50:29 UTC
(In reply to Sam James from comment #3)
> (In reply to Stefan Ott from comment #2)
> > Sorry but that was the wrong way around - the package does *not* need gconf,
> > it works fine if there is no gconf on the system. It would be great if the
> > dependency on gconf could be made optional through a USE flag.
> 
> No, I know. I'm quoting the commit which added it.

I don't see anything in the source or build system which lets you properly disable it, so someone would need to create a patch if they're so motivated to allow disabling it properly.

The dependency was originally added for bug 745351 because the build system would try call it.

From the looks of it, it does genuinely try to use it for settings at least.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-29 21:52:38 UTC
sadly, even the dev branch on gh (where it moved to) has gconf support in it for preferences: https://github.com/cdrdao/cdrdao/tree/dev.
Comment 6 Larry the Git Cow gentoo-dev 2023-01-12 13:08:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eaf21fde96b4a358f23e443dfe7eb05c88314873

commit eaf21fde96b4a358f23e443dfe7eb05c88314873
Author:     Martin Dummer <martin.dummer@gmx.net>
AuthorDate: 2022-12-10 23:02:01 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-01-12 13:05:46 +0000

    app-cdr/cdrdao: does not build with CFLAGS=-lto
    
    - change ebuild to filter -lto
    - according to https://sourceforge.net/p/cdrdao/news/ upstream has changed from Sourceforge to Github
    - remove dependency on gnome-base/gconf (is not necessary for cmdline
      binaries)
    
    Closes: https://bugs.gentoo.org/854219
    Closes: https://bugs.gentoo.org/867235
    Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
    Closes: https://github.com/gentoo/gentoo/pull/28633
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-cdr/cdrdao/Manifest                            |   1 +
 app-cdr/cdrdao/cdrdao-1.2.4-r2.ebuild              |  57 +++
 .../cdrdao/files/cdrdao-1.2.4-ax_pthread2.patch    | 389 +++++++++++++++++++++
 app-cdr/cdrdao/metadata.xml                        |   1 -
 4 files changed, 447 insertions(+), 1 deletion(-)