834421 – net-im/telegram-desktop-3.5.2-r1 with ffmpeg-5.0: SourceFiles/ffmpeg/ffmpeg_utility.cpp:160:17: error: invalid conversion from ‘const AVCodec*’ to ‘AVCodec*’ [-fpermissive]

Bug 834421 - net-im/telegram-desktop-3.5.2-r1 with ffmpeg-5.0: SourceFiles/ffmpeg/ffmpeg_utility.cpp:160:17: error: invalid conversion from ‘const AVCodec*’ to ‘AVCodec*’ [-fpermissive]

Summary: net-im/telegram-desktop-3.5.2-r1 with ffmpeg-5.0: SourceFiles/ffmpeg/ffmpeg_u...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Esteve Varela Colominas

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	ffmpeg-5.0
	Show dependency tree

Reported:	2022-02-28 21:36 UTC by Kobboi
Modified:	2022-05-02 19:17 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
build.log.gz (build.log.gz,7.71 KB, application/gzip) 2022-02-28 21:36 UTC, Kobboi	Details
emerge-info.txt (emerge-info.txt,8.00 KB, text/plain) 2022-02-28 21:36 UTC, Kobboi	Details
ffmpeg-v5.0.patch (FFmepeg-v5.0.patch,4.69 KB, patch) 2022-04-12 06:33 UTC, Joe Kappus	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kobboi 2022-02-28 21:36:26 UTC

[33/1031] /usr/bin/x86_64-pc-linux-gnu-g++ -DCRL_USE_COMMON_QUEUE -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_USE_PACKAGED -DQT_CORE_LIB -DQT_GUI_LIB -DQT_IMPLICIT_QCHAR_CONSTRUCTION -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_SVG_LIB -DQT_WAYLANDCLIENT_LIB -DQT_WIDGETS_LIB -DQT_XKBCOMMON_SUPPORT_LIB -D
_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS -I/var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/SourceFiles -I/var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/lib_base -I/var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/lib_rpl -I/var/tmp/portage/n
et-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/lib_crl -isystem /usr/include/qt5/QtCore/5.15.2 -isystem /usr/include/qt5/QtCore/5.15.2/QtCore -isystem /usr/include/qt5/QtGui/5.15.2 -isystem /usr/include/qt5/QtGui/5.15.2/QtGui -isystem /usr/include/qt5/QtWidgets/5.15.2 -isystem /usr/include/qt5/QtWidgets/5.15.2/QtWidgets -isyst
em /usr/include/qt5/QtXkbCommonSupport/5.15.2 -isystem /usr/include/qt5/QtXkbCommonSupport/5.15.2/QtXkbCommonSupport -isystem /usr/include/qt5/QtWaylandClient/5.15.2 -isystem /usr/include/qt5/QtWaylandClient/5.15.2/QtWaylandClient -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/i
nclude/qt5/QtGui -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtSvg -isystem /usr/include/qt5/QtXkbCommonSupport -isystem /usr/include/qt5/QtWaylandClient -isystem /var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/ThirdParty/expected/include -isystem /usr/incl
ude/giomm-2.4 -isystem /usr/lib64/giomm-2.4/include -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/sysprof-4 -isystem /usr/lib64/libffi/include -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glibmm-2.4 -isystem /usr/lib64/glibmm-2.4/include -isystem /usr/include/sigc++-
2.0 -isystem /usr/lib64/sigc++-2.0/include -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/KF5/KWayland -isystem /usr/include/KF5/KWayland/Client -isystem /usr/include/KF5  -O2 -march=znver3 -pipe -g -ggdb3 -fstack-protector-all -fstack-clash-protection -fPIC -fno-strict-aliasing -pipe -Wall -W -Wno-unused-parameter -Wno-switch -Wno-mis
sing-field-initializers -Wno-sign-compare -Wno-deprecated -Wno-maybe-uninitialized -pthread -std=gnu++20 -MD -MT Telegram/CMakeFiles/lib_ffmpeg.dir/SourceFiles/ffmpeg/ffmpeg_utility.cpp.o -MF Telegram/CMakeFiles/lib_ffmpeg.dir/SourceFiles/ffmpeg/ffmpeg_utility.cpp.o.d -o Telegram/CMakeFiles/lib_ffmpeg.dir/SourceFiles/ffmpeg/ffmpeg_utility.cpp.o 
-c /var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/SourceFiles/ffmpeg/ffmpeg_utility.cpp
FAILED: Telegram/CMakeFiles/lib_ffmpeg.dir/SourceFiles/ffmpeg/ffmpeg_utility.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DCRL_USE_COMMON_QUEUE -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_USE_PACKAGED -DQT_CORE_LIB -DQT_GUI_LIB -DQT_IMPLICIT_QCHAR_CONSTRUCTION -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_SVG_LIB -DQT_WAYLANDCLIENT_LIB -DQT_WIDGETS_LIB -DQT_XKBCOMMON_SUPPORT_LIB -D_FORTIFY_S
OURCE=2 -D_GLIBCXX_ASSERTIONS -I/var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/SourceFiles -I/var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/lib_base -I/var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/lib_rpl -I/var/tmp/portage/net-im/tele
gram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/lib_crl -isystem /usr/include/qt5/QtCore/5.15.2 -isystem /usr/include/qt5/QtCore/5.15.2/QtCore -isystem /usr/include/qt5/QtGui/5.15.2 -isystem /usr/include/qt5/QtGui/5.15.2/QtGui -isystem /usr/include/qt5/QtWidgets/5.15.2 -isystem /usr/include/qt5/QtWidgets/5.15.2/QtWidgets -isystem /usr/in
clude/qt5/QtXkbCommonSupport/5.15.2 -isystem /usr/include/qt5/QtXkbCommonSupport/5.15.2/QtXkbCommonSupport -isystem /usr/include/qt5/QtWaylandClient/5.15.2 -isystem /usr/include/qt5/QtWaylandClient/5.15.2/QtWaylandClient -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5
/QtGui -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtSvg -isystem /usr/include/qt5/QtXkbCommonSupport -isystem /usr/include/qt5/QtWaylandClient -isystem /var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/ThirdParty/expected/include -isystem /usr/include/giomm-
2.4 -isystem /usr/lib64/giomm-2.4/include -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/sysprof-4 -isystem /usr/lib64/libffi/include -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glibmm-2.4 -isystem /usr/lib64/glibmm-2.4/include -isystem /usr/include/sigc++-2.0 -isyst
em /usr/lib64/sigc++-2.0/include -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/KF5/KWayland -isystem /usr/include/KF5/KWayland/Client -isystem /usr/include/KF5  -O2 -march=znver3 -pipe -g -ggdb3 -fstack-protector-all -fstack-clash-protection -fPIC -fno-strict-aliasing -pipe -Wall -W -Wno-unused-parameter -Wno-switch -Wno-missing-field
-initializers -Wno-sign-compare -Wno-deprecated -Wno-maybe-uninitialized -pthread -std=gnu++20 -MD -MT Telegram/CMakeFiles/lib_ffmpeg.dir/SourceFiles/ffmpeg/ffmpeg_utility.cpp.o -MF Telegram/CMakeFiles/lib_ffmpeg.dir/SourceFiles/ffmpeg/ffmpeg_utility.cpp.o.d -o Telegram/CMakeFiles/lib_ffmpeg.dir/SourceFiles/ffmpeg/ffmpeg_utility.cpp.o -c /var/tm
p/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/SourceFiles/ffmpeg/ffmpeg_utility.cpp
/var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/SourceFiles/ffmpeg/ffmpeg_utility.cpp: In function ‘AVCodec* FFmpeg::FindDecoder(gsl::not_null<AVCodecContext*>)’:
/var/tmp/portage/net-im/telegram-desktop-3.5.2-r1/work/tdesktop-3.5.2-full/Telegram/SourceFiles/ffmpeg/ffmpeg_utility.cpp:160:17: error: invalid conversion from ‘const AVCodec*’ to ‘AVCodec*’ [-fpermissive]
  159 |         return (context->codec_id == AV_CODEC_ID_VP9)
      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  160 |                 ? avcodec_find_decoder_by_name("libvpx-vp9")
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 |
      |                 const AVCodec*
  161 |                 : avcodec_find_decoder(context->codec_id);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Reproducible: Always

Comment 1 Kobboi 2022-02-28 21:36:43 UTC

Created attachment 766097 [details]
build.log.gz

Comment 2 Kobboi 2022-02-28 21:36:45 UTC

Created attachment 766098 [details]
emerge-info.txt

Comment 3 Kobboi 2022-02-28 21:36:54 UTC

Compiles fine with ffmpeg-4.4.1

Comment 4 Esteve Varela Colominas 2022-03-01 08:51:07 UTC

https://i.imgur.com/dPSC4y2.jpg

(Don't mind me if I take a bit to get to this, I'm a bit busy)

Comment 5 Esteve Varela Colominas 2022-04-11 21:38:29 UTC

I forgot to update or reference this bug, but this was fixed with 3.6.0:
https://github.com/gentoo/gentoo/commit/48b4072b8670dde327bc2c4fd813c6cf80c6968b

Now I'm just waiting for the natural course of deprecation of older versions to take care of the rest.

Comment 6 Joe Kappus 2022-04-12 06:33:16 UTC

Created attachment 770201 [details, diff]
ffmpeg-v5.0.patch

I didn't misspell the patch, Debian did. If you want to push an -r2 of this version that builds, this should get you there.

Comment 7 Esteve Varela Colominas 2022-04-12 07:15:45 UTC

I'd rather stabilize 3.6.1, it's nearly a month old by now.
Thanks, anyway!

Comment 8 Esteve Varela Colominas 2022-05-02 19:17:18 UTC

Stabilized in:
https://github.com/gentoo/gentoo/commit/56598678e2518042a5c832612a01ba376f5eadd6