834378 – games-simulation/corsix-th-0.65.1 with ffmpeg-5.0: th_movie.cpp:438:52: error: invalid conversion from ‘AVCodec**’ to ‘const AVCodec**’ [-fpermissive]

Bug 834378 - games-simulation/corsix-th-0.65.1 with ffmpeg-5.0: th_movie.cpp:438:52: error: invalid conversion from ‘AVCodec**’ to ‘const AVCodec**’ [-fpermissive]

Summary: games-simulation/corsix-th-0.65.1 with ffmpeg-5.0: th_movie.cpp:438:52: error...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	ffmpeg-5.0
	Show dependency tree

Reported:	2022-02-28 18:50 UTC by Kobboi
Modified:	2022-07-26 05:20 UTC (History)
CC List:	1 user (show)

See Also:	https://github.com/CorsixTH/CorsixTH/issues/2109 https://github.com/CorsixTH/CorsixTH/issues/1890
Package list:
Runtime testing required:	---

Attachments
build.log.gz (build.log.gz,3.47 KB, application/gzip) 2022-02-28 18:50 UTC, Kobboi	Details
emerge-info.txt (emerge-info.txt,8.00 KB, text/plain) 2022-02-28 18:50 UTC, Kobboi	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kobboi 2022-02-28 18:50:24 UTC

[20/35] /usr/bin/x86_64-pc-linux-gnu-g++  -I/var/tmp/portage/games-simulation/corsix-th-0.65.1/work/corsix-th-0.65.1_build/CorsixTH/Src -I/usr/include/SDL2 -I/usr/include/lua5.1 -I/usr/include/freetype2  -O2 -march=znver3 -pipe -g -ggdb3 -std=c++14 -MD -MT CorsixTH/CMakeFiles/CorsixTH_lib.dir/Src/th_movie.cpp.o -MF CorsixTH/CMakeFiles/CorsixTH_lib.dir/Src/th_movie.cpp.o.d -o CorsixTH/CMakeFiles/CorsixTH_lib.dir/Src/th_movie.cpp.o -c /var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.cpp
FAILED: CorsixTH/CMakeFiles/CorsixTH_lib.dir/Src/th_movie.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++  -I/var/tmp/portage/games-simulation/corsix-th-0.65.1/work/corsix-th-0.65.1_build/CorsixTH/Src -I/usr/include/SDL2 -I/usr/include/lua5.1 -I/usr/include/freetype2  -O2 -march=znver3 -pipe -g -ggdb3 -std=c++14 -MD -MT CorsixTH/CMakeFiles/CorsixTH_lib.dir/Src/th_movie.cpp.o -MF CorsixTH/CMakeFiles/CorsixTH_lib.dir/Src/th_movie.cpp.o.d -o CorsixTH/CMakeFiles/CorsixTH_lib.dir/Src/th_movie.cpp.o -c /var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.cpp
/var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.cpp: In member function ‘bool movie_player::load(const char*)’:
/var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.cpp:438:52: error: invalid conversion from ‘AVCodec**’ to ‘const AVCodec**’ [-fpermissive]
  438 |                                            -1, -1, &m_pVideoCodec, 0);
      |                                                    ^~~~~~~~~~~~~~
      |                                                    |
      |                                                    AVCodec**
In file included from /var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.h:46,
                 from /var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.cpp:23:
/usr/include/libavformat/avformat.h:2161:41: note:   initializing argument 5 of ‘int av_find_best_stream(AVFormatContext*, AVMediaType, int, int, const AVCodec**, int)’
 2161 |                         const AVCodec **decoder_ret,
      |                         ~~~~~~~~~~~~~~~~^~~~~~~~~~~
/var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.cpp:449:52: error: invalid conversion from ‘AVCodec**’ to ‘const AVCodec**’ [-fpermissive]
  449 |                                            -1, -1, &m_pAudioCodec, 0);
      |                                                    ^~~~~~~~~~~~~~
      |                                                    |
      |                                                    AVCodec**
In file included from /var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.h:46,
                 from /var/tmp/portage/games-simulation/corsix-th-0.65.1/work/CorsixTH-0.65.1/CorsixTH/Src/th_movie.cpp:23:
/usr/include/libavformat/avformat.h:2161:41: note:   initializing argument 5 of ‘int av_find_best_stream(AVFormatContext*, AVMediaType, int, int, const AVCodec**, int)’
 2161 |                         const AVCodec **decoder_ret,
      |                         ~~~~~~~~~~~~~~~~^~~~~~~~~~~


Reproducible: Always

Comment 1 Kobboi 2022-02-28 18:50:34 UTC

Created attachment 766019 [details]
build.log.gz

Comment 2 Kobboi 2022-02-28 18:50:35 UTC

Created attachment 766020 [details]
emerge-info.txt

Comment 3 Sam James archtester

2022-05-15 23:33:55 UTC

Patches:
https://github.com/CorsixTH/CorsixTH/commit/9a03f3a41f5c8bbde355c225644d7ed147ea696a
https://github.com/CorsixTH/CorsixTH/commit/47461689dfd80db9b6722b251cb98dc9000bcd68

Comment 4 Sam James archtester

2022-07-26 05:20:05 UTC

Fixed in 0.66.