Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 821721 - app-editors/vis: seems to need dev-lua/lpeg at runtime too
Summary: app-editors/vis: seems to need dev-lua/lpeg at runtime too
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Haelwenn (lanodan) Monnier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-04 21:18 UTC by Sam James
Modified: 2023-12-04 08:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-04 21:18:08 UTC
vis seems to use dev-lua/lpeg at runtime (not just for tests). Noticed when a user reported the issue in #gentoo (at runtime the program wouldn't allow using lpeg features like syntax highlighting(?)).

https://github.com/martanne/vis/search?q=lpeg seems consistent too.
Comment 1 Haelwenn (lanodan) Monnier 2021-11-16 23:36:38 UTC
Yes, vis uses (but doesn't requires) lpeg at runtime, which is advertised in the ebuild at install time via optfeature.

I originally put lpeg as dependency of the lua USE flag because it's a small dependency anyway but it got changed during review.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-25 06:16:53 UTC
(In reply to Haelwenn (lanodan) Monnier from comment #1)
> Yes, vis uses (but doesn't requires) lpeg at runtime, which is advertised in
> the ebuild at install time via optfeature.
> 
> I originally put lpeg as dependency of the lua USE flag because it's a small
> dependency anyway but it got changed during review.

I'm sorry, I hadn't noticed. For small dependencies, if it's a big quality of life improvement, I generally prefer to do the flag (if the main package doesn't take long to build either, e.g. pure Python/Lua/etc). Up to you though.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-11-27 20:17:17 UTC
It appears it is not a pure runtime use as a user mentions vis seems to look for lpeg in configure, plus you need aligned Lua versions anyway.
Comment 4 Haelwenn (lanodan) Monnier 2023-12-03 10:13:22 UTC
(In reply to Sam James from comment #3)
> It appears it is not a pure runtime use as a user mentions vis seems to look
> for lpeg in configure, plus you need aligned Lua versions anyway.

configure script only looks for presence of the *static-libs* version of lpeg so it can be built into vis (for static builds of vis).

Getting aligned lua versions seems appropriate though and lpeg's small so I sent https://github.com/gentoo/gentoo/pull/34104
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-04 08:36:36 UTC
(In reply to Haelwenn (lanodan) Monnier from comment #4)
> (In reply to Sam James from comment #3)
> > It appears it is not a pure runtime use as a user mentions vis seems to look
> > for lpeg in configure, plus you need aligned Lua versions anyway.
> 
> configure script only looks for presence of the *static-libs* version of
> lpeg so it can be built into vis (for static builds of vis).
> 
> Getting aligned lua versions seems appropriate though and lpeg's small so I
> sent https://github.com/gentoo/gentoo/pull/34104

Ah, thank you!
Comment 6 Larry the Git Cow gentoo-dev 2023-12-04 08:37:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0ecfd31e7add9fe2158f3d6ca21fa9f9485216d

commit f0ecfd31e7add9fe2158f3d6ca21fa9f9485216d
Author:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
AuthorDate: 2023-12-03 01:47:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-04 08:36:27 +0000

    app-editors/vis: move lpeg from optfeature to RDEPEND
    
    Also explicitly disables lpeg-static, which isn't supported in Gentoo as it
    would require both USE=static-libs in lpeg and addition of pkg-config files.
    
    Closes: https://bugs.gentoo.org/821721
    Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
    Closes: https://github.com/gentoo/gentoo/pull/34104
    Signed-off-by: Sam James <sam@gentoo.org>

 app-editors/vis/vis-0.8-r1.ebuild | 96 +++++++++++++++++++++++++++++++++++++++
 app-editors/vis/vis-9999.ebuild   | 12 +++--
 2 files changed, 104 insertions(+), 4 deletions(-)