vis seems to use dev-lua/lpeg at runtime (not just for tests). Noticed when a user reported the issue in #gentoo (at runtime the program wouldn't allow using lpeg features like syntax highlighting(?)). https://github.com/martanne/vis/search?q=lpeg seems consistent too.
Yes, vis uses (but doesn't requires) lpeg at runtime, which is advertised in the ebuild at install time via optfeature. I originally put lpeg as dependency of the lua USE flag because it's a small dependency anyway but it got changed during review.
(In reply to Haelwenn (lanodan) Monnier from comment #1) > Yes, vis uses (but doesn't requires) lpeg at runtime, which is advertised in > the ebuild at install time via optfeature. > > I originally put lpeg as dependency of the lua USE flag because it's a small > dependency anyway but it got changed during review. I'm sorry, I hadn't noticed. For small dependencies, if it's a big quality of life improvement, I generally prefer to do the flag (if the main package doesn't take long to build either, e.g. pure Python/Lua/etc). Up to you though.
It appears it is not a pure runtime use as a user mentions vis seems to look for lpeg in configure, plus you need aligned Lua versions anyway.
(In reply to Sam James from comment #3) > It appears it is not a pure runtime use as a user mentions vis seems to look > for lpeg in configure, plus you need aligned Lua versions anyway. configure script only looks for presence of the *static-libs* version of lpeg so it can be built into vis (for static builds of vis). Getting aligned lua versions seems appropriate though and lpeg's small so I sent https://github.com/gentoo/gentoo/pull/34104
(In reply to Haelwenn (lanodan) Monnier from comment #4) > (In reply to Sam James from comment #3) > > It appears it is not a pure runtime use as a user mentions vis seems to look > > for lpeg in configure, plus you need aligned Lua versions anyway. > > configure script only looks for presence of the *static-libs* version of > lpeg so it can be built into vis (for static builds of vis). > > Getting aligned lua versions seems appropriate though and lpeg's small so I > sent https://github.com/gentoo/gentoo/pull/34104 Ah, thank you!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0ecfd31e7add9fe2158f3d6ca21fa9f9485216d commit f0ecfd31e7add9fe2158f3d6ca21fa9f9485216d Author: Haelwenn (lanodan) Monnier <contact@hacktivis.me> AuthorDate: 2023-12-03 01:47:15 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-12-04 08:36:27 +0000 app-editors/vis: move lpeg from optfeature to RDEPEND Also explicitly disables lpeg-static, which isn't supported in Gentoo as it would require both USE=static-libs in lpeg and addition of pkg-config files. Closes: https://bugs.gentoo.org/821721 Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me> Closes: https://github.com/gentoo/gentoo/pull/34104 Signed-off-by: Sam James <sam@gentoo.org> app-editors/vis/vis-0.8-r1.ebuild | 96 +++++++++++++++++++++++++++++++++++++++ app-editors/vis/vis-9999.ebuild | 12 +++-- 2 files changed, 104 insertions(+), 4 deletions(-)
