Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 778218 - x11-themes/gtk-engines-ubuntulooks-0.9.12-r3 - ubuntulooks_draw.c:(.text+<snip>): undefined reference to sincos
Summary: x11-themes/gtk-engines-ubuntulooks-0.9.12-r3 - ubuntulooks_draw.c:(.text+<sni...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2021-03-25 17:43 UTC by Toralf Förster
Modified: 2021-04-30 16:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.45 KB, text/plain)
2021-03-25 17:43 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,321.43 KB, text/plain)
2021-03-25 17:43 UTC, Toralf Förster
Details
environment (environment,66.94 KB, text/plain)
2021-03-25 17:43 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,39.85 KB, application/x-bzip)
2021-03-25 17:43 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,7.06 KB, application/x-bzip)
2021-03-25 17:43 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,24.35 KB, application/x-bzip)
2021-03-25 17:43 UTC, Toralf Förster
Details
x11-themes:gtk-engines-ubuntulooks-0.9.12-r3:20210325-174019.log (x11-themes:gtk-engines-ubuntulooks-0.9.12-r3:20210325-174019.log,52.79 KB, text/plain)
2021-03-25 17:43 UTC, Toralf Förster
Details
Patch to fix the build. (gtk-engines-ubuntulooks-libm.patch,978 bytes, patch)
2021-03-31 14:04 UTC, orbea
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2021-03-25 17:43:23 UTC
rdlibtool: link: x86_64-pc-linux-gnu-gcc .libs/ubuntulooks_rc_style.o .libs/ubuntulooks_style.o .libs/ubuntulooks_theme_main.o .libs/support.o .libs/animation.o .libs/ubuntulooks_draw.o -O2 -pipe -march=native -fno-diagnostics-color -falign-functions=32:25:16 -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype -shared -fPIC -Wl,--no-undefined -o .libs/libubuntulooks.so
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: .libs/ubuntulooks_draw.o: in function `rotate_mirror_translate.constprop.0':
ubuntulooks_draw.c:(.text+0x9dc): undefined reference to `sincos'
collect2: error: ld returned 1 exit status
rdlibtool: exec error upon slbt_exec_link_create_library(), line 1446: (see child process error messages).
rdlibtool: < returned to > slbt_exec_link(), line 1868.

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma-20210316-100935

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10.2.0 *
clang version 11.1.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/11/bin
/usr/lib/llvm/11
11.1.0
Python 3.8.8
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby27 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.50.0 *
The following VMs are available for generation-2:
1)	IcedTea JDK 3.17.1 [icedtea-8]
2)	IcedTea JDK 3.16.0 [icedtea-bin-8]
3)	OpenJDK 8.282_p08 [openjdk-8]
*)	AdoptOpenJDK 8.282_p08 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-8 
  [2]   icedtea-bin-8 
  [3]   openjdk-8 
  [4]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Thu Mar 25 17:20:45 UTC 2021

emerge -qpvO x11-themes/gtk-engines-ubuntulooks
[ebuild  N    ] x11-themes/gtk-engines-ubuntulooks-0.9.12-r3
Comment 1 Toralf Förster gentoo-dev 2021-03-25 17:43:24 UTC
Created attachment 693570 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-03-25 17:43:26 UTC
Created attachment 693573 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2021-03-25 17:43:27 UTC
Created attachment 693576 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2021-03-25 17:43:28 UTC
Created attachment 693579 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2021-03-25 17:43:29 UTC
Created attachment 693582 [details]
logs.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2021-03-25 17:43:30 UTC
Created attachment 693585 [details]
temp.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2021-03-25 17:43:32 UTC
Created attachment 693588 [details]
x11-themes:gtk-engines-ubuntulooks-0.9.12-r3:20210325-174019.log
Comment 8 Ionen Wolkens gentoo-dev 2021-03-25 17:53:00 UTC
Looks like same problem gtk-engines had (bug #766680), I imagine there may be more of those then.
Comment 9 orbea 2021-03-25 18:16:01 UTC
> Looks like same problem gtk-engines had 

It might be the most common issue, GNU libtool just silently removes -no-undefined so developers never realize they have these undefined references unless they explicitly uses -Wl,--no-undefined (Or use slibtool).

Here is some really head scratching code from /usr/bin/libtool:

    case $host in
    *-*-cygwin* | *-*-mingw* | *-*-pw32* | *-*-os2* | *-cegcc*)
      # It is impossible to link a dll without this setting, and
      # we shouldn't force the makefile maintainer to figure out
      # what system we are compiling for in order to pass an extra
      # flag for every libtool invocation.
      # allow_undefined=no

      # FIXME: Unfortunately, there are problems with the above when trying
      # to make a dll that has undefined symbols, in which case not
      # even a static library is built.  For now, we need to specify
      # -no-undefined on the libtool link line when we can be certain
      # that all symbols are satisfied, otherwise we get a static library.
      allow_undefined=yes
      ;;
    *)
      allow_undefined=yes
      ;;
    esac

And:

      -no-undefined)
        allow_undefined=no
        continue
        ;;
Comment 10 orbea 2021-03-31 14:04:28 UTC
Created attachment 696522 [details, diff]
Patch to fix the build.

Same issue as the other gtk-engines-*, not sure upstream is active here.
Comment 11 Larry the Git Cow gentoo-dev 2021-04-30 16:16:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09d9c2e82538203f16df9622dcb2a754f16e44e3

commit 09d9c2e82538203f16df9622dcb2a754f16e44e3
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-04-30 14:35:33 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-04-30 16:16:43 +0000

    x11-themes/gtk-engines-ubuntulooks: Fix for slibtool
    
    Thanks-to: orbea <orbea@riseup.net>
    Closes: https://bugs.gentoo.org/778218
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../gtk-engines-ubuntulooks-0.9.12-libm.patch      | 31 ++++++++++++++++++++++
 .../gtk-engines-ubuntulooks-0.9.12-r3.ebuild       |  1 +
 2 files changed, 32 insertions(+)