Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 766680 - x11-themes/gtk-engines: Undefined references with sys-devel/slibtool
Summary: x11-themes/gtk-engines: Undefined references with sys-devel/slibtool
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2021-01-23 15:09 UTC by Joakim Tjernlund
Modified: 2021-03-25 17:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gtk-engines-2.20.2-slibtool.patch (gtk-engines-2.20.2-slibtool.patch,1.98 KB, patch)
2021-01-23 16:13 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff
gtk-engines-2.20.2-automake-1.14.patch (gtk-engines-2.20.2-automake-1.14.patch,2.06 KB, patch)
2021-01-23 16:15 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2021-01-23 15:09:05 UTC
/var/tmp/portage/x11-themes/gtk-engines-2.20.2-r100/work/gtk-engines-2.20.2/engines/hc/./src/hc_gtk2_support.c:472:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  472 |       id = (gint)g_object_steal_data (G_OBJECT(widget), "HC_MENU_SHELL_LEAVE_ID");
      |            ^
/var/tmp/portage/x11-themes/gtk-engines-2.20.2-r100/work/gtk-engines-2.20.2/engines/hc/./src/hc_gtk2_support.c:475:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  475 |       id = (gint)g_object_steal_data (G_OBJECT(widget), "HC_MENU_SHELL_DESTROY_ID");
      |            ^
/var/tmp/portage/x11-themes/gtk-engines-2.20.2-r100/work/gtk-engines-2.20.2/engines/hc/./src/hc_gtk2_support.c:478:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  478 |       id = (gint)g_object_steal_data (G_OBJECT(widget), "HC_MENU_SHELL_STYLE_SET_ID");
      |            ^
slibtool: link: ar crs .libs/libhcengine.a .libs/hc_gtk2_engine.o .libs/hc_gtk2_support.o .libs/hc-style.o
slibtool: link: x86_64-pc-linux-gnu-gcc .libs/hc_gtk2_engine.o .libs/hc_gtk2_support.o .libs/hc-style.o -Wl,--whole-archive ../../engines/support/.libs/libsupport.a -Wl,--no-whole-archive -O2 -pipe -Wno-error -fno-stack-check -Wno-deprecated-declarations -fdebug-prefix-map=..=/var/tmp/portage/x11-themes/gtk-engines-2.20.2-r100 -Wl,-O1 -Wl,--as-needed -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype -shared -fPIC -Wl,--no-undefined -o .libs/libhcengine.so
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: .libs/hc-style.o: in function `hc_draw_polygon':
hc-style.c:(.text+0x3dc0): undefined reference to `atan2'
collect2: error: ld returned 1 exit status
slibtool: exec error upon slbt_exec_link_create_library(), line 1446: (see child process error messages).
slibtool: < returned to > slbt_exec_link(), line 1836.
make[2]: *** [Makefile:370: libhcengine.la] Error 2
make[1]: *** [Makefile:294: all-recursive] Error 1
make: *** [Makefile:408: all-recursive] Error 1
 * ERROR: x11-themes/gtk-engines-2.20.2-r100::gentoo failed (compile phase):
 *   emake failed
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-23 16:13:37 UTC
Created attachment 684216 [details, diff]
gtk-engines-2.20.2-slibtool.patch

Possible fix... this patch requires eautoreconf to be called which would break the resulting test/Makefile:

  Makefile:911: *** unterminated variable reference.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-23 16:15:54 UTC
Created attachment 684219 [details, diff]
gtk-engines-2.20.2-automake-1.14.patch

Possible fix so eautoreconf won't create a broken test/Makefile. Patch blatantly stolen from Debian:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713353
Comment 3 Larry the Git Cow gentoo-dev 2021-01-24 11:14:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=882df26cfdfa74fc7d62e2a9e83b2543c47fdcf7

commit 882df26cfdfa74fc7d62e2a9e83b2543c47fdcf7
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-01-24 11:13:24 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-01-24 11:14:53 +0000

    x11-themes/gtk-engines: Fixed build with sys-devel/slibtool
    
    This also required to fix autoreconf to generate non-broken Makefiles
    which was done by taking a patch from Debian.
    This in turn enables us to fix configure.ac to search for our desired
    LUA implementation.
    
    Commit permission kindly granted by mattst88
    
    Closes: https://bugs.gentoo.org/766680
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../files/gtk-engines-2.20.2-automake-1.14.patch   | 49 ++++++++++++++++++++++
 .../files/gtk-engines-2.20.2-slibtool.patch        | 47 +++++++++++++++++++++
 .../gtk-engines/gtk-engines-2.20.2-r100.ebuild     | 10 +++--
 3 files changed, 102 insertions(+), 4 deletions(-)
Comment 4 Joakim Tjernlund 2021-01-24 11:32:15 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #2)
> Created attachment 684219 [details, diff] [details, diff]
> gtk-engines-2.20.2-automake-1.14.patch
> 
> Possible fix so eautoreconf won't create a broken test/Makefile. Patch
> blatantly stolen from Debian:
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=713353

Is this bug present in later automake as well ?
Comment 5 Joakim Tjernlund 2021-01-24 12:38:05 UTC
It builds now with slibtool, thanks