Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 75857 - version bump: gxine-0.4.1
Summary: version bump: gxine-0.4.1
Status: RESOLVED DUPLICATE of bug 74916
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-27 16:35 UTC by Benoit Boissinot
Modified: 2005-07-17 13:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (gxine-0.4.1.ebuild,1.13 KB, text/plain)
2004-12-27 16:36 UTC, Benoit Boissinot
Details
Ebuild for gxine-0.4.1, requires gxine-menu-fix.patch (gxine-0.4.1.ebuild,1.27 KB, text/plain)
2004-12-30 16:29 UTC, Simon Holm Thøgersen
Details
Patching gxine.desktop for proper menu. (gxine-menu-fix.patch,972 bytes, patch)
2004-12-30 16:31 UTC, Simon Holm Thøgersen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benoit Boissinot 2004-12-27 16:35:29 UTC
version bump, ebuild follow

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Benoit Boissinot 2004-12-27 16:36:27 UTC
Created attachment 47001 [details]
ebuild

ebuild
Comment 2 Simon Holm Thøgersen 2004-12-30 16:25:36 UTC
This is a duplicate of bug #74916 (http://bugs.gentoo.org/show_bug.cgi?id=74916), but the ebuild here is a bit better. The version of GLIB should be 2.4 and not 2.2 according to the INSTALL (accoring to the ChangeLog because tests with 2.2 was unavailable and therefore it might work with 2.2, but since it's the official requirement and version 2.2 of glib isn't in Portage anymore, it should be 2.4 IMO). 

Bug #64578 (http://bugs.gentoo.org/show_bug.cgi?id=64578) asks for inclusion of mime-type-association, and I've included the change the bug suggest in gxine.desktop verbatim (the bug also have a correction for Makefile.in which isn't needed anymore, as it has been fixed upstream). Also the extra lines in the ebuild that the bug suggests has been added to my version of the ebuild for 0.4.1.

Bug #50296 (http://bugs.gentoo.org/show_bug.cgi?id=50296) asks for a menu icon, either by moving, copying or symlinking the icon to /usr/share/pixmaps/, or changing the value for Icon in gnome.desktop to use an absolute path name. There's some *.desktop that takes the last approach, so I've made that change as well in gnome.desktop. Actually I think moving the icon is a better solution, but the gnome team must be the ones to ask here, and eventually make an upstream request if this is gnome-apps policy.

Bug #70391 (http://bugs.gentoo.org/show_bug.cgi?id=70391) will also be resolved according to the ChangeLog, which says
"0.4.0-rc1:
...
+ fix loading of GNOME VFS library (Debian 221509)
...".

Finally I added "Categories=Application;AudioVideo;" to gxine.desktop, with grip.desktop as inspiration, to make gxine actually show up in the menu under Multimedia. Again, the gnome team should have a look at this since I'm not 100% confident this is the right way.

Bottom line is I've attached a menu patch and a new ebuild.

Happy new year to everyone ;)
Comment 3 Simon Holm Thøgersen 2004-12-30 16:29:09 UTC
Created attachment 47253 [details]
Ebuild for gxine-0.4.1, requires gxine-menu-fix.patch

Patches gxine with gxine-menu-fix.patch and does mime-update.
Comment 4 Simon Holm Thøgersen 2004-12-30 16:31:59 UTC
Created attachment 47254 [details, diff]
Patching gxine.desktop for proper menu.

Uses absolute path to Icon and adds proper menu categorie and mime-type.
Comment 5 Benoit Boissinot 2004-12-30 16:37:58 UTC
Should i resolve this bug as dup ?

Benoit
Comment 6 Simon Holm Thøgersen 2004-12-30 17:09:56 UTC
I guess that would be the most correct thing to do, but you should move the attachments to the other bug. And maybe you could try my extension of your ebuild while we wait for a dev ;0)
Comment 7 Andrew Conkling 2004-12-31 09:42:18 UTC
In reply to http://bugs.gentoo.org/show_bug.cgi?id=75857#c4 :

Please don't add absolute path names to icons in .desktop files.  That removes all possibility of theming that icon.
Comment 8 Ed Catmur 2005-01-13 13:05:32 UTC
I've attached an ebuild incorporating comment 7 to bug 74916 so this can now be marked duplicate. btw, it works fine - thanks.
Comment 9 Benoit Boissinot 2005-01-14 00:47:40 UTC

*** This bug has been marked as a duplicate of 74916 ***