Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 738470 - games-emulation/dosbox-staging ebuild improvements
Summary: games-emulation/dosbox-staging ebuild improvements
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
Depends on:
Reported: 2020-08-22 04:45 UTC by BT
Modified: 2020-09-04 21:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Note You need to log in before you can comment on or make changes to this bug.
Description BT 2020-08-22 04:45:36 UTC
Some suggestions for improving the ebuild.

* When calling doicon on an SVG file, the '-s scalable' option should be used[1]:

doicon -s scalable contrib/icons/dosbox-staging.svg

* When installing/removing icons, the icon cache should be updated with xdg_icon_cache_update in pkg_postinst() and pkg_postrm() [2].

* Upstream provides a dosbox-staging.desktop file in 'contrib/linux' so there is no need to manually create one with domenu.

domenu contrib/linux/dosbox-staging.desktop

Comment 1 Bernard Cafarelli gentoo-dev 2020-09-04 21:12:54 UTC
Good suggestions, thanks for the report!
I wanted to have a fix for bug #738116 before pushing another revision bump (done now). Fixing
Comment 2 Larry the Git Cow gentoo-dev 2020-09-04 21:26:26 UTC
The bug has been closed via the following commit(s):

commit 0d7dc6ce882f0189e8340630c9bd1fdf75f02d10
Author:     Bernard Cafarelli <>
AuthorDate: 2020-09-04 21:25:48 +0000
Commit:     Bernard Cafarelli <>
CommitDate: 2020-09-04 21:26:21 +0000

    games-emulation/dosbox-staging: small fixes
    Do not call ar directly
    Fix icon installation
    Use provided desktop file
    Package-Manager: Portage-3.0.5, Repoman-3.0.1
    Signed-off-by: Bernard Cafarelli <>

 .../dosbox-staging/dosbox-staging-0.75.1-r2.ebuild | 51 ++++++++++++++++++++++
 .../files/dosbox-staging-0.75.1-ar.patch           | 11 +++++
 2 files changed, 62 insertions(+)