Some suggestions for improving the ebuild. * When calling doicon on an SVG file, the '-s scalable' option should be used[1]: doicon -s scalable contrib/icons/dosbox-staging.svg * When installing/removing icons, the icon cache should be updated with xdg_icon_cache_update in pkg_postinst() and pkg_postrm() [2]. * Upstream provides a dosbox-staging.desktop file in 'contrib/linux' so there is no need to manually create one with domenu. domenu contrib/linux/dosbox-staging.desktop [1] https://devmanual.gentoo.org/eclass-reference/desktop.eclass/index.html [2] https://wiki.gentoo.org/wiki/Notes_on_ebuilds_with_GUI
Good suggestions, thanks for the report! I wanted to have a fix for bug #738116 before pushing another revision bump (done now). Fixing
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d7dc6ce882f0189e8340630c9bd1fdf75f02d10 commit 0d7dc6ce882f0189e8340630c9bd1fdf75f02d10 Author: Bernard Cafarelli <voyageur@gentoo.org> AuthorDate: 2020-09-04 21:25:48 +0000 Commit: Bernard Cafarelli <voyageur@gentoo.org> CommitDate: 2020-09-04 21:26:21 +0000 games-emulation/dosbox-staging: small fixes Do not call ar directly Fix icon installation Use provided desktop file Closes: https://bugs.gentoo.org/738116 Closes: https://bugs.gentoo.org/738470 Package-Manager: Portage-3.0.5, Repoman-3.0.1 Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org> .../dosbox-staging/dosbox-staging-0.75.1-r2.ebuild | 51 ++++++++++++++++++++++ .../files/dosbox-staging-0.75.1-ar.patch | 11 +++++ 2 files changed, 62 insertions(+)
