Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 703864 - x11-libs/gdk-pixbuf-loader-webp-0.0.1: version bump, EAPI-7 bump
Summary: x11-libs/gdk-pixbuf-loader-webp-0.0.1: version bump, EAPI-7 bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 770574
  Show dependency tree
 
Reported: 2019-12-26 18:17 UTC by David Heidelberg (okias)
Modified: 2021-03-06 21:32 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gdk-pixbuf-loader-webp-9999.ebuild (gdk-pixbuf-loader-webp-9999.ebuild,641 bytes, text/plain)
2019-12-27 20:38 UTC, Robert Schultz
Details
gdk-pixbuf-loader-webp-9999.ebuild (gdk-pixbuf-loader-webp-9999.ebuild,641 bytes, text/plain)
2019-12-27 20:40 UTC, Robert Schultz
Details
gdk-pixbuf-loader-webp-0_p20191003.ebuild (gdk-pixbuf-loader-webp-0_p20191003.ebuild,785 bytes, text/plain)
2020-01-05 15:37 UTC, Robert Schultz
Details
Ebuild for 0.0.1 (gdk-pixbuf-loader-webp-0.0.1.ebuild,932 bytes, text/plain)
2020-05-30 19:31 UTC, bzoloid
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Heidelberg (okias) 2019-12-26 18:17:33 UTC
Switches to meson build and works. Pullrequest.

Reproducible: Always
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-12-27 15:51:56 UTC
*** Bug 703866 has been marked as a duplicate of this bug. ***
Comment 2 Robert Schultz 2019-12-27 20:38:33 UTC
Created attachment 601424 [details]
gdk-pixbuf-loader-webp-9999.ebuild

I've attached an ebuild that builds the latest github code with meson. Works great, I now have webp support in gqview, geeqie, etc.

There is probably a better way to handle src_install() but I'm not very skilled at writing ebuilds.
Basically the meson install script runs a custom script 'gdk-pixbuf-query-loaders --update-cache' which modifies files in /usr/lib64/gdk-pixbuf-2.0/2.10.0/*
But that requires the file to already have been installed to /usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders, but this fails since Gentoo installs it into ${D} which is /image, so the command `gdk-pixbuf-query-loaders --update-cache` won't find it. So my src_install() just adds the target dir to add_write and then calls the meson install script manually. Works, but feels non-gentooy.
Comment 3 Robert Schultz 2019-12-27 20:40:58 UTC
Created attachment 601426 [details]
gdk-pixbuf-loader-webp-9999.ebuild
Comment 4 David Heidelberg (okias) 2019-12-30 00:23:11 UTC
this library is hardly updated and will be much better to be able stabilize it with relation to specific commit. Also -9999 version will be never keyworded, so no-one will use it in the end.
Comment 5 Robert Schultz 2019-12-30 02:39:37 UTC
(In reply to David Heidelberg (okias) from comment #4)
> this library is hardly updated and will be much better to be able stabilize
> it with relation to specific commit. Also -9999 version will be never
> keyworded, so no-one will use it in the end.

Whoops, sorry. My comment and ebuild example wasn’t meant to imply I think it should be a -9999 version, I just wanted to upload an example ebuild that works, just in case another Gentoo user found their way here and wanted to get a working ebuild. I’ve not created many custom ebuilds before.

You are absolutely right that it should be versioned to a specific commit.
Comment 6 Robert Schultz 2020-01-05 15:37:18 UTC
Created attachment 602596 [details]
gdk-pixbuf-loader-webp-0_p20191003.ebuild

Updated the attached ebuild to pull the specific commit.
Comment 7 David Heidelberg (okias) 2020-01-05 15:49:45 UTC
(In reply to Robert Schultz from comment #6)
> Created attachment 602596 [details]
> gdk-pixbuf-loader-webp-0_p20191003.ebuild
> 
> Updated the attached ebuild to pull the specific commit.

check out pullrequest in "See also" :)
Comment 8 Robert Schultz 2020-01-05 16:28:03 UTC
(In reply to David Heidelberg (okias) from comment #7)
> (In reply to Robert Schultz from comment #6)
> > Created attachment 602596 [details]
> > gdk-pixbuf-loader-webp-0_p20191003.ebuild
> > 
> > Updated the attached ebuild to pull the specific commit.
> 
> check out pullrequest in "See also" :)

I'll do that.

One question though, the current ebuild is:
gdk-pixbuf-loader-webp-20160328234507.ebuild

I see that 20160328 is the correct date for the last version, but the suffix '234507' is a mystery to me. It doesn't seem to correlate with a commit id or anything and the original bug and pull request doesn't mention it at all. https://bugs.gentoo.org/575030

Due to this version number, my attached ebuild is considered 'older', as it's 0_. Won't work to just reversion it as '20191003' as that is less than 20160328234507.

Is there old ebuild version scheme a mistake? Or what is the proper way to version the new ebuild?

Thanks
Comment 9 David Heidelberg (okias) 2020-01-06 11:05:08 UTC
Don't worry, noone using that ebuild and it's masked, so people will just "downgrade" in worst case.

It was probably mistake when it was added.
Comment 10 David Heidelberg (okias) 2020-03-11 18:22:04 UTC
0.0.1 version officially released.
Comment 11 bzoloid 2020-05-30 19:31:17 UTC
Created attachment 642780 [details]
Ebuild for 0.0.1

Attached an ebuild proposal for version 0.0.1.
Hope it helps.
Comment 12 Pacho Ramos gentoo-dev 2020-06-06 19:06:04 UTC
Why was this pushed to :guru overlay instead of fixing in the main tree? :/ It is because we need to kill x11-libs/gdk-pixbuf-loader-webp in favor of gui-libs/webp-pixbuf-loader

In that case masking old package shouldn't be hard as it was unkeyworded

Thanks
Comment 13 Pacho Ramos gentoo-dev 2020-07-04 23:06:38 UTC
What is blocking this from being fixed in main tree?
Comment 14 Pacho Ramos gentoo-dev 2020-08-31 12:11:14 UTC
ping

Thanks
Comment 15 Andreas Sturmlechner gentoo-dev 2020-10-24 10:24:46 UTC
Please also port to EAPI-7.
Comment 16 bzoloid 2020-10-24 13:01:47 UTC
(In reply to Andreas Sturmlechner from comment #15)
> Please also port to EAPI-7.

Hello,
The latest attached ebuild already has EAPI=7
Thanks
Comment 17 Larry the Git Cow gentoo-dev 2021-03-06 21:32:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53776758a39cc7e3363b0854c45c77c7bb701fcc

commit 53776758a39cc7e3363b0854c45c77c7bb701fcc
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2021-03-06 21:31:38 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2021-03-06 21:32:05 +0000

    gui-libs/gdk-pixbuf-loader-webp: bump to 0.0.2
    
    Closes: https://bugs.gentoo.org/703864
    Closes: https://bugs.gentoo.org/693062
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 gui-libs/gdk-pixbuf-loader-webp/Manifest           |  1 +
 .../gdk-pixbuf-loader-webp-0.0.2.ebuild            | 59 ++++++++++++++++++++++
 2 files changed, 60 insertions(+)