Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 684116 - <www-client/google-chrome-75.x: apply workaround to /usr/bin/google-chrome-stable to parse GNOME sessions properly
Summary: <www-client/google-chrome-75.x: apply workaround to /usr/bin/google-chrome-st...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-22 12:48 UTC by Pacho Ramos
Modified: 2019-04-24 16:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
1.patch (1.patch,726 bytes, patch)
2019-04-22 14:16 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2019-04-22 12:48:10 UTC
This is a follow up from:
https://bugs.gentoo.org/683792

I was thinking that maybe it would be possible to apply a workaroung in /usr/bin/google-chrome-stable wrapper to solve this issue:
https://chromium.googlesource.com/chromium/src/+/dd407d416fa941c04e33d81f2b1d8cab8196b633

The idea would be to end up launching google-chrome with XDG_CURRENT_DESKTOP="gnome" as soon as that variable contains GNOME 

Simply ensuring XDG_CURRENT_DESKTOP="gnome" is passed to current google-chrome solves the issues... but I think we cannot fix it in a better way until google-chrome-75 is not going to stable or Google finally applies to fix to older versions

Thanks
Comment 1 Pacho Ramos gentoo-dev 2019-04-22 14:16:58 UTC
Created attachment 573804 [details, diff]
1.patch

This works fine for me
Comment 2 Pacho Ramos gentoo-dev 2019-04-24 15:17:45 UTC
(In reply to Pacho Ramos from comment #1)
> Created attachment 573804 [details, diff] [details, diff]
> 1.patch
> 
> This works fine for me

Regarding the ebuild, it simply runs eapply for that patch... in src_install because unpacking happens there for this ebuild . I can provide a diff too... but it's simply to add the line :)
Comment 3 Larry the Git Cow gentoo-dev 2019-04-24 15:36:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b51d344e64ba2c17f81372844a6d5ddcc01c3173

commit b51d344e64ba2c17f81372844a6d5ddcc01c3173
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2019-04-24 15:35:35 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-04-24 15:36:03 +0000

    www-client/google-chrome-beta: apply workaround for GNOME
    
    Closes: https://bugs.gentoo.org/684116
    Package-Manager: Portage-2.3.62_p4, Repoman-2.3.12_p87
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 www-client/google-chrome-beta/files/chrome-gnome.patch     | 14 ++++++++++++++
 ...8.ebuild => google-chrome-beta-74.0.3729.108-r1.ebuild} |  2 ++
 2 files changed, 16 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74e5540ea5cdf5e9b75cc2d106996a70574e3233

commit 74e5540ea5cdf5e9b75cc2d106996a70574e3233
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2019-04-24 15:33:30 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-04-24 15:36:03 +0000

    www-client/google-chrome: apply workaround for GNOME
    
    Bug: https://bugs.gentoo.org/684116
    Package-Manager: Portage-2.3.62_p4, Repoman-2.3.12_p87
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 www-client/google-chrome/files/chrome-gnome.patch          | 14 ++++++++++++++
 ...29.108.ebuild => google-chrome-74.0.3729.108-r1.ebuild} |  2 ++
 2 files changed, 16 insertions(+)
Comment 4 Pacho Ramos gentoo-dev 2019-04-24 16:17:38 UTC
Thanks a lot Mike!