Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 683792 - www-client/chromium-73.x: backport patch to fix parsing of GNOME sessions
Summary: www-client/chromium-73.x: backport patch to fix parsing of GNOME sessions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-18 19:46 UTC by Pacho Ramos
Modified: 2019-04-22 12:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2019-04-18 19:46:06 UTC
Since Gnome 3.30 we need to apply this patch to our chromium-73 (google-chrome-stable also suffers from the same issue)
https://chromium.googlesource.com/chromium/src/+/dd407d416fa941c04e33d81f2b1d8cab8196b633

It can be reproduced, for example, with Gnome 3.30 Classic mode, you will see that issues with the keyring and, in my case, I was suffering lock screen not being inhibited while watching videos.

After applying the patch (as-is) to our ebuilds, at least for chromium, the problem gets solved

Thanks
Comment 1 Mike Gilbert gentoo-dev 2019-04-18 19:56:02 UTC
Is this fix included in 74.x?
Comment 2 Pacho Ramos gentoo-dev 2019-04-18 20:05:58 UTC
It seems that no :( , only in 75.x:
https://chromium.googlesource.com/chromium/src.git/+/refs/tags/74.0.3729.99/base/nix/xdg_util.cc
Comment 3 Mike Gilbert gentoo-dev 2019-04-18 20:23:53 UTC
Ok, please feel free to add this patch to the current ebuild.
Comment 4 Pacho Ramos gentoo-dev 2019-04-18 20:46:54 UTC
No problem, only one question: I would apply it with a revision bump... but I am unsure if you maybe have a "special" policy as chromium takes a long long time to be rebuilt in some machines and prefer to get it applied to current testing version without revbumping or you prefer to wait for next upstream release to apply it...  :/
Comment 5 Mike Gilbert gentoo-dev 2019-04-18 21:11:43 UTC
Please apply it without a revbump. I will be adding a version bump this weekend.
Comment 6 Larry the Git Cow gentoo-dev 2019-04-18 21:35:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a307a6b20508519da3a6f038a301334191f62b36

commit a307a6b20508519da3a6f038a301334191f62b36
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2019-04-18 21:34:56 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2019-04-18 21:35:10 +0000

    www-client/chromium: Backport XDG_CURRENT_DESKTOP parsing fix
    
    Closes: https://bugs.gentoo.org/683792
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 www-client/chromium/chromium-73.0.3683.86.ebuild   |   1 +
 .../files/chromium-73-xdg-current-desktop.patch    | 124 +++++++++++++++++++++
 2 files changed, 125 insertions(+)