Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 683674 - gnome-base/gnome-keyring-3.28.2: missing #include <sys/select.h>
Summary: gnome-base/gnome-keyring-3.28.2: missing #include <sys/select.h>
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://gitlab.gnome.org/GNOME/gnome-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-17 12:54 UTC by Anthony Basile
Modified: 2019-05-30 07:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Basile gentoo-dev 2019-04-17 12:54:13 UTC
In file pkcs11/rpc-layer/gkm-rpc-daemon-standalone.c there is a reference to fd_set on line 65.  This requires <sys/select.h> by POSIX.  The problem doesn't show up on systems with glibc because of the way the headers stack there.  But on other libc's like musl or uclibc, this causes a build time failure.  The following  fixes the problem:

--- gnome-keyring-3.14.0.orig/pkcs11/rpc-layer/gkm-rpc-daemon-standalone.c	
+++ gnome-keyring-3.14.0/pkcs11/rpc-layer/gkm-rpc-daemon-standalone.c
@@ -34,6 +34,7 @@
 
 #include <dlfcn.h>
 #include <pthread.h>
+#include <sys/select.h>
 
 #define SOCKET_PATH "/tmp/gkm-rpc-daemon.sock"


If you need to convince upstream, here's the POSIX requirement:

https://pubs.opengroup.org/onlinepubs/009696899/basedefs/sys/select.h.html
Comment 1 Anthony Basile gentoo-dev 2019-04-17 13:12:48 UTC
Upstream bug opened at https://gitlab.gnome.org/GNOME/gnome-keyring/issues/29
Comment 3 Anthony Basile gentoo-dev 2019-05-13 13:57:36 UTC
(In reply to Anthony Basile from comment #2)
> Fixed upstream: 
> https://gitlab.gnome.org/GNOME/gnome-keyring/commit/
> 1b6742acc9984f15665b8dba0a654e616426cb62

May I have permission to backport this patch?
Comment 4 Anthony Basile gentoo-dev 2019-05-21 13:35:05 UTC
(In reply to Anthony Basile from comment #3)
> (In reply to Anthony Basile from comment #2)
> > Fixed upstream: 
> > https://gitlab.gnome.org/GNOME/gnome-keyring/commit/
> > 1b6742acc9984f15665b8dba0a654e616426cb62
> 
> May I have permission to backport this patch?

ping
Comment 5 Pacho Ramos gentoo-dev 2019-05-30 07:32:29 UTC
Go ahead please

Thanks!