Bug 683674 – gnome-base/gnome-keyring-3.28.2: missing #include <sys/select.h>

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Anthony Basile 2019-04-17 12:54:13 UTC]

In file pkcs11/rpc-layer/gkm-rpc-daemon-standalone.c there is a reference to fd_set on line 65.  This requires <sys/select.h> by POSIX.  The problem doesn't show up on systems with glibc because of the way the headers stack there.  But on other libc's like musl or uclibc, this causes a build time failure.  The following  fixes the problem:

--- gnome-keyring-3.14.0.orig/pkcs11/rpc-layer/gkm-rpc-daemon-standalone.c	
+++ gnome-keyring-3.14.0/pkcs11/rpc-layer/gkm-rpc-daemon-standalone.c
@@ -34,6 +34,7 @@
 
 #include <dlfcn.h>
 #include <pthread.h>
+#include <sys/select.h>
 
 #define SOCKET_PATH "/tmp/gkm-rpc-daemon.sock"


If you need to convince upstream, here's the POSIX requirement:

https://pubs.opengroup.org/onlinepubs/009696899/basedefs/sys/select.h.html

[Comment 1 Anthony Basile 2019-04-17 13:12:48 UTC]

Upstream bug opened at https://gitlab.gnome.org/GNOME/gnome-keyring/issues/29

[Comment 2 Anthony Basile 2019-05-10 18:30:34 UTC]

Fixed upstream:  https://gitlab.gnome.org/GNOME/gnome-keyring/commit/1b6742acc9984f15665b8dba0a654e616426cb62

[Comment 3 Anthony Basile 2019-05-13 13:57:36 UTC]

(In reply to Anthony Basile from comment #2)
> Fixed upstream: 
> https://gitlab.gnome.org/GNOME/gnome-keyring/commit/
> 1b6742acc9984f15665b8dba0a654e616426cb62

May I have permission to backport this patch?

[Comment 4 Anthony Basile 2019-05-21 13:35:05 UTC]

(In reply to Anthony Basile from comment #3)
> (In reply to Anthony Basile from comment #2)
> > Fixed upstream: 
> > https://gitlab.gnome.org/GNOME/gnome-keyring/commit/
> > 1b6742acc9984f15665b8dba0a654e616426cb62
> 
> May I have permission to backport this patch?

ping

[Comment 5 Pacho Ramos 2019-05-30 07:32:29 UTC]

Go ahead please

Thanks!

[Comment 6 Larry the Git Cow 2019-09-23 10:39:26 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d91ec7bf4ecbbfcdb7a4cb7889c33ed6cd7c2519

commit d91ec7bf4ecbbfcdb7a4cb7889c33ed6cd7c2519
Author:     Mart Raudsepp <[e-mail]>
AuthorDate: 2019-09-23 10:37:07 +0000
Commit:     Mart Raudsepp <[e-mail]>
CommitDate: 2019-09-23 10:37:07 +0000

    gnome-base/gnome-keyring: bump to 3.31.91
    
    Closes: https://bugs.gentoo.org/683674
    Package-Manager: Portage-2.3.69, Repoman-2.3.12
    Signed-off-by: Mart Raudsepp <[e-mail]>

 gnome-base/gnome-keyring/Manifest                  |  1 +
 .../gnome-keyring/files/3.31.91-fix-musl.patch     | 27 +++++++
 .../gnome-keyring/gnome-keyring-3.31.91.ebuild     | 82 ++++++++++++++++++++++
 3 files changed, 110 insertions(+)