Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659096 - net-analyzer/wireshark: bogus dependency on media-libs/speex
Summary: net-analyzer/wireshark: bogus dependency on media-libs/speex
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL: https://gitweb.gentoo.org/repo/gentoo...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-25 12:52 UTC by Diogo Pereira
Modified: 2020-11-04 09:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diogo Pereira 2018-06-25 12:52:27 UTC
The following commit introduced a bogus dependency on media-libs/speex:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=177e937de0c2b6e47cf6fbc306f409305016ab86
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-10-12 07:47:18 UTC
You'll need to qualify that claim.
Comment 2 Diogo Pereira 2018-10-12 11:18:59 UTC
Wireshark depends on speexdsp, which used to be part of speex until version 1.2. Wireshark does not depend on anything from >=media-libs/speex-1.2. The linked bug and commit should make that clear.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2018-10-12 12:56:36 UTC
Right. Maybe the committer and author can explain why that looks so wrong. What was the intent there? Looking at the current cmake based build system, I don't see it using speexdsp or speex at all, but the changes at the time relate to autotools based builds.
Comment 4 Larry the Git Cow gentoo-dev 2018-10-12 18:59:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da873ca3823c5aa62a6719de6d366971e3c5e8c0

commit da873ca3823c5aa62a6719de6d366971e3c5e8c0
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2018-10-12 18:59:08 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2018-10-12 18:59:38 +0000

    net-analyzer/wireshark: Drop media-libs/speex{,dsp} dependencies
    
    Bug: https://bugs.gentoo.org/659096
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 .../wireshark/{wireshark-2.6.4.ebuild => wireshark-2.6.4-r1.ebuild}   | 2 --
 net-analyzer/wireshark/wireshark-99999999.ebuild                      | 4 +---
 2 files changed, 1 insertion(+), 5 deletions(-)
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2018-10-12 19:00:39 UTC
Current versions of wireshark, or perhaps just cmake builds, do not use either library any longer.
Comment 6 Diogo Pereira 2018-10-14 00:45:45 UTC
From looking around in the source, it bundles a copy of speexdsp (in codecs/speex/). The autotools build could use the system library [1], but not the CMake build.

[1] https://github.com/wireshark/wireshark/commit/9f8fc21b62307da7e63884b677af7e7af84cb5c7