Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 654992 - net-mail/mailutils-3.4: mu_str_to_c test fails (endianness problem)
Summary: net-mail/mailutils-3.4: mu_str_to_c test fails (endianness problem)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: Sparc64 Linux
: Normal normal (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 635216
  Show dependency tree
 
Reported: 2018-05-05 18:24 UTC by Rolf Eike Beer
Modified: 2018-06-22 12:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-Fix-endianness-bug-in-string-to-IP-conversion.patch (0001-Fix-endianness-bug-in-string-to-IP-conversion.patch,2.88 KB, patch)
2018-06-21 10:45 UTC, Eray Aslan
Details | Diff
redone patch (endianess.patch,2.37 KB, patch)
2018-06-21 16:45 UTC, Rolf Eike Beer
Details | Diff
build.log (build.log,724.21 KB, text/plain)
2018-06-21 16:46 UTC, Rolf Eike Beer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer archtester 2018-05-05 18:24:02 UTC
The error is obviously a big endian problem:

#                             -*- compilation -*-
1. strtoc.at:17: testing mu_str_to_c ...
./strtoc.at:18: strtoc
--- /dev/null   2018-05-03 08:45:02.879999416 +0200
+++ /var/tmp/portage/net-mail/mailutils-3.4/work/mailutils-3.4/libmailutils/tests/testsuite.dir/at-groups/1/stderr      2018-05-04 07:51:41.401805688 +0200
@@ -0,0 +1 @@
+14: FAIL: mu_c_cidr value differ: expected: 127.0.0.0/255.0.0.0, but got: 0.0.0.127/255.0.0.0
./strtoc.at:18: exit code was 1, expected 0
1. strtoc.at:17: 1. mu_str_to_c (strtoc.at:17): FAILED (strtoc.at:18)
Comment 1 Eray Aslan gentoo-dev 2018-06-21 10:45:06 UTC
Created attachment 536656 [details, diff]
0001-Fix-endianness-bug-in-string-to-IP-conversion.patch

Can you please check if the attached patch works?  Thanks.
Comment 2 Rolf Eike Beer archtester 2018-06-21 16:45:26 UTC
Created attachment 536688 [details, diff]
redone patch

Your patch is mangled, so it did not apply. I have redone it, this is the version that I used.
Comment 3 Rolf Eike Beer archtester 2018-06-21 16:46:26 UTC
Created attachment 536690 [details]
build.log

This is the build log with the patch. I do not have time to look into it deeper right now, maybe later.
Comment 4 Eray Aslan gentoo-dev 2018-06-22 05:25:55 UTC
From your log:

> Conversions
>
>  1: mu_str_to_c                                     ok

i.e. big endian error is fixed.  Some other tests are failing but that's a separate issue - bug 648754.  Thanks for testing.
Comment 5 Larry the Git Cow gentoo-dev 2018-06-22 12:21:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f99b2a0dc1644fd2983a787ff7d0354b09946f7e

commit f99b2a0dc1644fd2983a787ff7d0354b09946f7e
Author:     Eray Aslan <eras@gentoo.org>
AuthorDate: 2018-06-22 12:20:34 +0000
Commit:     Eray Aslan <eras@gentoo.org>
CommitDate: 2018-06-22 12:21:08 +0000

    net-mail/mailutils: fix endiannes problem
    
    Closes: https://bugs.gentoo.org/654992
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 .../files/mailutils-3.4-fix-endianness.patch       | 122 +++++++++++++++++++
 net-mail/mailutils/mailutils-3.4-r2.ebuild         | 133 +++++++++++++++++++++
 2 files changed, 255 insertions(+)