Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 640456 - sys-apps/gentoo-functions remove broken get_libdir function
Summary: sys-apps/gentoo-functions remove broken get_libdir function
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: no-symlink-lib
  Show dependency tree
 
Reported: 2017-12-10 04:40 UTC by Mike Gilbert
Modified: 2021-08-30 21:18 UTC (History)
12 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2017-12-10 04:40:08 UTC
The concept of a "get_libdir" function outside of the package manager is broken. The libdir is a value that is defined at package build time, not run time.

On a typical Gentoo system, this function will always return "lib", which is often the wrong value on a multilib system with SYMLINK_LIB=no (like amd64).

Please deprecate and remove this function.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-04-21 06:30:48 UTC
Ping.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-05-05 06:37:29 UTC
Ping².
Comment 3 Larry the Git Cow gentoo-dev 2021-08-30 21:14:45 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=b4986e8ca60437c6c155efedc14cc4480b519482

commit b4986e8ca60437c6c155efedc14cc4480b519482
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2021-08-30 21:03:00 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2021-08-30 21:13:15 +0000

    functions.sh: drop get_libdir
    
    libdir is defined when packages are built. Trying to determine its value
    via a runtime function makes no sense.
    
    On a typical Gentoo system, this function will always return "lib",
    which is often the wrong value on a multilib system with SYMLINK_LIB=no.
    
    Bug: https://bugs.gentoo.org/640456
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 functions.sh | 13 -------------
 1 file changed, 13 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2021-08-30 21:18:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d96cb64b4d56a22d101a71212008e6cda7cd33d

commit 5d96cb64b4d56a22d101a71212008e6cda7cd33d
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2021-08-30 21:17:39 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2021-08-30 21:17:39 +0000

    sys-apps/gentoo-functions: add 0.15
    
    Closes: https://bugs.gentoo.org/640456
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-apps/gentoo-functions/Manifest                 |  1 +
 .../gentoo-functions/gentoo-functions-0.15.ebuild  | 28 ++++++++++++++++++++++
 2 files changed, 29 insertions(+)