Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 640460 - app-eselect/eselect-php php-fpm-launcher should not use get_libdir function
Summary: app-eselect/eselect-php php-fpm-launcher should not use get_libdir function
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on: 642788
Blocks: no-symlink-lib
  Show dependency tree
 
Reported: 2017-12-10 05:05 UTC by Mike Gilbert
Modified: 2018-05-14 20:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2017-12-10 05:05:03 UTC
The get_libdir function from gentoo-functions is broken on SYMLINK_LIB=no amd64 systems.

Please replace the libdir value at build time instead of trying to figure it out at run time.
Comment 1 Steffen Weber 2017-12-10 13:10:41 UTC
Just ran into this issue on a SYMLINK_LIB=no system:

/usr/libexec/php-fpm-launcher: line 13: /usr/lib/php7.1/bin/php-fpm: No such file or directory

The workaround is to replace "$(get_libdir)" with "lib64" in /usr/lib/php7.1/bin/php-fpm.
Comment 2 Steffen Weber 2017-12-10 13:11:50 UTC
The workaround is to replace "$(get_libdir)" with "lib64" in /usr/libexec/php-fpm-launcher.
Comment 3 Michael Orlitzky gentoo-dev 2017-12-10 15:40:02 UTC
We should get rid of the automatic slot detection in both our OpenRC and systemd service scripts: bug 632690. It'd be much simpler to install one service script per slot.

In the meantime, we can probably hack a @LIBDIR@ in there...
Comment 4 Larry the Git Cow gentoo-dev 2017-12-10 22:02:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bbd39788128eeb5fe16a41f55c7da8ce5c0808e2

commit bbd39788128eeb5fe16a41f55c7da8ce5c0808e2
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2017-12-10 21:05:33 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2017-12-10 22:02:01 +0000

    app-eselect/eselect-php: do not use get_libdir in php-fpm-launcher
    
    Closes: https://bugs.gentoo.org/640460
    Package-Manager: Portage-2.3.17, Repoman-2.3.6

 .../eselect-php/eselect-php-0.9.4-r3.ebuild        | 67 ++++++++++++++++++++++
 app-eselect/eselect-php/eselect-php-9999.ebuild    |  3 +-
 app-eselect/eselect-php/files/php-fpm-launcher-r3  | 11 ++++
 3 files changed, 80 insertions(+), 1 deletion(-)
Comment 5 Mike Gilbert gentoo-dev 2017-12-10 23:20:57 UTC
Re-opening until the new version is marked stable.
Comment 6 Larry the Git Cow gentoo-dev 2017-12-11 13:29:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fdde370f7aeefee94d26a1b7c2a89a171e9a0252

commit fdde370f7aeefee94d26a1b7c2a89a171e9a0252
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2017-12-11 13:22:29 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2017-12-11 13:22:45 +0000

    app-eselect/eselect-php: drop unused eselect-php-0.9.4-r2.ebuild.
    
    Bug: https://bugs.gentoo.org/640460
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 .../eselect-php/eselect-php-0.9.4-r2.ebuild        | 66 ----------------------
 1 file changed, 66 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=35ff1eab9f67bdb714bd1de2f874540f59c3a376

commit 35ff1eab9f67bdb714bd1de2f874540f59c3a376
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2017-12-11 13:09:25 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2017-12-11 13:22:45 +0000

    app-eselect/eselect-php: drop sys-apps/gentoo-functions dependency.
    
    Thanks to Craig Andrews in commit bbd39788, we no longer need to pull
    in sys-apps/gentoo-functions when USE=fpm is set. Drop it from the
    latest revision and the live ebuild.
    
    Bug: https://bugs.gentoo.org/640460
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 .../{eselect-php-0.9.4-r3.ebuild => eselect-php-0.9.4-r4.ebuild}       | 3 +--
 app-eselect/eselect-php/eselect-php-9999.ebuild                        | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)}