const char *cdtext_get_const (const cdtext_t *p_cdtext, cdtext_field_t field, ^~~~~~~~~~~~~~~~ gvfsbackendcdda.c:182:56: error: too few arguments to function ‘cdtext_get_const’ cdda_backend->album_title = cdtext_string_to_utf8 (cdtext_get_const (CDTEXT_TITLE, cdtext)); ^~~~~~~~~~~~~~~~ In file included from /usr/include/cdio/cdio.h:59:0, ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.0-desktop_20171121-221602 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-7.2.0 * Available Python interpreters, in order of preference: [1] python3.4 [2] python2.7 (fallback) Available Ruby profiles: [1] ruby22 (with Rubygems) * java-config: The following VMs are available for generation-2: *) IcedTea JDK 3.6.0 [icedtea-bin-8] Available Java Virtual Machines: [1] icedtea-bin-8 system-vm emerge -qpv gnome-base/gvfs [ebuild R ] gnome-base/gvfs-1.32.1 USE="cdda gtk http policykit udev udisks -afp -archive -bluray -fuse -gnome-keyring -gnome-online-accounts -google -gphoto2 -ios -mtp -nfs -samba -systemd {-test} -zeroconf"
Created attachment 506168 [details] emerge-info.txt
Created attachment 506170 [details] emerge-history.txt
Created attachment 506172 [details] environment
Created attachment 506174 [details] etc.portage.tbz2
Created attachment 506176 [details] gnome-base:gvfs-1.32.1:20171123-185844.log
Created attachment 506178 [details] logs.tbz2
Created attachment 506180 [details] temp.tbz2
Created attachment 506226 [details, diff] libcdio_1.0.0.patch libcdio changed its version number to '1' when it went to 1.0.0. That breaks the version checks in gvfs. The broken version checks cause the issue Toralf reported. This patch fixes that by updating the checks to explicitly check if the version number is set to '1'.
(In reply to nvinson234 from comment #8) > Created attachment 506226 [details, diff] [details, diff] > libcdio_1.0.0.patch > > libcdio changed its version number to '1' when it went to 1.0.0. That > breaks the version checks in gvfs. The broken version checks cause the > issue Toralf reported. > > This patch fixes that by updating the checks to explicitly check if the > version number is set to '1'. Patch works fine: gvfs revdep-rebuild now succeeds. Thanks!
This might get changed upstream, see https://savannah.gnu.org/bugs/?52491 The (in development) libcdio 1.0.1 will report itself as version 10001, which should unbreak version-checking code like this. I don't know if upstream is planning to release a 1.0.1 release quickly, to avoid packages like gvfs (and gst-plugins-cdio, see bug 638644) having to patch.
Same here
Was it changed upstream then for 2.0.0-r1 or earlier? I don't have any issues here; do we need to do anything here for gvfs?
This was fixed in Gentoo's libcdio-1.0.0 by https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ba52139c96a39f6f2285edb173af960a2afb51fa and fixed upstream in later versions of libcdio (1.1.0 and 2.0.0).
OK, thanks!
