Bug 638682 – media-plugins/audacious-plugins-3.9-r1: missing dependency on dev-libs/libcdio (was: with dev-libs/libcdio-1.0.0: cdaudio-ng.cc:39:10: fatal error: cdio/cdda.h: No such file or directory)

• Status: RESOLVED TEST-REQUEST
• Product: Gentoo Linux

[Description Helmut Jarausch 2017-11-24 13:33:57 UTC]

Rebuilding media-plugins/audacious-plugins-3.9-r1 after upgrading to
libcdio-1.0.0 fails with

cdaudio-ng.cc:39:10: fatal error: cdio/cdda.h: No such file or directory
 #include <cdio/cdda.h>

And there isn't such a file any more  after upgrading to libcdio-1.0.0

I don't think a full build log is required.

[Comment 1 Torsten Kurbad 2017-11-25 08:37:45 UTC]

I can confirm this behaviour for media-plugins/audacious-plugins

[Comment 2 Helmut Jarausch 2017-11-25 10:41:54 UTC]

Created attachment 506538 [details, diff]
patch for libcdio-1.x

Unfortunately, libcdio has changed its version numbering scheme.
Earlier version had version numbers >> 1,  e.g. 90

libcdio-1.0.0 has version  "1.0.1"

The attached patch only works for libcdio-1.0.0 or earlier versions with version number >= 90

[Comment 3 Torsten Kurbad 2017-11-26 19:22:50 UTC]

(In reply to Helmut Jarausch from comment #2)
> Created attachment 506538 [details, diff] [details, diff]
> patch for libcdio-1.x
> 
> Unfortunately, libcdio has changed its version numbering scheme.
> Earlier version had version numbers >> 1,  e.g. 90
> 
> libcdio-1.0.0 has version  "1.0.1"
> 
> The attached patch only works for libcdio-1.0.0 or earlier versions with
> version number >= 90

The patch does not resolve the problem for me. Obviously, the number and structure of several method arguments has changed, too.

Here's the relevant excerpt from the build.log:

cdaudio-ng.cc: In function ‘bool scan_cd()’:
cdaudio-ng.cc:559:69: error: too many arguments to function ‘cdtext_t* cdio_get_cdtext(CdIo_t*)’
             pcdtext = cdio_get_cdtext (pcdrom_drive->p_cdio, trackno);
                                                                     ^
In file included from /usr/include/cdio/cdio.h:62:0,
                 from cdaudio-ng.cc:29:
/usr/include/cdio/disc.h:77:13: note: declared here
   cdtext_t *cdio_get_cdtext (CdIo_t *p_cdio);
             ^~~~~~~~~~~~~~~
cdaudio-ng.cc:560:46: error: invalid use of incomplete type ‘cdtext_t {aka struct cdtext_s}’
             if (pcdtext == nullptr || pcdtext->field[CDTEXT_PERFORMER] == nullptr)
                                              ^~
In file included from /usr/include/cdio/cdio.h:59:0,
                 from cdaudio-ng.cc:29:
/usr/include/cdio/cdtext.h:201:16: note: forward declaration of ‘cdtext_t {aka struct cdtext_s}’
 typedef struct cdtext_s cdtext_t;
                ^~~~~~~~
cdaudio-ng.cc:560:48: error: invalid use of incomplete type ‘cdtext_t {aka struct cdtext_s}’
             if (pcdtext == nullptr || pcdtext->field[CDTEXT_PERFORMER] == nullptr)
                                                ^~~~~
In file included from /usr/include/cdio/cdio.h:59:0,
                 from cdaudio-ng.cc:29:
/usr/include/cdio/cdtext.h:201:16: note: forward declaration of ‘cdtext_t {aka struct cdtext_s}’
 typedef struct cdtext_s cdtext_t;
                ^~~~~~~~
cdaudio-ng.cc:560:54: error: ‘CDTEXT_PERFORMER’ was not declared in this scope
             if (pcdtext == nullptr || pcdtext->field[CDTEXT_PERFORMER] == nullptr)
                                                      ^~~~~~~~~~~~~~~~
cdaudio-ng.cc:560:54: note: suggested alternative: ‘CDTEXT_FIELD_PERFORMER’
             if (pcdtext == nullptr || pcdtext->field[CDTEXT_PERFORMER] == nullptr)
                                                      ^~~~~~~~~~~~~~~~
                                                      CDTEXT_FIELD_PERFORMER

[Comment 4 Torsten Kurbad 2017-11-26 19:52:15 UTC]

Created attachment 506766 [details, diff]
audacious-plugins-3.9-libcdio-1.0.0.patch

This revised patch fixes it for me. Anyway, this can't get to portage since it eliminates all conditional handling of libcdio versions...

[Comment 5 Torsten Kurbad 2017-11-26 20:05:54 UTC]

Created attachment 506768 [details, diff]
audacious-plugins-3.9-libcdio-1.0.0.patch

Proper patch that should work for all libcdio versions.

[Comment 6 Andreas Sturmlechner 2018-11-17 19:45:13 UTC]

Not reproducible with libcdio-2.0.0-r1 after that was fixed upsteam, can you confirm?

Package does not depend on dev-libs/libcdio:= when it should, though.

[Comment 7 Larry the Git Cow 2018-11-17 23:42:50 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59ef5cc3cf9b8efce5c7a805b53e33a3e7ff3549

commit 59ef5cc3cf9b8efce5c7a805b53e33a3e7ff3549
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2018-11-17 23:42:31 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2018-11-17 23:42:31 +0000

    media-plugins/audacious-plugins: Add missing DEPEND
    
    Bug: https://bugs.gentoo.org/638682
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 media-plugins/audacious-plugins/audacious-plugins-3.10.ebuild | 1 +
 media-plugins/audacious-plugins/audacious-plugins-9999.ebuild | 1 +
 2 files changed, 2 insertions(+)

[Comment 8 Larry the Git Cow 2018-11-24 23:17:58 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09fd832ba824b6eb86bfc12228a68265d8d15a05

commit 09fd832ba824b6eb86bfc12228a68265d8d15a05
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2018-11-24 21:41:18 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2018-11-24 23:16:42 +0000

    media-plugins/audacious-plugins: Re-add USE qt5, assorted fixes
    
    Add USE opengl
    Disable po dir if USE !nls
    Make USE adplug operational again
    Make USE alsa default
    Merge USE aosd into !qt5
    Merge USE hotkeys into !qt5
    Sort dependencies
    
    Bug: https://bugs.gentoo.org/640672
    Bug: https://bugs.gentoo.org/638682
    Closes: https://bugs.gentoo.org/671728
    Closes: https://bugs.gentoo.org/671506
    Closes: https://bugs.gentoo.org/640842
    Closes: https://bugs.gentoo.org/512698
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 .../audacious-plugins-3.10-r1.ebuild               | 170 +++++++++++++++++++++
 1 file changed, 170 insertions(+)