Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bugzilla DB migration completed. Please report issues to Infra team via email via infra@gentoo.org or IRC
Bug 620716 - media-video/smtube-17.5.0-r1 stabilisation request
Summary: media-video/smtube-17.5.0-r1 stabilisation request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: zlg (RETIRED)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks: qtwebkit4-removal
  Show dependency tree
 
Reported: 2017-06-04 07:00 UTC by Michael Palimaka (kensington)
Modified: 2017-09-29 04:03 UTC (History)
0 users

See Also:
Package list:
media-video/smtube-17.5.0-r1
Runtime testing required: No
stable-bot: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2017-06-04 07:00:23 UTC
Is it OK to stabilise media-video/smtube-17.5.0 and remove older?

That would allow removing a consumer of dev-qt/qtwebkit:4 which is ancient and will never see any security updates.
Comment 1 zlg (RETIRED) gentoo-dev 2017-06-04 08:22:58 UTC
smtube-17.5.0-r1 would be a candidate for stabilizing, since the only thing new is the fix from bug 620720.
Comment 2 Andreas Sturmlechner gentoo-dev 2017-07-30 23:58:36 UTC
I guess we can add arches then...?
Comment 3 zlg (RETIRED) gentoo-dev 2017-07-31 02:08:46 UTC
(In reply to Andreas Sturmlechner from comment #2)
> I guess we can add arches then...?

It's a fairly simple application; feel free to add any arch it works on. I only have an ~amd64 multilib machine to work with.
Comment 4 zlg (RETIRED) gentoo-dev 2017-09-13 22:03:37 UTC
Just pinging for the state of things. I don't want to hold up Qt4 removal.
Comment 5 Michael Palimaka (kensington) gentoo-dev 2017-09-15 10:51:16 UTC
I saw you marked runtime testing as required, I'm curious what runtime issues you think might be uncovered during arch testing that were not discovered during the ~arch waiting period.
Comment 6 zlg (RETIRED) gentoo-dev 2017-09-15 20:35:09 UTC
(In reply to Michael Palimaka (kensington) from comment #5)
> I saw you marked runtime testing as required, I'm curious what runtime
> issues you think might be uncovered during arch testing that were not
> discovered during the ~arch waiting period.

It's possible that the new version may not have updated web API code, or may not hand control over to a media player like it should. I had no issues with it, but I thought there was a chance other arches might discover a problem and erred on the side of caution.

If that's not how runtime testing is meant to be used, then please disregard that part.
Comment 7 Michael Palimaka (kensington) gentoo-dev 2017-09-26 13:14:28 UTC
In my opinion it's not the role of an arch team to uncover routine upstream bugs like that - that's what a package maintainer and waiting period is for.

I believe *arch* teams should focus on identifying arch-specific issues - see https://wiki.gentoo.org/wiki/Package_testing#Runtime_testing for more information.
Comment 8 zlg (RETIRED) gentoo-dev 2017-09-26 20:29:58 UTC
Thanks for the link. I've not experienced any issues with the package, and I use it practically daily. In general, if smtube passes build-time, it will be okay at run-time. The only thing that can really mess it up is if/when the YouTube API changes.

I've removed the runtime testing flag to clear this up. Sorry for misusing that option.
Comment 9 Michael Palimaka (kensington) gentoo-dev 2017-09-29 03:58:29 UTC
 * Checking media-video/smtube-17.5.0-r1 for undeclared dependencies
 *   /usr/bin/smtube links to /usr/lib64/libQt5Widgets.so.5
 *     Missing DEPEND on dev-qt/qtwidgets
 *     Missing RDEPEND on dev-qt/qtwidgets
 *   /usr/bin/smtube links to /usr/lib64/libQt5Network.so.5
 *     Missing DEPEND on dev-qt/qtnetwork
 *     Missing RDEPEND on dev-qt/qtnetwork
Comment 10 Michael Palimaka (kensington) gentoo-dev 2017-09-29 04:01:03 UTC
These are brought in transitively though so while it would be optimal to fix it, it won't block stabilisation.
Comment 11 Larry the Git Cow gentoo-dev 2017-09-29 04:02:12 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c6d8e96f7b2b3f27c9969ccb0fc4fa1a56e5e58f

commit c6d8e96f7b2b3f27c9969ccb0fc4fa1a56e5e58f
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2017-09-29 04:01:55 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2017-09-29 04:02:02 +0000

    media-video/smtube: stabilise 17.5.0-r1 for amd64/x86
    
    Bug: https://bugs.gentoo.org/620716
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 media-video/smtube/smtube-17.5.0-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)}