Bug 612540 – =app-admin/mcelog-148 fails to compile with /bin/sh linked to dash(-0.5.8.2)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Wilke Schwiedop 2017-03-13 19:29:59 UTC]

Created attachment 466972 [details]
Generated version.c file

Looking at mcelogs Makefile the problem seems to be with the build rule for version.tmp
I've attached the generated version.c, which obviously does not compile.

[Comment 1 Ben Kohler 2017-03-13 20:38:52 UTC]

Created attachment 466978 [details, diff]
mcelog-makefile-dash-fix.patch

This patch should fix builds on dash, I've reported upstream but I'm not sure how they feel about other-shell-compat

[Comment 2 Ben Kohler 2017-03-13 21:11:16 UTC]

Fixed upstream
https://github.com/andikleen/mcelog/commit/ad66dd599e8981f5433758ae6da4e8ae07c02258

[Comment 3 Matt Turner 2017-03-13 21:30:29 UTC]

Nice. Thanks for sending those upstream, Ben.

[Comment 4 Wilke Schwiedop 2017-03-14 00:25:33 UTC]

Wow that was fast!

[Comment 5 Ben Kohler 2017-03-28 13:30:26 UTC]

v149 is out with this fix, FYI upstream fixed the *other* bashism too, so we need to drop "${FILESDIR}"/${PN}-1.0_pre3_p20120918-bashism.patch

[Comment 6 Matt Turner 2017-03-28 16:24:53 UTC]

Thanks Ben!

I've pushed a bump to 149 and dropped the upstreamed patch.

We should consider stabilizing 149 soon, since the latest stable doesn't support a bunch of modern hardware (like Skylake).