Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 598410 - dev-libs/libp11: libressl support
Summary: dev-libs/libp11: libressl support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Crypto team [DISABLED]
URL: https://github.com/OpenSC/libp11/issu...
Whiteboard:
Keywords:
: 658610 658654 (view as bug list)
Depends on:
Blocks: libressl-support
  Show dependency tree
 
Reported: 2016-10-29 07:43 UTC by Toralf Förster
Modified: 2019-04-25 05:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
config.log (config.log,37.91 KB, text/plain)
2016-10-29 07:44 UTC, Toralf Förster
Details
dev-libs:libp11-0.4.2:20161029-043217.log (dev-libs:libp11-0.4.2:20161029-043217.log,10.18 KB, text/plain)
2016-10-29 07:44 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,384.70 KB, text/plain)
2016-10-29 07:44 UTC, Toralf Förster
Details
environment (environment,79.45 KB, text/plain)
2016-10-29 07:44 UTC, Toralf Förster
Details
libp11-0.4.4-libressl-2.8.3.patch (libp11-libre.patch,8.73 KB, patch)
2019-03-02 23:11 UTC, pagorman
Details | Diff
libp11-0.4.9-compat-LibreSSL-2.8.3.patch (p11-0.4.9-libre.patch,930 bytes, patch)
2019-03-05 06:47 UTC, pagorman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2016-10-29 07:43:57 UTC
In file included from engine.h:35:0,
                 from eng_front.c:63:
libp11.h:370:1: error: unknown type name 'EC_KEY_METHOD'
 EC_KEY_METHOD *PKCS11_get_ec_key_method(void);
 ^~~~~~~~~~~~~
eng_front.c: In function 'bind_helper':


$ cat emerge-info.txt
  -----------------------------------------------------------------

  This is an unstable amd64 chroot image (named amd64-desktop-libressl-unstable_20161018-205539) at a hardened host acting as a tinderbox.

  -----------------------------------------------------------------
  USE flags ...

  ... in make.conf:
USE="  -openssl -gnutls libressl pax_kernel xtpax -cdinstall -oci8 -bindist ssp avformat fpm glamor gnomecanvas gui help imap -jpeg libinput mbox midi minizip mp3 mpeg3 mpg123 mysql networking pcre16 -pdo plasma rendering sockets -sourceview -sqlite ssh system-llvm traceroute webgl x264 xml xmp zip"

  ... in /etc/portage/package.use/*:
  mail-mta/ssmtp      mta ssl
  net-misc/wget       ssl
  app-editors/xemacs  -nopie
  dev-db/sqlite           secure-delete
  dev-lang/python         sqlite
  dev-qt/qtsql            sqlite
  mail-client/thunderbird -pulseaudio system-icu
  media-libs/libvpx       postproc
  media-libs/libpng       apng
  media-sound/pulseaudio  alsa
  media-video/ffmpeg      sdl
  sys-libs/ntdb           python
  sys-libs/tdb            python
  sys-libs/tevent         python
  x11-libs/cairo          X
  x11-libs/libxcb         xkb
  www-client/firefox      -pulseaudio system-icu
  app-crypt/mit-krb5      -pkinit
  media-video/ffmpeg      -sdl
  sys-devel/llvm          clang
  sys-libs/zlib           minizip
  x11-base/xorg-server    glamor -minimal
  app-crypt/pinentry  -qt4
  app-editors/emacs   -dbus -gtk -gtk3 -ssl -svg
  app-text/xmlto      -latex
  dev-libs/boehm-gc   threads
  dev-libs/libpcre    pcre16
  dev-lang/python     threads
  dev-qt/qtgui        egl eglfs
  dev-util/cmake      -qt4 -qt5
  dev-vcs/git         -gtk -perl
  gnome-base/librsvg  -tools
  media-libs/mesa     -vaapi
  net-nds/openldap    -sasl
  sys-apps/kmod       tools
  sys-libs/ncurses    -gpm
  x11-libs/gtk+       -cups
  net-misc/iputils -caps -filecaps
  dev-db/mysql-connector-c  -ssl
  dev-lang/python           -tk
  dev-qt/qtsql              -mysql
  mail-mta/ssmtp            libressl -gnutls

  entries in /etc/portage/package.unmask/*:
  ~sys-apps/sandbox-2.11
  ~dev-libs/botan-1.11.32
  media-video/ffmpeg
  sys-devel/gcc:6.2.0
  -----------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-4.9.3
 [2] x86_64-pc-linux-gnu-6.2.0 *
llvm-config --version:
3.8.1

Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python2.7 (fallback)

java-config:
The following VMs are available for generation-2:
  -----------------------------------------------------------------

Portage 2.3.2 (python 3.4.5-final-0, default/linux/amd64/13.0/desktop, gcc-6.2.0, glibc-2.23-r2, 4.7.10-hardened-r1 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.7.10-hardened-r1-x86_64-Intel-R-_Core-TM-_i7-3930K_CPU_@_3.20GHz-with-gentoo-2.3
KiB Mem:    65285608 total,   7602868 free
KiB Swap:   67108860 total,  67108856 free
Timestamp of repository gentoo: Sat, 29 Oct 2016 03:42:10 +0000
sh bash 4.4-r1
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
ccache version 3.2.7 [disabled]
app-shells/bash:          4.4-r1::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.0-r2::gentoo
dev-lang/python:          2.7.12::gentoo, 3.4.5::gentoo
dev-util/ccache:          3.2.7::gentoo
dev-util/cmake:           3.6.2::gentoo
sys-apps/baselayout:      2.3::gentoo
sys-apps/openrc:          0.22.2::gentoo
sys-apps/sandbox:         2.11-r2::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r2::gentoo
sys-devel/automake:       1.9.6-r4::gentoo, 1.10.3-r2::gentoo, 1.11.6-r2::gentoo, 1.12.6-r1::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo, 2.26.1::gentoo
sys-devel/gcc:            4.9.3::gentoo, 6.2.0-r1::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.7::gentoo (virtual/os-headers)
sys-libs/glibc:           2.23-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: 1

local
    location: /usr/local/portage
    masters: gentoo
    priority: 2

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/entropy /etc/omega.conf /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt /usr/share/qpsmtpd/plugins /usr/share/themes/oxygen-gtk/gtk-2.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/var/tmp/distfiles"
EMERGE_DEFAULT_OPTS="--verbose --verbose-conflicts --color=n --nospinner --tree --quiet-build"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox parallel-fetch preserve-libs protect-owned sandbox sfperms strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo rsync://mirror.netcologne.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gor.bytemark.co.uk/gentoo/ rsync://ftp.snt.utwente.nl/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 avformat berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus dri dts dvd dvdr emboss encode exif fam firefox flac fortran fpm gdbm gif glamor gnomecanvas gpm gtk gui help iconv imap ipv6 lcms ldap libinput libnotify libressl mad mbox midi minizip mmx mmxext mng modules mp3 mp4 mpeg mpeg3 mpg123 multilib mysql ncurses networking nls nptl ogg opengl openmp pam pango pax_kernel pcre pcre16 pdf plasma png policykit ppds qt3support qt4 readline rendering sdl seccomp session sockets spell sse sse2 ssh ssl ssp startup-notification svg system-llvm tcpd tiff traceroute truetype udev udisks unicode upower usb vorbis webgl wxwidgets x264 xattr xcb xml xmp xtpax xv xvid zip zlib" ABI_X86="32 64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" CURL_SSL="libressl" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" L10N="bn-BD bn-IN en ff hsb mai" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

dev-libs/libp11-0.2.8-r4::gentoo was built with the following:
USE="libressl -doc" ABI_X86="64"
Comment 1 Toralf Förster gentoo-dev 2016-10-29 07:44:00 UTC
Created attachment 451804 [details]
config.log
Comment 2 Toralf Förster gentoo-dev 2016-10-29 07:44:03 UTC
Created attachment 451806 [details]
dev-libs:libp11-0.4.2:20161029-043217.log
Comment 3 Toralf Förster gentoo-dev 2016-10-29 07:44:05 UTC
Created attachment 451808 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2016-10-29 07:44:09 UTC
Created attachment 451810 [details]
environment
Comment 5 Alon Bar-Lev (RETIRED) gentoo-dev 2016-11-15 19:14:33 UTC
 mtrojnar commented Oct 29, 2016

Supporting OpenSSL is complex enough. Supporting other libraries is not within goals of this project.
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-22 19:42:15 UTC
*** Bug 658654 has been marked as a duplicate of this bug. ***
Comment 7 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-22 19:42:28 UTC
*** Bug 658610 has been marked as a duplicate of this bug. ***
Comment 8 pagorman 2019-03-02 23:11:43 UTC
Created attachment 567520 [details, diff]
libp11-0.4.4-libressl-2.8.3.patch

First Run attempt at a patch. Uses libp11-0.4.4 only, and LibreSSL-2.8.3

Compiles, runs Yubikey Personalization Tool (gui), looking foward to other, more rigorous testing.

Mostly works by kicking every varied openssl option back to legacy, including to some interfaces that will be deprecated in 0.5.0 - hopefully LibreSSL's 2.9.X series' compatibility enhancements will make similar work easier for then.
Comment 9 Alon Bar-Lev (RETIRED) gentoo-dev 2019-03-02 23:27:39 UTC
Thanks, but please work with upstream to merge this. We should not fork upstream against its will.
Comment 10 pagorman 2019-03-04 04:02:13 UTC
(In reply to Alon Bar-Lev from comment #9)
> Thanks, but please work with upstream to merge this. We should not fork
> upstream against its will.

Looking forward to it! Just needed to get something compatible out - v0.4.4 is listed as "stable" in the portage tree, so it seemed like a reasonable starting point.

From here? Something that can be upstreamed is the goal - but that may take more time than this working/starter patch.
Comment 11 pagorman 2019-03-04 04:38:49 UTC
(In reply to Alon Bar-Lev from comment #9)
> Thanks, but please work with upstream to merge this. We should not fork
> upstream against its will.

The master branch of this library on github installs as a preliminary build for 0.4.10 - no patch needed - looking forward to seeing this in the portage tree!
Comment 12 Alon Bar-Lev (RETIRED) gentoo-dev 2019-03-04 06:35:35 UTC
Waiting for this to be released.
Comment 13 pagorman 2019-03-05 06:47:13 UTC
Created attachment 567826 [details, diff]
libp11-0.4.9-compat-LibreSSL-2.8.3.patch

(already upstreamed for libp11-0.4.10)

compiled on amd64, tested ok with "Yubikey Personalization Tool" gui.

most of the work was already done for us for v0.4.9 - only a slight update is needed to fix it with the latter-stable LibreSSL-2.8.3!

as LibreSSL catches up to TLS v1.3, more of our: 
'if defined(LIBRESSL_VERSION_NUMBER)' 
   commands become 
'if LIBRESSL_VERSION_NUMBER < 0x2080000L' 
   (For 0x2 08 03 00L as v2.8.3)

I look forward to patching with you all.
Comment 14 Alon Bar-Lev (RETIRED) gentoo-dev 2019-03-05 07:41:51 UTC
As far as I can see this[1] breaks upstream build
Please ping me when fixed/merged.
Thanks!

[1] https://github.com/OpenSC/libp11/pull/277
Comment 15 pagorman 2019-04-25 02:03:00 UTC
version bump - 0.4.10 is live. Reworked that patch to preserve openssl functionality.

builds with LibreSSL 2.9.1 or 2.8.3, with upstream v0.4.10
Comment 16 Larry the Git Cow gentoo-dev 2019-04-25 05:12:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3773cd14df1a2e6f493acb4405f02e8ddc2261e

commit b3773cd14df1a2e6f493acb4405f02e8ddc2261e
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2019-04-25 05:11:01 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2019-04-25 05:11:01 +0000

    dev-libs/libp11: version bump
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=598410
    Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org>
    Package-Manager: Portage-2.3.62, Repoman-2.3.11

 dev-libs/libp11/Manifest             |  1 +
 dev-libs/libp11/libp11-0.4.10.ebuild | 32 ++++++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)