Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584024 - media-sound/audacity-2.1.x: unmask request
Summary: media-sound/audacity-2.1.x: unmask request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: wxwidgets-3.0
  Show dependency tree
 
Reported: 2016-05-24 20:26 UTC by Pacho Ramos
Modified: 2017-06-05 09:47 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
audacity-2.1.x.patch (audacity-2.1.x.patch,1.40 KB, patch)
2016-05-28 16:42 UTC, tokiclover
Details | Diff
audacity-2.1.2 FileDialog CXX tag fix patch (audacity-2.1.2-FileDialog.patch,533 bytes, patch)
2016-06-07 18:26 UTC, Adrian Bassett
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2016-05-24 20:26:56 UTC
# Ben de Groot <yngwin@gentoo.org> (20 Jul 2015)
# Version bump is a WIP, see bug #524242
# It works (except USE=vamp) but is not up to Gentoo standards yet
>=media-sound/audacity-2.1.1

Well, the message doesn't point to the concrete issues apart of USE=vamp having some problem :/

Thanks
Comment 1 tokiclover 2016-05-28 16:42:01 UTC
Created attachment 435652 [details, diff]
audacity-2.1.x.patch

There is nothing particular in this version bump (since 2.1.0) but:
 - first use wxGTK:3.0 for 2.1.2 and wxGT:2.8 for 2.1.[01];
 - use FFmpeg-2.2.2 for >=2.1.0 (no indicaction for LibAV);

I've checked the `configure.ac' of 2.1.2 and nothing more to add to that. I couldn't compile it and test because I do not have wxGTK (a monster of 60MiB to download and CXX compilation.) I won't be using any of wxGTK nor audacity; so, leaving the test for somebody else.

Some suggestions:
 - removed libav USE flag in favour of only ffmpeg and use virtual/ffmpeg instead to simplify maintenance;
 - two use a few USE flags conditional for sanity check if available;
 - use virtual/libintl instead of sys-devel/gettext; backport virtual/pkgconfig to previous versions;
 - forgot something?

Well, done checking. -- At least unmasking can be done. I cannnot verify that LV2 requirement thing... Well, no wxGTK for now.
Comment 2 Adrian Bassett 2016-06-07 18:26:01 UTC
(In reply to tokiclover from comment #1)
> Created attachment 435652 [details, diff] [details, diff]
> audacity-2.1.x.patch
> 
> There is nothing particular in this version bump (since 2.1.0) but:
>  - first use wxGTK:3.0 for 2.1.2 and wxGT:2.8 for 2.1.[01];
>  - use FFmpeg-2.2.2 for >=2.1.0 (no indicaction for LibAV);
> 
> I've checked the `configure.ac' of 2.1.2 and nothing more to add to that. I
> couldn't compile it and test because I do not have wxGTK (a monster of 60MiB
> to download and CXX compilation.) I won't be using any of wxGTK nor
> audacity; so, leaving the test for somebody else.
> 
> Some suggestions:
>  - removed libav USE flag in favour of only ffmpeg and use virtual/ffmpeg
> instead to simplify maintenance;
>  - two use a few USE flags conditional for sanity check if available;
>  - use virtual/libintl instead of sys-devel/gettext; backport
> virtual/pkgconfig to previous versions;
>  - forgot something?
> 
> Well, done checking. -- At least unmasking can be done. I cannnot verify
> that LV2 requirement thing... Well, no wxGTK for now.

I noticed this thread so I unmasked and tried to install audacity 2.1.2 with the following USE flags:

[ebuild   R   #] media-sound/audacity-2.1.2::gentoo  USE="alsa doc ffmpeg flac id3tag jack ladspa lame lv2 mad midi nls portmixer sbsms soundtouch twolame vorbis vst -libav -vamp" CPU_FLAGS_X86="sse" 0 KiB

which fairly soon failed with:

/bin/sh ./libtool    --mode=link x86_64-pc-linux-gnu-g++  -g -O2  -O2 -march=core2 -mtune=core2 -mmmx -msse -msse2 -msse3 -mssse3 -msse4.1 -mfpmath=sse -pipe -frecord-gcc-switches -Wl,-O1 -Wl,--as-needed -Wl,--as-needed   -o libFileDialog.la -rpath /usr/lib64 libFileDialog_la-FileDialog.lo gtk/libFileDialog_la-FileDialogPrivate.lo    -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype
libtool: link: unable to infer tagged configuration
libtool: link: specify a tag with `--tag'
make[2]: *** [Makefile:524: libFileDialog.la] Error 1

However, a fix is in the thread at:

https://sourceforge.net/p/audacity/mailman/message/34790846/
 
which I applied to the code as unpacked in PORTAGE_TMPDIR and finished the install manually using ebuild.

This was using gcc-5.3.0 (I didn't try gcc-4.x).

Attchament is a unified diff of the minor change required.
Comment 3 Adrian Bassett 2016-06-07 18:26:57 UTC
Created attachment 436824 [details, diff]
audacity-2.1.2 FileDialog CXX tag fix patch
Comment 4 Adrian Bassett 2017-01-29 12:15:17 UTC
(In reply to Adrian.Bassett from comment #3)
> Created attachment 436824 [details, diff] [details, diff]
> audacity-2.1.2 FileDialog CXX tag fix patch

Just to say that incorporating this patch into the 2.1.2 ebuild requires the epatch statement to be in the src_configure() section as it patches files only created after configure is run.  There is presumably a cleaner way to do this ...
Comment 5 Alexis Ballier gentoo-dev 2017-02-08 17:12:49 UTC
Since Lars seems to have been doing latest bumps, I'll let him decide.

+1 for unmasking
Comment 6 Manfred Knick 2017-04-22 21:43:33 UTC
REFERENCE:

Please c.f.   Bug 616304
Comment 7 Pacho Ramos gentoo-dev 2017-06-05 09:47:34 UTC
master 83fdee255fb] package.mask: unmask audacity-2.1.3 (#584024)
 1 file changed, 5 deletions(-)