Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 582564 - dev-db/redis - sharedlua patch breaks crosscompiling
Summary: dev-db/redis - sharedlua patch breaks crosscompiling
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sam James
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-05-09 12:18 UTC by Hasso Tepper
Modified: 2021-06-17 04:33 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (redis-pkg-config-cross.patch,3.94 KB, patch)
2016-05-09 12:18 UTC, Hasso Tepper
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hasso Tepper 2016-05-09 12:18:47 UTC
Created attachment 433764 [details, diff]
Patch

The patch calls uses pkg-config directly which calls it for host, not for target as intended. A proposed patch is attached.
Comment 1 Tiziano Müller (RETIRED) gentoo-dev 2016-08-18 14:30:35 UTC
The right way to do it is to put PKG_CHECK_MODULES calls for lua in the configure.ac we already provide and not call pkg-config in the Makefile at all.
Comment 2 Tiziano Müller (RETIRED) gentoo-dev 2016-08-18 15:27:15 UTC
here is a bumped redis with a configure.ac implementing the suggested way:

https://gitweb.gentoo.org/dev/dev-zero.git/tree/dev-db/redis?id=663cdce8c01bb9809313b7008a4fedc41c6243db

Please note: it requires either lua:5.1 (still p.masked) or luajit.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-06-17 04:33:43 UTC
This doesn't seem relevant anymore, we don't use pkg-config in our shared-lua patch.