Created attachment 424438 [details] pidgin-skypeweb-9999.ebuild Plugin for skype chat. Web version used - no skype application needed.
Are you by chance interested in proxy maintaining this? https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers#What_it_takes_to_be_a_Proxied_Maintainer Additionally, I'd highly recommend have a versioned ebuild as well. Looks like upstream has version 1.1 as their latest.
Created attachment 424480 [details] pidgin-skypeweb-1.1.ebuild Here is lastest release ebuild. And yes, I'm interested in proxy maintaining
*** Bug 257832 has been marked as a duplicate of this bug. ***
(In reply to NP-Hardass from comment #1) > Are you by chance interested in proxy maintaining this? > https://wiki.gentoo.org/wiki/Project: > Proxy_Maintainers#What_it_takes_to_be_a_Proxied_Maintainer > > Additionally, I'd highly recommend have a versioned ebuild as well. Looks > like upstream has version 1.1 as their latest. Thank you for your feedback
(In reply to NP-Hardass from comment #1) > Are you by chance interested in proxy maintaining this? > https://wiki.gentoo.org/wiki/Project: > Proxy_Maintainers#What_it_takes_to_be_a_Proxied_Maintainer > > Additionally, I'd highly recommend have a versioned ebuild as well. Looks > like upstream has version 1.1 as their latest. Thank you for your feedback. Can you review my ebuilds for pushing it to the sunrise?
I did not test this, but here's some comments :) > SRC_URI="https://github.com/EionRobb/skype4pidgin/archive/${PV}.tar.gz" Please don't do this, it produces a file named '1.1.tar.gz' in users' DISTDIR. Rather use EAPI 2 style renaming like this: SRC_URI=".../${PV}.tar.gz -> ${P}.tar.gz" > LICENSE="GPL-3" Afaict it is supposed to be GPL-3+ (... or later version). > KEYWORDS="~amd64 ~x86" In a live (git checkout) ebuild you should not set KEYWORDS.
Created attachment 424646 [details] pidgin-skypeweb-9999.ebuild license fixed, keywords removed
Created attachment 424648 [details] pidgin-skypeweb-1.1.ebuild license fixed, distfile renamed. Also EAPI="5" included
(In reply to Igor Mikeshin from comment #8) > Created attachment 424648 [details] > pidgin-skypeweb-1.1.ebuild > > license fixed, distfile renamed. > Also EAPI="5" included Hey Igor, sorry for the delay in responding. A couple of things to keep in mind: The header that all ebuilds in Gentoo have is # Copyright 1999-2016 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Id$ (you do need to assign copyright to the foundation, I can get materials on this subject if need be) A couple of minor aesthetic things that should be fixed: your second line in RDEPEND should only be indented once as it is only one level in, your spacing in the description as well as a stray capital 'L' in there. General rule, you should always run repoman to check for QA issues. It's a great tool. So in your pkg directory in your local overlay, just run `repoman full` and it'll mention all sorts of things (Like I keep forgetting to update the copyright year from 2015 to 2016 :P) I'll await your update :)
Created attachment 424746 [details] pidgin-skypeweb-1.1.ebuild gentoo header and presentation fixes
Created attachment 424748 [details] pidgin-skypeweb-9999.ebuild gentoo header and presentation fixes
Created attachment 424750 [details] metadata repoman also asks for metadata.xml !
Hi, I apologize for the long scary comment before I begin :) $ ls Manifest metadata.xml pidgin-skypeweb-1.1.ebuild pidgin-skypeweb-9999.ebuild $ repoman full RepoMan scours the neighborhood... RepoMan sez: "If everyone were like you, I'd be out of business!" $ ebuild pidgin-skypeweb-1.1.ebuild install >>> Completed installing pidgin-skypeweb-1.1 into /var/tmp/portage/x11-plugins/pidgin-skypeweb-1.1/image/ Compiles and installs just fine. I think we need to look at the dependencies a bit more closely however. The Makefile has: GLIB_CFLAGS = `pkg-config --cflags glib-2.0` -I/usr/include $ equery b /usr/lib64/pkgconfig/glib-2.0.pc dev-libs/glib-2.44.1-r1 (/usr/lib64/pkgconfig/glib-2.0.pc) X11_LIBS = `pkg-config --libs x11` $ equery b /usr/lib64/pkgconfig/x11.pc x11-libs/libX11-1.6.3 (/usr/lib64/pkgconfig/x11.pc) At a first glance, this has a runtime dependency for both glib and libX11. However, I checked with scanelf and the .so file doesn't seem to link against libX11, but because it's part of the Makefile you have to depend on it I think. Because 'pkg-config' is used to find these flags, you need a build-time dependency for 'virtual/pkgconfig'. To my limited understanding, this ebuild does not install the dbus variation of the library (libskype_dbus.so). So DBUS dependencies are not needed. As-is, the Makefile does not respect the $(CC) variable and overrides it with gcc. However, that is an issue that needs to be fixed upstream I think. good luck!
(In reply to Göktürk Yüksek from comment #13) > Hi, I apologize for the long scary comment before I begin :) > > $ ls > Manifest metadata.xml pidgin-skypeweb-1.1.ebuild > pidgin-skypeweb-9999.ebuild > $ repoman full > RepoMan scours the neighborhood... > RepoMan sez: "If everyone were like you, I'd be out of business!" > > $ ebuild pidgin-skypeweb-1.1.ebuild install > >>> Completed installing pidgin-skypeweb-1.1 into /var/tmp/portage/x11-plugins/pidgin-skypeweb-1.1/image/ > > Compiles and installs just fine. I think we need to look at the dependencies > a bit more closely however. The Makefile has: > > GLIB_CFLAGS = `pkg-config --cflags glib-2.0` -I/usr/include > $ equery b /usr/lib64/pkgconfig/glib-2.0.pc > dev-libs/glib-2.44.1-r1 (/usr/lib64/pkgconfig/glib-2.0.pc) > > X11_LIBS = `pkg-config --libs x11` > $ equery b /usr/lib64/pkgconfig/x11.pc > x11-libs/libX11-1.6.3 (/usr/lib64/pkgconfig/x11.pc) > > At a first glance, this has a runtime dependency for both glib and libX11. > However, I checked with scanelf and the .so file doesn't seem to link > against libX11, but because it's part of the Makefile you have to depend on > it I think. Because 'pkg-config' is used to find these flags, you need a > build-time dependency for 'virtual/pkgconfig'. > > To my limited understanding, this ebuild does not install the dbus variation > of the library (libskype_dbus.so). So DBUS dependencies are not needed. > > As-is, the Makefile does not respect the $(CC) variable and overrides it > with gcc. However, that is an issue that needs to be fixed upstream I think. > > good luck! Hi, Makefile in the root of skype4pidgin directory is not used. skype4pidgin is old plugin, which uses dbus to talk with skype using skype API. skypeweb is only subdir and it has own Makefile. I changed ${S} dir to work inside skypeweb subdir. Please tell me if there is better way to work with only part of distfile archive. Btw, I found out that I did not install icons! Thanks for aiming.
> Hi, > Makefile in the root of skype4pidgin directory is not used. > skype4pidgin is old plugin, which uses dbus to talk with skype using skype > API. > skypeweb is only subdir and it has own Makefile. > I changed ${S} dir to work inside skypeweb subdir. Please tell me if there > is better way to work with only part of distfile archive. > Btw, I found out that I did not install icons! Thanks for aiming. Sorry for confusing you. If the cmake lists the deps correctly, then you have all of them. You still need the DEPEND="virtual/pkgconfig" I think: https://github.com/EionRobb/skype4pidgin/blob/master/skypeweb/CMakeLists.txt#L54
Created attachment 424824 [details] pidgin-skypeweb-1.1.ebuild new dep virtual/pkgconfig, switch to default "make install" (with readme and icons)
Created attachment 424826 [details] pidgin-skypeweb-9999.ebuild new dep virtual/pkgconfig, switch to default "make install" (with readme and icons)
> As-is, the Makefile does not respect the $(CC) variable and overrides it > with gcc. However, that is an issue that needs to be fixed upstream I think. > Ignore this bit too. The package directory has both cmake and Makefile. The Makefile seems to respect CC so it's all good. There's one minor issue that there's an empty checkbox in the preferences window. I've created a PR for it: https://github.com/EionRobb/skype4pidgin/pull/409 We'll see. If they accept it, we can do a revision in the future and backport it. I think as-is this looks good. My pidgin is still alive. Good job!
(In reply to Igor Mikeshin from comment #5) > (In reply to NP-Hardass from comment #1) > > Are you by chance interested in proxy maintaining this? > > https://wiki.gentoo.org/wiki/Project: > > Proxy_Maintainers#What_it_takes_to_be_a_Proxied_Maintainer > > > > Additionally, I'd highly recommend have a versioned ebuild as well. Looks > > like upstream has version 1.1 as their latest. > > Thank you for your feedback. Can you review my ebuilds for pushing it to the > sunrise? Hello Igor, Just wanted to clarify before commit. You want to proxy-maint this in the main gentoo repo and not the sunrise project, correct? Proxy-maintainers are reachable via cc on bugzilla to proxy-maint@gentoo.org, email to proxy-maint@gentoo.org, and the #gentoo-proxy-maint IRC channel on Freenode. Sunrise is mostly defunct at present. Anytime you have an ebuild to commit, you just bring us in, and we help make sure the ebuild is good to go.
(In reply to NP-Hardass from comment #19) > (In reply to Igor Mikeshin from comment #5) > > Thank you for your feedback. Can you review my ebuilds for pushing it to the > > sunrise? > > Hello Igor, > Just wanted to clarify before commit. You want to proxy-maint this in the > main gentoo repo and not the sunrise project, correct? Proxy-maintainers > are reachable via cc on bugzilla to proxy-maint@gentoo.org, email to > proxy-maint@gentoo.org, and the #gentoo-proxy-maint IRC channel on Freenode. > Sunrise is mostly defunct at present. Anytime you have an ebuild to commit, > you just bring us in, and we help make sure the ebuild is good to go. It is correct. I was misunderstood that proxy-maintaining is the step after the sunrise. Now its clear that it is alternative.
Resolved in e3d757b90a16e0511865592685ce2a0249c484b9. I am please to officially welcome you to the proxy-maint family :)
