Unreal Engine 4 is a complete suite of game development tools made by game developers, for game developers. From 2D mobile games to console blockbusters and VR, Unreal Engine 4 gives you everything you need to start, ship, grow and stand out from the crowd. Reproducible: Always
Created attachment 422636 [details] My attemp for ebuild
feedback: 1. fix the indentation. Gentoo repo ebuilds must use tabs for indentation. 2. "custom" is not a valid license. 3. underscore function naming is preferred. 4. requiring local toolchain is almost always wrong because of cross-compiling. 5. what's with the src_install?
Created attachment 422930 [details] fixed ebuild (In reply to Alex Xu (Hello71) from comment #2) > feedback: > > 1. fix the indentation. Gentoo repo ebuilds must use tabs for indentation. > > 2. "custom" is not a valid license. > > 3. underscore function naming is preferred. > > 4. requiring local toolchain is almost always wrong because of > cross-compiling. > > 5. what's with the src_install? 1. done 2. How do I add a custom license? 3. done 4. How should it be done then? 5. What's with it?
(In reply to Evgeniy from comment #3) > Created attachment 422930 [details] > fixed ebuild > > (In reply to Alex Xu (Hello71) from comment #2) > > feedback: > > > > 1. fix the indentation. Gentoo repo ebuilds must use tabs for indentation. > > > > 2. "custom" is not a valid license. > > > > 3. underscore function naming is preferred. > > > > 4. requiring local toolchain is almost always wrong because of > > cross-compiling. > > > > 5. what's with the src_install? > > 1. done what about all the other functions? > 2. How do I add a custom license? add it to /usr/portage/licenses, but here just attach it > 3. done > 4. How should it be done then? can't find any good links at present. do some research on linux cross-compiling. > 5. What's with it? "?'doins -r Engine" is not a valid command.
Created attachment 423208 [details] ebuild v3
Created attachment 423210 [details] License
I wanna help review too! If any of the below are intentional, a comment about why it is so is warranted IMO. :) A) Please use repoman to check for technical and stylistic errors like trailing/leading spaces ;) B) x11-base/xorg-server in RDEPEND is probably not correct. Usually, a client application does not need to run on the same system as the X11 server. C) I'm unsure why you are setting EGIT_CHECKOUT_DIR and S, afaict the defaults should be fine. D) dev-lang/python in DEPEND is definitely wrong. Use the python eclasses :) E) Does something compile and link against static libraries at /runtime/? Otherwise the somelibrary[static-libs] RDEPENDS are wrong. F) You might want to consult with games team (#gentoo-games on freenode) about use requirements for media-libs/libsdl2 G) Commands that can fail (pushd, popd, ln, rm, mkdir, cp, chmod, other random executables) should be followed by '|| die' or 'assert'. H) You should probably use fperms in stead for chmod. I) When installing system icons, you should inherit gnome2-utils and call 'gnome2_icon_savelist' in pkg_preinst and gnome2_icon_cache_update in pkg_postinst and pkg_postrm. J) Don't use `command substitutions`. Ebuilds are bash, and have sane $(syntax). K) Also don't use /usr/bin/test when you can use bash [[conditional expressions]]. L) The elog message in src_unpack indicate that some github user credentials should be used. It is not clear to me where the user should provide these, and I thought https:// git connections could only be anonymous?
(In reply to eroen from comment #7) > A) Please use repoman to check for technical and stylistic errors like > trailing/leading spaces ;) done > B) x11-base/xorg-server in RDEPEND is probably not correct. Usually, a > client application does not need to run on the same system as the X11 server. Is x11-libs/libX11 right dependency for X11 then? > F) You might want to consult with games team (#gentoo-games on freenode) > about use requirements for media-libs/libsdl2 I will > G) Commands that can fail (pushd, popd, ln, rm, mkdir, cp, chmod, other > random executables) should be followed by '|| die' or 'assert'. Done > H) You should probably use fperms in stead for chmod. Sure. Done. > K) Also don't use /usr/bin/test when you can use bash [[conditional > expressions]]. What lines exactly are you talking about? > L) The elog message in src_unpack indicate that some github user credentials > should be used. It is not clear to me where the user should provide these, > and I thought https:// git connections could only be anonymous? You need to have your github account and you need to log in into GitHub to get access to private repo. I have no immediate answer for parts I skipped. Thanks for your help. If you have something to add, you are welcome.
Created attachment 423482 [details] ebuild v4
(In reply to Evgeniy from comment #8) > (In reply to eroen from comment #7) > > > A) Please use repoman to check for technical and stylistic errors like > > trailing/leading spaces ;) > done src_prepare is *still* wrong > > B) x11-base/xorg-server in RDEPEND is probably not correct. Usually, a > > client application does not need to run on the same system as the X11 server. > Is x11-libs/libX11 right dependency for X11 then? depends on whether the binaries actually use it. > > F) You might want to consult with games team (#gentoo-games on freenode) > > about use requirements for media-libs/libsdl2 > I will > > > G) Commands that can fail (pushd, popd, ln, rm, mkdir, cp, chmod, other > > random executables) should be followed by '|| die' or 'assert'. > Done > > > H) You should probably use fperms in stead for chmod. > Sure. Done. how are you using fperms with an absolute path > > K) Also don't use /usr/bin/test when you can use bash [[conditional > > expressions]]. > What lines exactly are you talking about? > [ is an alias for test also: DEPEND=clang is still almost certainly wrong. ask toolchain. don't use UpperCamelCase variable names. underscores or regular camelCase. don't use basename. ${var##*/} while : is almost certainly a bad idea. why does it crash? if you really need to restart it, can you do it once only? don't use ALLCAPS for internal variables, that is reserved by convention for exported vars
> (In reply to Evgeniy from comment #8) > > (In reply to eroen from comment #7) > > > > > K) Also don't use /usr/bin/test when you can use bash [[conditional > > > expressions]]. > > What lines exactly are you talking about? > > > > [ is an alias for test Both [ and test are shell builtins in Bash; neither /usr/bin/[ nor /usr/bin/test is used. As mentioned above, ebuilds are Bash, not generic shell. The reason to change from [ to [[ would be potential spaces in the unquoted paths being passed, not because of some external command that isn't even called.
Is there a public overlay with this ebuild?
Created attachment 443432 [details] ebuild v5
(In reply to reagentoo from comment #12) > Is there a public overlay with this ebuild? No there isn't. I have not enough time and experience to finish the ebuild and try to get it into some repo (sunrise?), but you're welcome to help or find someone willing to help.
*** Bug 914253 has been marked as a duplicate of this bug. ***
