Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 566068 - www-client/elinks: add libressl support
Summary: www-client/elinks: add libressl support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard:
Keywords:
: 570592 (view as bug list)
Depends on:
Blocks: libressl-support
  Show dependency tree
 
Reported: 2015-11-17 17:32 UTC by Marek Behún
Modified: 2016-04-15 11:29 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
elinks-0.12_pre6-r2.ebuild.patch (file_566068.txt,1.22 KB, patch)
2015-11-17 17:33 UTC, Marek Behún
Details | Diff
elinks-0.12_pre6-libressl.patch (file_566068.txt,1.46 KB, patch)
2015-11-17 17:33 UTC, Marek Behún
Details | Diff
elinks-0.12_pre6-libressl.patch (file_566068.txt,919 bytes, text/plain)
2015-11-18 09:28 UTC, Marek Behún
Details
LibreSSL patch #1 (elinks-0.12_pre5-libressl1.patch,775 bytes, patch)
2015-11-19 12:58 UTC, James L. Hammons
Details | Diff
LibreSSL patch #2 (elinks-0.12_pre5-libressl2.patch,649 bytes, patch)
2015-11-19 12:58 UTC, James L. Hammons
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Behún 2015-11-17 17:32:10 UTC
elinks uses RAND_egd, which is removed from LibreSSL. This patch removes the use of RAND_egd. I have also sent this patch to mainstream.

Reproducible: Always
Comment 1 Marek Behún 2015-11-17 17:33:22 UTC
Created attachment 417234 [details, diff]
elinks-0.12_pre6-r2.ebuild.patch
Comment 2 Marek Behún 2015-11-17 17:33:52 UTC
Created attachment 417236 [details, diff]
elinks-0.12_pre6-libressl.patch
Comment 3 Marek Behún 2015-11-18 09:28:16 UTC
Created attachment 417266 [details]
elinks-0.12_pre6-libressl.patch
Comment 4 James L. Hammons 2015-11-19 12:56:40 UTC
The LibreSSL devs have put up a page with patches to packages that haven't yet reached compatibility with LibreSSL at http://www.libressl.org/patches.html ; this may be handy for those who are dealing with such packages. :-) They are also sending their patches to upstream as well. Whether or not upstream accepts their patches, well... :-P

I adapted the patches on that page for elinks-0.12_pre6-r1; they didn't apply cleanly as they were (I will attach them to this bug). Other than that, the ebuild patch Marek wrote is good (I only had to change the epatch lines to point to the patches I got from the aforementioned page and remove Marek's patch).

I think the LibreSSL patch is better because it's less of a "scorched earth" approach than Marek's. No offense is meant Marek; I'm glad you opened this bug and took the time to patch the ebuild. :-)
Comment 5 James L. Hammons 2015-11-19 12:58:09 UTC
Created attachment 417360 [details, diff]
LibreSSL patch #1
Comment 6 James L. Hammons 2015-11-19 12:58:37 UTC
Created attachment 417362 [details, diff]
LibreSSL patch #2
Comment 7 Marek Behún 2015-11-19 14:33:41 UTC
As hasufell wrote here https://github.com/heimdal/heimdal/commit/427a60057cbb27cde5f7cf412dfebc52ba709c86

"The EGD daemon is completely unmaintained and has not seen a release
since 13 years which is not an acceptable timeframe for cryptographic
software. It is not packaged in any linux distribution I know of
and definitely not in *BSD."

As I see it, the new versions of such programs probably will not work at all with such old systems that have need for EGD daemons, and as it is cryptographicaly insecure to use EGD, programs should not be using them at all.

But of course it does not matter to me what patch will be used, as long as Gentoo's support for LibreSSL grows :)
Comment 8 James L. Hammons 2015-11-20 04:12:45 UTC
I have no idea why the BSD guys wrote their patch that way then.

Also, 100% agreed, I don't care which patch gets used as long as it helps LibreSSL adoption. :-)
Comment 9 Felix Janda 2016-01-02 13:27:45 UTC
Upstream has recently applied half of the libressl patches:

http://repo.or.cz/elinks.git/commit/f4a58ba3b574a478fd5954ba2c5b29e8b809ff9b

I guess the code between the ifdefs is now dead...
Comment 10 Patrice Clement gentoo-dev 2016-01-03 22:35:28 UTC
*** Bug 570592 has been marked as a duplicate of this bug. ***
Comment 11 Patrice Clement gentoo-dev 2016-01-03 22:36:51 UTC
Folks, if you don't CC maintainers in, there's very little chance to have the patch merged into Portage (close to none).
Comment 12 James L. Hammons 2016-01-04 14:22:54 UTC
Call me crazy, but I assumed that the system did that for you automagically.
Comment 13 timofonic 2016-03-03 10:28:53 UTC
Any news about merging the patches?
Comment 14 Anthony Basile gentoo-dev 2016-04-15 11:19:56 UTC
(In reply to timofonic from comment #13)
> Any news about merging the patches?

can you pleaes test elinks-9999.ebuild.  following on felix's observation, it should work.
Comment 15 Anthony Basile gentoo-dev 2016-04-15 11:29:29 UTC
(In reply to Anthony Basile from comment #14)
> (In reply to timofonic from comment #13)
> > Any news about merging the patches?
> 
> can you pleaes test elinks-9999.ebuild.  following on felix's observation,
> it should work.

actually i just tested.  i'm marking this resolved upstream, please reopen if there's still an issue.