565386 – sys-apps/portage - emerge --sync does not respect --ask when sync-type=git

Bug 565386 - sys-apps/portage - emerge --sync does not respect --ask when sync-type=git

Summary: sys-apps/portage - emerge --sync does not respect --ask when sync-type=git

Status:	CONFIRMED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core - Interface (emerge) (show other bugs)
Hardware:	All Linux

Importance:	Normal minor (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	240187
	Show dependency tree

Reported:	2015-11-10 14:48 UTC by redneb
Modified:	2015-11-10 23:32 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description redneb 2015-11-10 14:48:54 UTC

I have sync-type = git in my repos.conf/gentoo.conf and I noticed that when I run

  emerge --sync --ask

then it proceeds with the sync operation (i.e. it invokes git pull) as if the --ask flag was not specified. On the other hand, when the rsync sync-type is used, portage does respect the --ask flag and asks for user confirmation first.

Comment 1 Zac Medico gentoo-dev

2015-11-10 17:39:22 UTC

Considering the new parallel sync code from bug 557426, we need to move the prompt somewhere before SyncRepos._sync begins syncing the repos in parallel (or else we could end up having multiple simultaneous prompts from concurrent sync jobs).