Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 561922 - media-sound/umurmur add libressl support
Summary: media-sound/umurmur add libressl support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: libressl-support
  Show dependency tree
 
Reported: 2015-09-30 20:01 UTC by Julian Ospald
Modified: 2015-10-01 08:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
umurmur-0.2.16a-r1.ebuild.diff (umurmur-0.2.16a-r1.ebuild.diff,1.52 KB, patch)
2015-09-30 20:01 UTC, Julian Ospald 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2015-09-30 20:01:50 UTC 
Created attachment 413388 [details, diff]
umurmur-0.2.16a-r1.ebuild.diff

this also fixes:
* move the ssl provider check to pkg_pretend because that is the proper place to do it, since it is presented before the actual merge is done and the user can still abort, which is not sanely possible in src_configure
* don't add dependencies on ssl providers which are not chosen (due to our precedence detection)
Comment 1 Alex Xu (Hello71) 2015-09-30 20:31:42 UTC 
LGTM (although I still wonder if we should have an eclass for this).
Comment 2 Julian Ospald 2015-09-30 20:39:46 UTC 
(In reply to Alex Xu (Hello71) from comment #1)
> LGTM (although I still wonder if we should have an eclass for this).

eclass for what?
Comment 3 Alex Xu (Hello71) 2015-09-30 22:01:05 UTC 
(In reply to Julian Ospald (hasufell) from comment #2)
> (In reply to Alex Xu (Hello71) from comment #1)
> > LGTM (although I still wonder if we should have an eclass for this).
> 
> eclass for what?

ssl library selection.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2015-10-01 08:08:02 UTC 
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Thu Oct 1 09:49:06 2015

    media-sound/umurmur: Revbump to add libressl support (bug #561922)

    Package-Manager: portage-2.2.22
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
Comment 5 Julian Ospald 2015-10-01 08:45:27 UTC 
(In reply to Alex Xu (Hello71) from comment #3)
> (In reply to Julian Ospald (hasufell) from comment #2)
> > (In reply to Alex Xu (Hello71) from comment #1)
> > > LGTM (although I still wonder if we should have an eclass for this).
> > 
> > eclass for what?
> 
> ssl library selection.

That selection is ebuild specific here.