Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 557856 - net-p2p/bittorrent: Unspecified vulnerability (CVE-2015-5474)
Summary: net-p2p/bittorrent: Unspecified vulnerability (CVE-2015-5474)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Security
URL:
Whiteboard: C2 [noglsa/cve]
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2015-08-15 15:58 UTC by GLSAMaker/CVETool Bot
Modified: 2016-01-01 18:35 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description GLSAMaker/CVETool Bot gentoo-dev 2015-08-15 15:58:59 UTC
CVE-2015-5474 (http://nvd.nist.gov/nvd.cfm?cvename=CVE-2015-5474):
  BitTorrent and uTorrent allow remote attackers to inject command line
  parameters and execute arbitrary commands via a crafted URL using the (1)
  bittorrent or (2) magnet protocol.
Comment 1 Yury German Gentoo Infrastructure gentoo-dev 2015-11-03 17:46:45 UTC
Is there any movement on this?
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2015-11-03 19:38:48 UTC
Find me a patch and I'll apply it.  bittorrent hasn't been updated since 2006.
Comment 3 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2015-11-03 19:47:25 UTC
(In reply to Ryan Hill from comment #2)
> Find me a patch and I'll apply it.  bittorrent hasn't been updated since
> 2006.

should we even keep such crap in the tree rather than remove or at least mask it?
Comment 4 Ryan Hill (RETIRED) gentoo-dev 2015-11-03 22:05:15 UTC
The last time I tried to remove it infra asked me not to.  Bug #336166.
Comment 5 Yury German Gentoo Infrastructure gentoo-dev 2015-11-03 22:53:04 UTC
So for now lets Mask it. Any objections to that?
Comment 6 Ryan Hill (RETIRED) gentoo-dev 2015-11-03 23:28:30 UTC
None, go right ahead.
Comment 7 Sergey Popov gentoo-dev 2015-11-25 08:14:48 UTC
# Sergey Popov <pinkbyte@gentoo.org> (25 Nov 2015)
# Dead upstream, security issues, see bug #557856
# Removal in a month
net-p2p/bittorrent
Comment 8 Yury German Gentoo Infrastructure gentoo-dev 2015-11-28 17:56:15 UTC
Infra are you OK with removal of BitTorrent from tree, because of dead upstream. We have other clients that are actively developed. Do you see any reason for not removing it from tree?
Comment 9 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2015-11-28 18:50:59 UTC
What is the replacement for programmatic modification of Torrents?

Here's the most recent version of the script we have for infra usage:
http://dev.gentoo.org/~robbat2/scripts/changetorrent-console-20120102
Older versions in that directory. It's mostly feature complete so hasn't needed changes since 2012. It only gets used for the LiveDVD releases, which are quite infrequent.

That's the ONLY usage of the original net-p2p/bittorrent left in infra.
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-11-28 19:04:11 UTC
I should also note that app-arch/cfv[bittorrent] requires it. And masking it broke that package. And nobody even cared to reply to my mail about it, until monsieurp volunteered to fix it himself because it triggered the failure in all incoming PRs. If you want to remove stuff, sure, but please clean up after yourselves.
Comment 11 Ryan Hill (RETIRED) gentoo-dev 2015-11-29 23:29:10 UTC
> I should also note that app-arch/cfv[bittorrent] requires it

...on hppa.
Comment 12 Octavian 2015-12-02 11:12:08 UTC
Could this one be added instead https://en.wikipedia.org/wiki/Opentracker?

There seems to be an already ebuild at 
http://gpo.zugaina.org/net-p2p/opentracker
Comment 13 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2015-12-06 22:16:37 UTC
@octavian: 
opentracker does not provide an API to edit .torrent files.
That's all the infra script does. We use public trackers, we do not run out own.
Comment 14 Yury German Gentoo Infrastructure gentoo-dev 2015-12-07 22:13:38 UTC
(In reply to Robin Johnson from comment #13)
> @octavian: 
> opentracker does not provide an API to edit .torrent files.
> That's all the infra script does. We use public trackers, we do not run out
> own.

Do you think there is a replacement that is possible?
Comment 15 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2015-12-07 22:54:35 UTC
(In reply to Yury German from comment #14)
> (In reply to Robin Johnson from comment #13)
> > @octavian: 
> > opentracker does not provide an API to edit .torrent files.
> > That's all the infra script does. We use public trackers, we do not run out
> > own.
> 
> Do you think there is a replacement that is possible?
Yes, just nobody seems to have written it at all!

Most torrent code is aimed at just running a tracker or client, not generating or editing .torrent files.

Even libtorrent doesn't let you edit the pieces that my code uses the original libraries for.
Comment 16 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2015-12-07 22:57:35 UTC
http://search.cpan.org/~sanko/Net-BitTorrent-0.052/lib/Net/BitTorrent/Torrent.pm
Is probably the closest in functionality to the original Python API, but I'm not sure it's complete either.
Comment 17 Octavian 2015-12-12 14:37:41 UTC
@Robin Johnson

1. I do run my own tracker to distribute family/friends photos. The torrents I create are also marked as private.
2. I use mktorrent to generate torrent files net-p2p/mktorrent.
Comment 18 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2015-12-15 06:18:38 UTC
(In reply to Octavian from comment #17)
> @Robin Johnson
> 
> 1. I do run my own tracker to distribute family/friends photos.
Yes, opentracker is a good replacement for this.

> The torrents I create are also marked as private.
Beware, there are clients that ignore the private bit as specified by BEP0027
[http://www.bittorrent.org/beps/bep_0027.html]. Mostly those that don't explicitly implement the required special handling for that key.

> 2. I use mktorrent to generate torrent files net-p2p/mktorrent.
Which does NOT allow the detailed tweaking of the torrent files that the old code did.
Comment 19 Pacho Ramos gentoo-dev 2015-12-31 12:08:41 UTC
removed from the tree
Comment 20 Yury German Gentoo Infrastructure gentoo-dev 2015-12-31 13:23:47 UTC
Arches and Maintainer(s), Thank you for your work.

Thank you all. Closing as noglsa.
Comment 21 Galaxy 2015-12-31 13:53:35 UTC
According to https://en.wikipedia.org/wiki/BitTorrent_(software)
````
Version 4.20 of the client was dubbed Allegro by BitTorrent Inc., in reference to protocol extensions developed by the company to accelerate download performance and ISP manageability.
Since version 6.0, the BitTorrent client has been a rebranded version of µTorrent. As a result, it is no longer open source.
````

In fact until the latest 5.30 version available from Internet Archive <http://web.archive.org/web/20100330145634/http://www.bittorrent.com/btusers/download/directory-list> as BitTorrent-5.3-GPL.tar.gz, net-p2p/bittorrent is not vulnerable.

Also, would you use BitTorrent-5.3-GPL.tar.gz to update the python lib to a newer version ?
Comment 22 Yury German Gentoo Infrastructure gentoo-dev 2015-12-31 14:54:42 UTC
We have removed bit torrent from tree.
Comment 23 Galaxy 2015-12-31 16:36:03 UTC
I did not notice until it is masked.

Since there is in fact no CVE problem, is this OK to restore it ?
Comment 24 Ryan Hill (RETIRED) gentoo-dev 2016-01-01 06:43:38 UTC
That version required packages that aren't in the tree anymore, namely wxpython-2.6.  It might be possible to restore 5.3 without the GUI bits, but someone else would need to step up and do the work.  There are much better torrent clients available that are actually maintained.  Or you could just throw the ebuild into an overlay if you really can't live without it.
Comment 25 Yury German Gentoo Infrastructure gentoo-dev 2016-01-01 18:35:13 UTC
(In reply to Galaxy from comment #23)
> I did not notice until it is masked.
> 
> Since there is in fact no CVE problem, is this OK to restore it ?

There s a high vulnerability assigned to this:

BitTorrent and uTorrent allow remote attackers to inject command line parameters and execute arbitrary commands via a crafted URL using the (1) bittorrent or (2) magnet protocol.

This project is not maintained.