Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 51559 - alsa-tools 1.0.4 does not compile with gcc3.4
Summary: alsa-tools 1.0.4 does not compile with gcc3.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Please assign to toolchain
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 48528
  Show dependency tree
 
Reported: 2004-05-20 06:30 UTC by ecco
Modified: 2004-09-02 03:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
alsa-tools-1.0.4-gcc-3.4.patch (alsa-tools-1.0.4-gcc-3.4.patch,485 bytes, patch)
2004-05-20 06:33 UTC, ecco
Details | Diff
adds a semicolon on a new line, after tag next_cli_arg (alsa-tools-1.0.5-r1.patch,386 bytes, patch)
2004-06-27 10:12 UTC, Leo Laursen
Details | Diff
alsa-tools-1.0.5-gcc34-fix.patch (alsa-tools-1.0.5-gcc34-fix.patch,531 bytes, patch)
2004-08-23 18:55 UTC, Anton Starikov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ecco 2004-05-20 06:30:19 UTC
gcc-3.4 no longer allows labels at the end of compound statements. And good riddence :P
I made a patch that should fix the problem.

Reproducible: Always
Steps to Reproduce:
1. emerge alsa-tools
2.
3.

Actual Results:  
if gcc -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\"
-DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"as10k1\"
-DVERSION=\"A0.99\" -DSTDC_HEADERS=1  -I. -I.     -g -O2 -MT as10k1.o -MD -MP
-MF ".deps/as10k1.Tpo" \
  -c -o as10k1.o `test -f 'as10k1.c' || echo './'`as10k1.c; \
then mv -f ".deps/as10k1.Tpo" ".deps/as10k1.Po"; \
else rm -f ".deps/as10k1.Tpo"; exit 1; \
fi
as10k1.c: In function `parse_cli_args':
as10k1.c:163: error: label at end of compound statement
make: *** [as10k1.o] Error 1



Portage 2.0.50-r6 (default-x86-2004.0, gcc-3.4.0, glibc-2.3.3_pre20040420-r1,
2.6.6-rc3-mm1)
=================================================================
System uname: 2.6.6-rc3-mm1 i686 AMD Athlon(tm) XP 1800+
Gentoo Base System version 1.4.14
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r3
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -O3 -mmmx -mfpmath=387 -pipe -fomit-frame-pointer
-funroll-loops -finline-limit=600 -fno-rename-registers"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.2/share/config /usr/kde/3/share/config /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O3 -mmmx -mfpmath=387 -pipe -fomit-frame-pointer
-funroll-loops -finline-limit=600 -fno-rename-registers"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://ftp.snt.utwente.nl/pub/os/linux/gentoo
ftp://ftp.snt.utwente.nl/pub/os/linux/gentoo
http://ftp.easynet.nl/mirror/gentoo/ ftp://ftp.easynet.nl/mirror/gentoo/
http://gentoo.tiscali.nl/gentoo/ ftp://ftp.tiscali.nl/pub/mirror/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X alsa apache1 apache2 apm arts avi berkdb cdr crypt cups directfb
dvd dvdr encode esd fbcon foomaticdb freetype gdbm gif gtk gtk2 imlib ipv6 java
javascript jpeg kde libg++ libwww mad md5sum mikmod mldonkeypango mmx mpeg
ncurses nls nptl oggvorbis ooo-kde opengl oss pam pdflib perl png ppds python qt
quicktime radeon readline samba sdl slang spell sse ssl svga tcpd threads tiff
truetype vim-with-x wmf x86 xinerama xml2 xmms xv zlib"
Comment 1 ecco 2004-05-20 06:33:36 UTC
Created attachment 31761 [details, diff]
alsa-tools-1.0.4-gcc-3.4.patch

I replaced that horrible goto with break. It should break out of the
switch-case and end up at the same place as the label was...
...right? It does doesn't it?
Comment 2 Mark Loeser (RETIRED) gentoo-dev 2004-05-31 09:23:12 UTC
This bug also should also apply to alsa-tools-1.0.5 now.
Comment 3 Kathy Wills 2004-05-31 17:02:29 UTC
The patch worked on alsa-tools-1.0.5. I just changed all mention of 1.0.4 to 1.0.5.
Comment 4 Selecter 2004-06-18 08:33:14 UTC
I confirm it (alsa-tools-1.0.5). Where is official patch? :)
Comment 5 Simone Piunno 2004-06-27 08:07:28 UTC
This patch is so sound I don't understand why you haven't applied it yet.
Please do! 

1.0.5-r1 still has the problem.
Comment 6 Leo Laursen 2004-06-27 10:12:47 UTC
Created attachment 34286 [details, diff]
adds a semicolon on a new line, after tag next_cli_arg

simply adding a semicolon in file as10k1.c, after the tag next_cli_arg, makes
alsa-tools 1.0.5-r1 compile with gcc-3.4.0. And it really does nothing.
Comment 7 Andrew Sayman 2004-08-15 01:37:40 UTC
This is still here. Does a new bug need to be filed (with an updated version number) so this one doesn't slip under the radar?
Comment 8 Anton Starikov 2004-08-23 18:55:05 UTC
Created attachment 38068 [details, diff]
alsa-tools-1.0.5-gcc34-fix.patch

Patch for 1.0.5.
fixed via break, label removed. It just more clean from ideological point of
view :)
Comment 9 Anton Starikov 2004-08-23 18:58:38 UTC
O! I see that there is the same patch for 1.0.4. Sorry :)
Comment 10 Travis Tilley (RETIRED) gentoo-dev 2004-09-02 03:30:19 UTC
1.0.6 has a gcc 3.4 patch.