Hello. The following message is generated during etckeeper install: * QA Notice: This ebuild installs into paths that should be created at runtime. * To fix, simply do not install into these directories. Instead, your package * should create dirs on the fly at runtime as needed via init scripts/etc... * * var/cache * var/cache/etckeeper Please fix. Reproducible: Always
Still reproducible with etckeeper-1.15. Please fix it.
Created attachment 401210 [details, diff] patch Here's the patch that fixes this problem. /var/cache/etckeeper directory is used to store a list of installed packages. This list is needed when etckeeper is configured to automatically commit changes after the package installation via package manager. This directory is created (if missing) from pre-install.d/10packagelist script before it is used. The second place where this directory is used is post-install.d/50vcs-commit script (do a `grep cache -R ./*` in sources), but it is called after pre-install.d/ scripts, so everything should run smoothly.
BTW etckeeper-1.18.1 was released though changes are cosmetical (docs only).
Please try to push your fix upstream, that would be really helpful.
(In reply to Manuel Rüger from comment #4) > Please try to push your fix upstream, that would be really helpful. What rationale should I put in it? This a Gentoo-only issue.
(In reply to Coacher from comment #5) > (In reply to Manuel Rüger from comment #4) > > Please try to push your fix upstream, that would be really helpful. > > What rationale should I put in it? This a Gentoo-only issue. Because for example it is common for programs to install docs in /usr/share/doc/${PN}, but we don't push changes upstream that make them install docs in /usr/share/doc/${PF} instead, which is the Gentoo way.
*** Bug 646914 has been marked as a duplicate of this bug. ***
What is the situation 4 years later? Any news?
I don't mind including the patch in a revbump, but I will try to contact upstream for comment anyway. I suspect as Coacher points out, it's a Gentoo-QA specific "issue" as such. Thank you for the detailed information, @Coacher.
Sorry, I don't understand why this is a QA issue. Should /var/cache/etckeeper be treated any more specifically?
(In reply to Benda Xu from comment #10) > Sorry, I don't understand why this is a QA issue. Should > /var/cache/etckeeper be treated any more specifically? Sorry, my mistake. Now I know what you mean.
(In reply to Michael 'veremitz' Everitt from comment #9) > I don't mind including the patch in a revbump, but I will try to contact > upstream for comment anyway. I suspect as Coacher points out, it's a > Gentoo-QA specific "issue" as such. > > Thank you for the detailed information, @Coacher. Received the following from the maintainer: "I guess this is a gentoo policy to not have the directory part of packages, but it is not a FHS violation for etckeeper to create it at installation time, which is done basically for informational purposes (so eg listing the contents of the etckeeper packages includes this directory that is part of it whenever it's created). I suppose the best thing for you to do is to exclude the directory from the package, which should work fine." If nobody else does, I will add the patch in over the coming week, as I'm in the middle of a project right now, due at the weekend.
Upstream isn't really doing anything wrong: they're allowed to create that directory in "make install", although if I were them, I wouldn't count on it sticking around. The FHS is unclear about whether or not directories under /var/cache are permanent, so you have to plan for the worst. In any case, instead of patching the Makefile, you can just remove ${D}/var/cache at the end of src_install in the ebuild, and then leave a comment as to why.
See: https://github.com/gentoo/gentoo/pull/12304
tmpfiles snipped was added in 1b8e6f6772146d6cd66af46f3bd5453850b5e71b
