Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 503862 - media-tv/kodi is still using sys-fs/udisks:0 instead of sys-fs/udisks:2
Summary: media-tv/kodi is still using sys-fs/udisks:0 instead of sys-fs/udisks:2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
: 510122 (view as bug list)
Depends on:
Blocks: 439624
  Show dependency tree
 
Reported: 2014-03-08 13:28 UTC by Michael Mausolf
Modified: 2018-07-09 14:21 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mausolf 2014-03-08 13:28:31 UTC
media-tv/xbmc is still using sys-fs/udisks:0 instead of sys-fs/udisks:2
Comment 1 SpanKY gentoo-dev 2014-05-08 20:13:23 UTC
in case anyone wants to look into this, xbmc doesn't link against udisks directly, it only talks to it over dbus

you can see the usage here:
  xbmc/storage/linux/UDisksProvider.cpp
and indeed, it's using the udisks-1 names rather than udisks-2.

this probably should get filed in upstream xbmc repo too ...
Comment 2 SpanKY gentoo-dev 2014-05-12 17:43:05 UTC
*** Bug 510122 has been marked as a duplicate of this bug. ***
Comment 4 SpanKY gentoo-dev 2016-08-01 03:55:20 UTC
i'm not sure the udevil patch is complete as it leaves behind the udisks interface which is still compiled & included
Comment 5 Pacho Ramos gentoo-dev 2016-10-09 12:14:48 UTC
(In reply to SpanKY from comment #4)
> i'm not sure the udevil patch is complete as it leaves behind the udisks
> interface which is still compiled & included

udevil doesn't seem to rely on udisks
Comment 6 Pacho Ramos gentoo-dev 2017-07-24 09:03:26 UTC
OK, then, we could apply the patch + another one dropping:
if(DBUS_FOUND)
  list(APPEND SOURCES UDisksProvider.cpp)
  list(APPEND HEADERS UDisksProvider.h)
endif()

from xbmc/storage/linux/CMakeLists.txt
Comment 7 Craig Andrews gentoo-dev 2017-07-24 16:13:22 UTC
(In reply to Pacho Ramos from comment #6)
> OK, then, we could apply the patch + another one dropping:
> if(DBUS_FOUND)
>   list(APPEND SOURCES UDisksProvider.cpp)
>   list(APPEND HEADERS UDisksProvider.h)
> endif()
> 
> from xbmc/storage/linux/CMakeLists.txt

Can you please submit a PR to Kodi at https://github.com/xbmc/xbmc ?
Comment 8 Craig Andrews gentoo-dev 2018-05-23 15:39:46 UTC
Kodi just merged udisk2 support: https://github.com/xbmc/xbmc/commit/325597a84eed3bd80c1a10d5f4b6765714200aec
Comment 9 Larry the Git Cow gentoo-dev 2018-05-23 15:44:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=49d8d58c46a07d1612cc8addac73b154fcc5212a

commit 49d8d58c46a07d1612cc8addac73b154fcc5212a
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2018-05-23 15:41:55 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2018-05-23 15:44:21 +0000

    media-tv/kodi: Depend on sys-fs/udisks:0 instead of sys-fs/udisks:2
    
    See https://github.com/xbmc/xbmc/commit/325597a84eed3bd80c1a10d5f4b6765714200aec
    Bug: https://bugs.gentoo.org/503862
    Package-Manager: Portage-2.3.38, Repoman-2.3.9

 media-tv/kodi/kodi-9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 10 Joakim Tjernlund 2018-05-23 17:52:05 UTC
(In reply to Craig Andrews from comment #8)
> Kodi just merged udisk2 support:
> https://github.com/xbmc/xbmc/commit/325597a84eed3bd80c1a10d5f4b6765714200aec

hmm, if Kodi just merged udisk2 why did you move the dependency to udisk:0 for
git ebuild ?
Comment 11 Joakim Tjernlund 2018-05-23 17:54:04 UTC
(In reply to Joakim Tjernlund from comment #10)
> (In reply to Craig Andrews from comment #8)
> > Kodi just merged udisk2 support:
> > https://github.com/xbmc/xbmc/commit/325597a84eed3bd80c1a10d5f4b6765714200aec
> 
> hmm, if Kodi just merged udisk2 why did you move the dependency to udisk:0
> for
> git ebuild ?

oops, I just read the commit msg, I see that -9999 now depends on :2