Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 49241 - iputils-021109-r* fails to compile with gcc 3.4.0
Summary: iputils-021109-r* fails to compile with gcc 3.4.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Please assign to toolchain
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 48528
  Show dependency tree
 
Reported: 2004-04-27 21:09 UTC by Robert Moss (RETIRED)
Modified: 2004-05-01 23:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix compilation error (021109-gcc34-2.patch,347 bytes, patch)
2004-04-27 21:09 UTC, Robert Moss (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Moss (RETIRED) gentoo-dev 2004-04-27 21:09:03 UTC
The source breaks function inlining limits, as we invalidly jump into a binding contour. The attached patch fixes this. (NB: This is probably due for a complete rewrite upstream as it's horrible!)

Reproducible: Always
Steps to Reproduce:
Comment 1 Robert Moss (RETIRED) gentoo-dev 2004-04-27 21:09:45 UTC
Created attachment 30214 [details, diff]
Patch to fix compilation error

Note that this is not the same patch as is currently found in portage - this is
in addition.
Comment 2 SpanKY gentoo-dev 2004-04-27 21:14:22 UTC
iputils emerges fine here with 3.4.0

what are your CFLAGS ?
Comment 3 Robert Moss (RETIRED) gentoo-dev 2004-04-27 21:29:15 UTC
The problem is the following flag:

"-finline-limit=xxxx"

where xxxx is an integer between 100 and 10000 (I think). Whilst it is true that removing this flag allows compilation without the above patch, the code is still broken, and this will not compile using GCC 3.5.x (i.e. mainline) with no CFLAGS at all without this patch, and will probably not compile with GCC 3.4.1 when it's released, as the fact that this doesn't break without -finline-limit has been reported as a bug upstream and should be fixed in time for that. Jumping out of loops to labels in such a fashion as occurs here is no longer conformant behaviour.
Comment 4 SpanKY gentoo-dev 2004-04-27 21:43:38 UTC
'no longer conformant behaviour' ... is that per some ISO standard ?

if so i have no problem adding the patch but otherwise, the code (while ugly), does not look 'wrong' :)
Comment 5 Robert Moss (RETIRED) gentoo-dev 2004-04-28 09:15:01 UTC
I think that if I search REALLY hard, I might be able to find the reference from the GCC mailing list, but I don't have time, I'm afraid... It was something about jumping out of a loop to a label under certain conditions. As far as I can tell, this contravenes one of those conditions...
Comment 6 Robert Moss (RETIRED) gentoo-dev 2004-04-30 18:07:34 UTC
http://gcc.gnu.org/ml/gcc-patches/2002-08/msg00432.html

Well, I didn't have time before, but I do now... I *think* this patch has only picked this up now because of the new function inlining code. Check out the testsuite function.
Comment 7 SpanKY gentoo-dev 2004-05-01 23:56:09 UTC
added to cvs, thanks for the patch