Bug 480396 – dev-libs/libgpg-error-1.12-r1: multilib

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description David Heidelberg (okias) 2013-08-09 17:54:22 UTC]

bump

Reproducible: Always

[Comment 1 David Heidelberg (okias) 2013-08-09 17:55:08 UTC]

Created attachment 355510 [details]
libgpg-error-1.12-r1.ebuild

[Comment 2 Alexis Ballier 2013-08-09 17:58:19 UTC]

its missing MULTILIB_USEDEP on virtual/libintl (and this one is not converted yet)

[Comment 3 Mike Lothian 2013-08-09 21:37:26 UTC]

Created attachment 355562 [details]
libgpg-error-1.12-r1

[Comment 4 David Heidelberg (okias) 2013-12-30 22:58:06 UTC]

Here is basic diff with USEDEP on libintl ( bug #496220 )

--- libgpg-error-1.12.ebuild    2013-12-05 14:01:10.000000000 +0100
+++ libgpg-error-1.12-r1.ebuild 2013-12-30 23:57:14.157761227 +0100
@@ -4,7 +4,7 @@
 
 EAPI=5
 
-inherit libtool
+inherit libtool multilib-minimal
 
 DESCRIPTION="Contains error handling functions used by GnuPG software"
 HOMEPAGE="http://www.gnupg.org/related_software/libgpg-error"
@@ -15,21 +15,23 @@
 KEYWORDS="alpha amd64 arm hppa ia64 ~m68k ~mips ppc ppc64 ~s390 ~sh sparc x86 ~ppc-aix ~amd64-fbsd ~sparc-fbsd ~x86-fbsd ~x64-freebsd ~x86-freebsd ~x86-interix ~amd64-linux ~arm-linux ~x86-linux ~ppc-macos ~x64-macos ~x86-macos ~m68k-mint ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris"
 IUSE="common-lisp nls static-libs"
 
-RDEPEND="nls? ( virtual/libintl )"
+RDEPEND="nls? ( virtual/libintl[${MULTILIB_USEDEP}] )"
 DEPEND="nls? ( sys-devel/gettext )"
 
 src_prepare() {
        elibtoolize
+
+       multilib_copy_sources
 }
 
-src_configure() {
+multilib_src_configure() {
        econf \
                $(use_enable nls) \
                $(use_enable static-libs static) \
                $(use_enable common-lisp languages)
 }
 
-src_install() {
+multilib_src_install_all() {
        default
 
        # library has no dependencies, so it does not need the .la file

[Comment 5 David Heidelberg (okias) 2014-01-03 22:15:45 UTC]

dev-libs/libgpg-error-1.12-r1::ixit

[Comment 6 Michał Górny 2014-01-04 09:58:14 UTC]

Created attachment 366948 [details, diff]
libgpg-error-1.12.ebuild.diff

Official multilib team ebuild.

[Comment 7 Michał Górny 2014-01-04 10:46:58 UTC]

Created attachment 366952 [details, diff]
libgpg-error-1.12.ebuild.diff, v2

Sorry, that one had potential automagic on clisp.

[Comment 8 Michał Górny 2014-01-16 18:58:09 UTC]

The necessary bits were added to the eclass as MULTILIB_CHOST_TOOLS. Is it ok to commit this ebuild and libgcrypt with that change?

[Comment 9 Alon Bar-Lev (RETIRED) 2014-01-16 21:37:20 UTC]

(In reply to Michał Górny from comment #8)
> The necessary bits were added to the eclass as MULTILIB_CHOST_TOOLS. Is it
> ok to commit this ebuild and libgcrypt with that change?

yes, however, I do not understand how it works without multiple bin directories.

[Comment 10 Alexandre Rostovtsev (RETIRED) 2014-01-16 21:47:04 UTC]

(In reply to Alon Bar-Lev from comment #9)
> how it works without multiple bin directories.

By giving executables CHOST prefixes, just like toolchain executables. In other words:

/usr/bin/i686-pc-linux-gnu-gpg-error-config
/usr/bin/x86_64-pc-linux-gnu-gpg-error-config
/usr/bin/gpg-error-config is a symlink to x86_64-pc-linux-gnu-gpg-error-config

[Comment 11 Alon Bar-Lev (RETIRED) 2014-01-16 21:50:02 UTC]

(In reply to Alexandre Rostovtsev from comment #10)
> (In reply to Alon Bar-Lev from comment #9)
> > how it works without multiple bin directories.
> 
> By giving executables CHOST prefixes, just like toolchain executables. In
> other words:
> 
> /usr/bin/i686-pc-linux-gnu-gpg-error-config
> /usr/bin/x86_64-pc-linux-gnu-gpg-error-config
> /usr/bin/gpg-error-config is a symlink to
> x86_64-pc-linux-gnu-gpg-error-config

Oh... should'nt the gpg-error-config be a wrapper that executes the originals by CHOST?

But thanks this is clearer now.

[Comment 12 Michał Górny 2014-01-16 22:06:08 UTC]

(In reply to Alon Bar-Lev from comment #11)
> (In reply to Alexandre Rostovtsev from comment #10)
> > (In reply to Alon Bar-Lev from comment #9)
> > > how it works without multiple bin directories.
> > 
> > By giving executables CHOST prefixes, just like toolchain executables. In
> > other words:
> > 
> > /usr/bin/i686-pc-linux-gnu-gpg-error-config
> > /usr/bin/x86_64-pc-linux-gnu-gpg-error-config
> > /usr/bin/gpg-error-config is a symlink to
> > x86_64-pc-linux-gnu-gpg-error-config
> 
> Oh... should'nt the gpg-error-config be a wrapper that executes the
> originals by CHOST?

It doesn't need to.

$ grep AC_PATH /usr/share/aclocal/gpg-error.m4 
  AC_PATH_TOOL(GPG_ERROR_CONFIG, gpg-error-config, no)

AC_PATH_TOOL looks for $CHOST-$2 first.

[Comment 13 David Heidelberg (okias) 2014-01-28 21:25:56 UTC]

ping, remainder :)

[Comment 14 David Heidelberg (okias) 2014-02-05 02:10:30 UTC]

crypto team, please :) look at mgorny version, if can be applied. It blocks libgcrypt needed by wine.

[Comment 15 Tim Harder 2014-02-06 00:44:29 UTC]

Added to the tree, I'll slowly work my way through the patches with the final goals being multilib libgcrypt and gnutls over the next week or so.