Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478204 - gnome-base/gnome-control-center-3.8.4.1:2 should have networkmanager and samba use flag
Summary: gnome-base/gnome-control-center-3.8.4.1:2 should have networkmanager and samb...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords: NeedPatch
: 483118 504818 606462 (view as bug list)
Depends on:
Blocks: gnome-3.30
  Show dependency tree
 
Reported: 2013-07-26 06:59 UTC by Lee Trager
Modified: 2021-01-09 17:47 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Add networkmanager and smbclient use flags to gnome-control-center (gnome-control-center.patch,1.40 KB, patch)
2013-07-26 21:11 UTC, Lee Trager
Details | Diff
Make networkmanager and modemmanager optional (gnome-control-center-3.8-optional-networkmanager.patch,2.75 KB, patch)
2013-07-30 04:11 UTC, Lee Trager
Details | Diff
ebuild updated to properly conditionalize networkmanager (gnome-control-center-3.8.4.1-r1.ebuild,5.42 KB, text/plain)
2013-07-30 04:12 UTC, Lee Trager
Details
Updated patch to make both network manager and modem manager optional (gnome-control-center-3.8-optional-networkmanager.patch,2.74 KB, patch)
2013-07-30 04:20 UTC, Lee Trager
Details | Diff
Don't make cups mandatory (gnome-light-3.8.0.ebuild,1.67 KB, text/plain)
2013-07-30 04:25 UTC, Lee Trager
Details
Updated patch to make NetworkManager optional for 3.14.5 (gnome-control-center-3.14.0-network.patch,1.78 KB, patch)
2015-05-02 18:03 UTC, Hristo Venev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lee Trager 2013-07-26 06:59:28 UTC
My system is a desktop which plugs in via ethernet. I have no need for Network-Manager on my system. Is there any reason to have it as a dependency?

Reproducible: Always
Comment 1 Lee Trager 2013-07-26 07:56:07 UTC
It would also be great if we could have +cups and -samba and eliminate the need for cifs-utils and samba.
Comment 2 Lee Trager 2013-07-26 21:11:22 UTC
Created attachment 354270 [details, diff]
Add networkmanager and smbclient use flags to gnome-control-center
Comment 3 Pacho Ramos gentoo-dev 2013-07-26 21:17:24 UTC
It's not as easy as add the USE flags, you need configure checks as, otherwise, you are still building the same code (that requires NM and samba)
Comment 4 Lee Trager 2013-07-27 03:29:35 UTC
gnome-control-center autodetects in its configure script if network-manager and samba are on the system. If they aren't it automatically disables it

From build log

checking for NETWORK_MANAGER... no
configure: WARNING: *** Network panel will not be built (NetworkManager not found) ***
checking for MM_GLIB... no
configure: WARNING: *** Network panel will not be built with ModemManager1 support (libmm-glib not found) ***
checking for BLUETOOTH... yes
checking for SMBCLIENT... no

It built fine for me.
Comment 5 Pacho Ramos gentoo-dev 2013-07-27 06:38:21 UTC
But it leads to automagic depend:
http://www.gentoo.org/proj/en/qa/automagic.xml
Comment 6 Lee Trager 2013-07-30 04:11:36 UTC
Created attachment 354576 [details, diff]
Make networkmanager and modemmanager optional

This is an addon to the existing modemmanger optional patch to make networkmanager optional as well.
Comment 7 Lee Trager 2013-07-30 04:12:33 UTC
Created attachment 354578 [details]
ebuild updated to properly conditionalize networkmanager

Howis this?
Comment 8 Lee Trager 2013-07-30 04:20:28 UTC
Created attachment 354580 [details, diff]
Updated patch to make both network manager and modem manager optional
Comment 9 Lee Trager 2013-07-30 04:25:30 UTC
Created attachment 354582 [details]
Don't make cups mandatory

I looked into making Samba optional and while it doesn't look that hard I don't have time to do it now. Can we remove the hard requires from gnome-light then? This way I can have +cups globally but disable it for gnome-control-center.
Comment 10 Lee Trager 2013-07-30 22:55:20 UTC
I've added my patch to the upstream bug as well.
Comment 11 Lee Trager 2013-08-03 07:50:53 UTC
Is there anything wrong with it now?
Comment 12 Pacho Ramos gentoo-dev 2013-08-31 09:04:37 UTC
*** Bug 483118 has been marked as a duplicate of this bug. ***
Comment 13 Lee Trager 2013-10-17 07:02:02 UTC
Can we at least make CUPS optional? It requires no patch to gnome-control-center and is purely an ebuild fix.
Comment 14 Jeroen Roovers (RETIRED) gentoo-dev 2014-03-18 17:15:05 UTC
*** Bug 504818 has been marked as a duplicate of this bug. ***
Comment 15 Johannes Buchner 2014-03-18 23:07:23 UTC
Bug 504818 was marked duplicate. It asks for making modemmanager not depend on ppp, because gnome-control-center pulls in ppp via NetworkManager at the moment.
See my suggested patch https://bugs.gentoo.org/attachment.cgi?id=372940&action=edit
Comment 16 Hristo Venev 2015-05-02 18:03:26 UTC
Created attachment 402456 [details, diff]
Updated patch to make NetworkManager optional for 3.14.5

This should make NetworkManager optional. It won't be possible to build gnome-control-center with NetworkManager but without ModemManager however.

The ebuild should be updated to pass --{enable,disable}-network.
Comment 17 Gilles Dartiguelongue (RETIRED) gentoo-dev 2015-05-12 22:19:19 UTC
I make NM optional again in 3.16 ebuilds.
Comment 18 Mart Raudsepp gentoo-dev 2017-01-18 22:50:39 UTC
*** Bug 606462 has been marked as a duplicate of this bug. ***
Comment 19 Mart Raudsepp gentoo-dev 2017-03-19 12:19:49 UTC
For 3.24 we currently have hard required cups and samba. We should try to make at least samba optional again before unmasking, or perhaps both (but the main incentive for USE=cups here I believe was always to avoid samba, not cups really). Adding blocker for tracking and not forgetting. I believe Gilles was looking at the samba dep based on 3.22 at least and found it sholudn't be hard either, hopefully the same for 3.24.
Comment 20 Mart Raudsepp gentoo-dev 2017-07-14 02:53:51 UTC
I've added (p.masked) gnome-control-center-3.24.2 with USE=cups again, which also avoids smbclient (but in expense of losing all of the printers panel again). But I didn't really test the enabled case yet, so a couple success reports on that welcome.
It would still be nice to make smbclient optional separately, as to have a full printers panel for native cups printers without windows printers support and smbclient dep. This involves various code changes related to SMB auth code in various printers panel C code and UI XML (the GtkBuilder XML can probably stay as-is, just need to not load those resources when smb disabled). This was too much for me to chew back when I worked on it, so moved on for the time being. If anyone is interested to pick, I have a dirty patch that starts the process in some places.