Bug 476100 – x11-libs/gtk+-2.24.20: gnome2-utills eclass might need an update

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Rafał Mużyło 2013-07-07 19:25:31 UTC]

Given the changes in 2.24.20, gnome2_query_immodules_gtk2 might need to be changed to something closer to gnome2_query_immodules_gtk3.
For the time being, depending on version being installed, but eventually unconditionally.

[Comment 1 Pacho Ramos 2013-07-07 19:44:13 UTC]

Created attachment 352804 [details, diff]
1.patch

I have tried this but looks to not work as I still can read:
 * Updating dconf system databases ...                                                                                                         [ ok ]
 * Generating Gtk2 immodules/gdk-pixbuf loaders listing:
 * -> /etc/gtk-2.0/x86_64-pc-linux-gnu/gtk.immodules
 * Updating icons cache ...                               

that means "has_version" hasn't work... but I don't know why :(

[Comment 2 Evgeny Bobkin 2013-07-07 19:49:03 UTC]

(In reply to Pacho Ramos from comment #1)
> Created attachment 352804 [details, diff] [details, diff]
> 1.patch
> 
> I have tried this but looks to not work as I still can read:
>  * Updating dconf system databases ...                                      
> [ ok ]
>  * Generating Gtk2 immodules/gdk-pixbuf loaders listing:
>  * -> /etc/gtk-2.0/x86_64-pc-linux-gnu/gtk.immodules
>  * Updating icons cache ...                               
> 
> that means "has_version" hasn't work... but I don't know why :(

is this the actual change? I am confused because of the indentation)) 

-	local GTK2_CONFDIR="/etc/gtk-2.0/$(get_abi_CHOST)"
+	if has_version ">=x11-libs/gtk+-2.24.20:2"; then
+		gtk-query-immodules-2.0 --update-cache
+	else
+		local GTK2_CONFDIR="/etc/gtk-2.0/$(get_abi_CHOST)"

[Comment 3 Pacho Ramos 2013-07-07 19:52:14 UTC]

Yes, in summary. I needed to change indentation making patch harder to read :S

[Comment 4 Pacho Ramos 2013-08-26 12:33:35 UTC]

@gnome, any ideas?

[Comment 5 Pacho Ramos 2013-08-26 12:34:05 UTC]

(Not sure if this could cause any kind of breakage -_-)

[Comment 6 Rafał Mużyło 2013-08-31 22:02:08 UTC]

(In reply to Pacho Ramos from comment #5)
> (Not sure if this could cause any kind of breakage -_-)

Well, given what that file is for, outside cjk range not many people use input engines (OK, not sure about India and south-east Asia, still cjk people are primary consumer of IMEs).

See GtkIMContext docs.

[Comment 7 Pacho Ramos 2013-09-07 07:50:38 UTC]

Created attachment 358136 [details, diff]
1.patch

It works ok (but I tested on a ebuild that was using its own function instead of eclass one)

[Comment 8 Pacho Ramos 2013-09-07 07:50:55 UTC]

(In reply to Pacho Ramos from comment #7)
> Created attachment 358136 [details, diff] [details, diff]
> 1.patch
> 
> It works ok (but I tested on a ebuild that was using its own function
> instead of eclass one)

Will commit in a week if nobody disagrees

[Comment 9 Pacho Ramos 2013-09-15 19:29:22 UTC]

+  15 Sep 2013; Pacho Ramos <[e-mail]> gnome2-utils.eclass:
+  Support gtk+-2.24.20 query immodules (#476100)
+