468380 – eutils.eclass: prune_libtool_files() remove *.la files, which are NOT libtool archives

Bug 468380 - eutils.eclass: prune_libtool_files() remove *.la files, which are NOT libtool archives

Summary: eutils.eclass: prune_libtool_files() remove *.la files, which are NOT libtool...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Michał Górny

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-05-03 09:32 UTC by Sergey Popov
Modified:	2013-05-21 06:30 UTC (History)
CC List:	1 user (show)

See Also:	468292 470206
Package list:
Runtime testing required:	---

Attachments
Suggested patch (0001-prune_libtool_files-do-not-remove-non-libtool-.la-fi.patch,5.29 KB, patch) 2013-05-03 15:10 UTC, Michał Górny	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sergey Popov gentoo-dev

2013-05-03 09:32:42 UTC

Just as said in summary. For example, look at bug #468292. It seems that function need some additional checks for file type(probably some kind of MIME check? dunno).

Comment 1 Michał Górny archtester

2013-05-03 14:34:11 UTC

Those files are autogenerated and therefore have quite a pre-defined format. I think we could try matching them by 'shouldnotlink=' line (which the function uses anyway).

Comment 2 Michał Górny archtester

2013-05-03 15:10:17 UTC

Created attachment 347274 [details, diff]
Suggested patch

I'll submit it to the ml after testing.

Comment 3 Michał Górny archtester

2013-05-15 19:01:49 UTC

+  15 May 2013; Michał Górny <mgorny@gentoo.org> eutils.eclass:
+  prune_libtool_files: do not remove .la files which are not libtool files.
+  Fixes bug #468380.